Bug 138709

Summary: [CellEditors] CellEditorActionHandler doesn't mirror all action state
Product: [Eclipse Project] Platform Reporter: Andrew Bachmann <AndrewBachmann>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: ASSIGNED --- QA Contact:
Severity: normal    
Priority: P3 Keywords: helpwanted
Version: 3.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Andrew Bachmann CLA 2006-04-26 14:30:37 EDT 
Currently CellEditorActionHandler uses a property change listener to follow the enablement state of the actions that are used when a cell editor is not enabled.

There are more properties that can be usefully changed, such as IAction.TEXT and IAction.TOOL_TOP_TEXT.  These most affect the usability of undo and redo.

Additionally, the CellEditorActionHandler ActionHandler classes (such as UndoActionHandler) don't update Text, ToolTipText, ImageDescriptor, or DisabledImageDescriptor when the actions are set. (such as setUndoAction)

It seems like it might be possible to address all these issues and simplify the implementation by simply calling setGlobalActionHandler for each action when the controlListener sees an Activate or Deactivate.

Currently we just augmented UndoActionHandler.updateEnabledState to set also the Text, ToolTipText, ImageDescriptor, DisabledImageDescriptor.  We also augmented the ActionPropertyChangeListener.propertyChange to pass along IAction.TEXT and IAction.TOOL_TIP_TEXT updates.  Finally, our local copy of CellEditionActionHandler also includes the fix for Bug 116614.
Comment 1 Eclipse Webmaster CLA 2019-09-06 16:15:18 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.