Bug 13730

Summary: Entire zipfiles content sent prior when computing synchronization view content
Product: [Eclipse Project] Platform Reporter: Philipe Mulet <philippe_mulet>
Component: CompareAssignee: Andre Weinand <andre_weinand>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P1 CC: James_Moody, n.a.edgar
Version: 2.0   
Target Milestone: 2.0 F3   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Philipe Mulet CLA 2002-04-12 18:16:47 EDT 
Build 20020411

When about to release a patch (org.eclipse.jdt.core239a.zip) inside my jdt-core-
home project, I select project synchronization. Since this file was already 
present on the server, it did an entire content comparison, even before I chose 
to commit it (computing a CRC?).

This is unacceptable, especially remotely.
Comment 1 Erich Gamma CLA 2002-04-12 19:01:40 EDT 
this is a consequence of showing a structure compare by default.

there is now a preference Workbench>Compare>General:Open Structure Compare 
automatically. It is on by default, as a workaround you can turn it off.

moving to Compare.

A more drastic measure is to not support structure compare for ZIP/JARs.
Comment 2 Philipe Mulet CLA 2002-04-13 04:28:52 EDT 
The defaults have to be well thought indeed. It should probably be off for 
binary files (all of them). And more important: I would like to be able to 
cancel the ongoing transfer, given in this case I knew fairly well that I 
wanted to commit whatever.

The nasty thing too is that no matter how long I wait, compare for binaries did 
not show me anything in the end, so why is it fetching all the bytes then ? The 
comparison should lazily grab the remote file if it can do anything at all with 
it.
Comment 3 Andre Weinand CLA 2002-06-07 07:35:19 EDT 
fixed for 20020607
This fix does not prevent transferring large files, however the fix makes it 
easier to avoid gratuitous downloads.
The fix is based on the OpenStrategy action but does not yet honor the global 
OpenStrategy setting in the preference page but always uses the SINGLE_CLICK + 
ARROW_KEYS_OPEN mode (we wanted to avoid to confuse users with a new UI 
paradigm).

How the fix reduces gratuitous downloads:
#1: a right click on a tree item (to open the context menu) no longer feeds the 
downstream viewers, so you can 'ignore' resources without having to download 
them first.
#2: stepping through tree items with the arrow keys feeds the downstream arrows 
only after some delay,
#3: the initial selection of the top left pane is not automatically sent to the 
downstream panes.

Other remaining issues will be reconsidered after 2.0.
Comment 4 Andre Weinand CLA 2002-06-07 15:18:49 EDT 
20020607
Downstream viewers are not flushed if selection becomes empty.
Comment 5 Andre Weinand CLA 2002-06-07 15:19:51 EDT 
*** Bug 19636 has been marked as a duplicate of this bug. ***
Comment 6 Andre Weinand CLA 2002-06-07 15:20:20 EDT 
fixed for 20020608
Comment 7 James Moody CLA 2002-06-07 15:46:46 EDT 
*** Bug 19648 has been marked as a duplicate of this bug. ***
Comment 8 Dirk Baeumer CLA 2002-06-13 04:57:23 EDT 
Verified. TB