Bug 13694

Summary: [accessibility] Update pages should not slam background colour
Product: [Eclipse Project] Platform Reporter: Tod Creasey <Tod_Creasey>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Dejan Glozic <dejan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 Keywords: accessibility
Version: 2.0   
Target Milestone: 2.0 M6   
Hardware: PC   
OS: All   
Whiteboard:

Description Tod Creasey CLA 2002-04-12 14:43:48 EDT 
On all of the Update Pages (Available Updates, Current Configuration, etc) the 
background color of the main title appears to be set to white. This should not 
be set to a fixed colour but should work like the Welcome Editor which uses 
JFaceColors.getBannerBackground().

This is unreadable when the display mode is set to High Contrast Black
Comment 1 Dejan Glozic CLA 2002-04-15 10:13:06 EDT 
Update pages use system color for list background and list foreground and 
should work well with user settings. I will test in other settings, but this is 
confusing.
Comment 2 Tod Creasey CLA 2002-04-15 10:18:53 EDT 
Please point me at the code perhaps I can help with an accessibility review. 
The problem is white text on a gradient label - in high contrast black this 
unreadable due to the white text. You should use the list background colour for 
the label rather than the gradient.
Comment 3 Dejan Glozic CLA 2002-04-15 10:23:23 EDT 
OK, so that is the problem.

Both PDE and Update use FormWidgetFactory to create its widgets, and it 
initializes like this:

	clientAreaColor = display.getSystemColor(SWT.COLOR_LIST_BACKGROUND);
	foregroundColor = display.getSystemColor(SWT.COLOR_LIST_FOREGROUND);

Therefore, without the gradient itself, it would work, but since gradient
is a fixed JPG, it does not work well. I should perhaps detect non-default
background and drop the background.

Also be advised that we were out of cycles to test on Linux so there may be a 
lot of issues there that we indent to fix soon.
Comment 4 Tod Creasey CLA 2002-04-15 10:29:10 EDT 
In all other places we have decided to dump the gradient as a background 
altoghether and use the list background. This would be easier than some sort of 
detection and consistent with the rest of the UI. See the Welcome page for an 
example if you need it.
Comment 5 Christophe Elek CLA 2002-04-16 22:08:24 EDT 
[accessibility]
Comment 6 Dejan Glozic CLA 2002-04-17 19:41:56 EDT 
Fixed by dropping the banner if the background is not white (since it is a 
fixed gradient image that cannot track background changes and was designed for 
white background).
Comment 7 Dejan Glozic CLA 2002-04-17 19:45:41 EDT 
Forgot to change state.