Summary: | Remove ReconcileContext#getASTLevel() and rename getAST3() to getAST() | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Martin Aeschlimann <martinae> |
Component: | Core | Assignee: | JDT-Core-Inbox <jdt-core-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | daniel_megert, jerome_lanneluc |
Version: | 3.2 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Martin Aeschlimann
2006-03-01 12:43:20 EST
Questions about the design of JDT Core should be asked on jdt-core-dev@eclipse.org . If the resulting discussion leads to a problem, only then a bug should be entered. In the case of this bug report, it is unclear if this is a design problem or a question about the API. I am pointing to a design problem, yes! And I'm suggesting a better API, anticipate new AST levels in the future. I think a bug is a good place to discuss such an API. The you can decide if you want to fix this, or not. This isn't as easy on a mailing list. Sorry but the summary "ReconcileContext API: why both getASTLevel and getAST3?" suggested otherwise. Reopening and changing it to "Remove ReconcileContext#getASTLevel() and rename getAST3() to getAST()". Feel free to change it if it doesn't reflect your request. That's better, you're right. Martin, is this still accurate? Do we want to change this post 3.2? I would still suggest to add a method getAST and spec that it returns the 'latest' level and all participants have to first check if they can deal with this level, or not participate otherwise. But this is lower priority, as long as the reconcile participation story isn't really ready to used by clients. After thinking again I think the way to go is with bug 124662, where the working copy owner can specify what kind of AST are to be created on reconcile. The ReconcileContext.getAST just specifies that the AST returned is created using the options (AST kind/recovered/bindings) in the working copy owner, and if a client doesn't want/doesn't understand this kind, he should not participate. |