Bugzilla – Full Text Bug Listing
| Summary: | System Settings being fired too often | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tod Creasey <Tod_Creasey> |
| Component: | SWT | Assignee: | Steve Northover <steve_northover> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | cocoakevin, daniel_megert, eclipse |
| Version: | 3.2 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 128472, 129887 | ||
|
Description
Tod Creasey
1) Can you show me? 2) You offer to restart when any setting has changed? Sounds wrong. You need to save away the value you care about and test to see whether it has changed. I have released a fix. Can you test it? Note that system changes can happen at any time. For example, sometimes in order to work around a bug, a programe will set a global system value (say a time out), make a call, and then restore the old value. This will trigger a settings change. I thought we had a snippet ... >For example, sometimes in
>order to work around a bug, a programe will set a global system value
That's what I pointed out in the Platform UI bug as well. If that restart dialog "feature" is kept in I want at least be able to disable it or get more fine grained control (which AFAIU isn't possible).
Reopen if not FIXEDFORYOU. This has been fixed for a while, however, we are planning to make a code change that might bring the bug back. I tried to make it happen with Tod but his machine changed and the bug didn't happen. Specifically, SWT.Settings was getting fired when other applications were activated and this no longer seems to be happening. Dani, did the problem ever happen to you? > Dani, did the problem ever happen to you? It did (see bug 129887). But after bug 129887 got fixed I never got it again. Even if more settings get fired again it won't have any effect because Platform UI's settings listener now checks the high contrast flag and only shows the restart dialog when it changed. Dani is right. The only thing we might want to do to expand this is to also check for a change to the system default font but this change won't affect our ability to do that either. Steve, should we revisit this? There was a reason for comment #5, but I don't remember what it was. From comment #6 and comment #7 it looks like we can safely change the code. From memory, we changed and released the code, but only on Vista would there be the possibility of too many SWT.Setings events. Could be wrong about this ... This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |