Bug 129696

Summary: Need to make much of APT provisional API
Product: [Eclipse Project] JDT Reporter: Jess Garms <jgarms>
Component: APTAssignee: Jess Garms <jgarms>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jeffmcaffer, john.arthorne, Kevin_Haaland, Mike_Wilson, philippe_mulet
Version: 3.2Keywords: api
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Jess Garms CLA 2006-02-27 19:17:33 EST
With the exception of Sun's mirror api, the API in APT was intended to be provisional. It was decided that provisional API needs to be in a package with the name "internal" in it. This needs to be done for the API in APT.
Comment 1 Mike Wilson CLA 2006-02-28 12:36:38 EST
If the API really is provisional, it should be marked as such. +1 to doing this.

Given that we are past the API freeze, taking away API could potentially be a bad thing. Do we have any sense who this would impact? Has this been talked about on the mailing lists?
Comment 2 Jess Garms CLA 2006-02-28 13:42:49 EST
I've posted a question to the jdt-apt-dev mailing list asking if anyone is using the current API. I'll add more info to this bug as I get replies.
Comment 3 Jess Garms CLA 2006-03-02 18:14:14 EST
Haven't heard any replies on the mailing list objecting to our privatizing most of the APT APIs. I believe most people are just using annotation processors written for Sun's commandline APT, which won't be affected by this change.
Comment 4 John Arthorne CLA 2006-03-14 15:03:05 EST
You have PMC approval for this (comment #1).  Do you have an ETA on when this will happen?  It really should be in before 3.2 M6.  Any other PMC on the list with comments/reservations?
Comment 5 Jess Garms CLA 2006-03-14 16:11:55 EST
Ah, I didn't realize that first comment indicated PMC approval. I'll go ahead with this change. I hope to have it completed by the end of this week (3/17), as I'll be at EclipseCon the following week.

Comment 6 John Arthorne CLA 2006-03-15 09:51:17 EST
(This is mainly for my information, but this bug also covers deletion of the interface org.eclipse.jdt.apt.core.env.EclipseMirrorObject shortly after M5)
Comment 7 Jess Garms CLA 2006-03-17 14:11:59 EST
Fixed in HEAD: moved classes and interfaces not intended to be API into internal packages.