Bug 12900

Summary: Can't search for files with search
Product: [Eclipse Project] Platform Reporter: Jed Anderson <jed.anderson>
Component: SearchAssignee: Dani Megert <daniel_megert>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1    
Version: 2.0   
Target Milestone: 2.0 M5   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Jed Anderson CLA 2002-04-05 15:37:31 EST 
Build: 20020404

Open the search dialog.
In the patterns field enter plugin.xml
Leave the Search expression field blank
The search button becomes disabled

Enter * as the search expression and you get > 2000 matches per file (I stopped
the search).

Side note, the pattern field should be named something like "files named" (look
at the windows explorer).
Comment 1 Erich Gamma CLA 2002-04-07 18:16:04 EDT 
You have specified to search for "*" inside all plugin.xml files. As a result 
you will get a match for each line in a plugin.xml file. This is the correct 
behaviour.

I agree that the "Patterns" label is misleading. It should be called "File 
types" if there is space "Search in file types:"

(Dani we should get this one into M5)
Comment 2 Jed Anderson CLA 2002-04-08 10:12:58 EDT 
The only time a user will look for * is when they have made a mistake in the
dialog (e.g. they meant to enter "foo*" or "*foo").  

We should disable the "Search" button when the search expression is "*".
Comment 3 Dani Megert CLA 2002-04-08 10:22:12 EDT 
There will be several changes
0) "Text Search" becomes "File Search"
1) better naming of labels
2) moved file name pattern up
3) text pattern is now optional i.e. it will allow you to search for files
4) * for text pattern remains allowed: can be used to count the number of lines
in files.
Comment 4 Dani Megert CLA 2002-04-08 12:48:57 EDT 
Fixed > 20020408