Bug 128033

Summary:

[1.5][search] Not all references are found in standard annotations

Product:

[Eclipse Project] JDT

Reporter:

Frederic Fusier <frederic_fusier>

Component:

Core

Assignee:

Frederic Fusier <frederic_fusier>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.2

Target Milestone:

3.2 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch to fix this issue	none

Description Frederic Fusier

2006-02-15 09:58:30 EST

Even with bug 124469 comment 6 patch applied, search engine still misses some references in standard annotations.

Here are failing tests cases:
1) search for Target references: only reference in Target.class is found although we should get one in SuppressWarnings, Override, etc...
2) search for ElementType.TYPE reference: no occurrence is foud although there's one in SuppressWarning

Comment 1 Frederic Fusier

2006-02-15 10:04:29 EST

Created attachment 34774 [details]
Patch to fix this issue

Problem comes from BinaryIndexer.

Test case 1) is due to the fact that method addBinaryStandardAnnotations was missing multiple annotations references in class file. Only last one was indexed.

Test case 2) comes from the fact that method addBinaryTargetStandardAnnotation returned before indexing ElementType fields references...

Comment 2 Frederic Fusier

2006-02-15 11:27:35 EST

Released in HEAD.

Test cases will be added later...

Comment 3 David Audel

2006-02-15 12:43:34 EST

Verified for 3.2 M5 using build I20060215-0800 + JDT/Core HEAD