Description
Chris Brealey
2006-02-08 21:47:00 EST
Andy, thanks for running with this. I'll post more details to this RFE. Andy, a few comments about this work. 1. The new preference page should live in org.eclipse.jst.ws.axis.consumption.ui. A couple of the properties are only really applicable to service creation, but for now, I don't want to incur the cost of a second page simply to separate a couple creation-only preferences from the rest of the pack. 2. The actual preferences themselves must be managed in org.eclipse.jst.ws.axis.consumption.core (ie. NOT in a UI plugin). 3. Not all the properties in the opening remarks may be useful, specifically the "verbose", "debug" and "quiet" options. We do not route the output from the Axis emitters to the Eclipse console view, so there isn't much direct benefit to the user of including these options on the page. Let's skip them for now. 4. Rather than write a preference page from scratch, I recommend you copy and tweak one of our existing pages: "ResourceManagementPreferencePage". 5. You will find that ResourceManagementPreferencePage manages its preference via an interface named "ResourceContext" returned by the "getResourceContext" method on class "WebServicePlugin". This will quickly lead you to another class named "PersistentResourceContext". Notice that all this is core stuff, meaning the only code that should be the axis.consumption.ui plugin should be the preference page. You should mimic / copy this "ResourceContext" pattern in the implementation of this RFE. 6. You will need to write some logic in WSDL2JavaCommand and Java2WSDLCommand to get properties from your equivalent to "ResourceContext" and set them on the Axis emitter object. 7. Because we have already invented a JRE property for the "timeout" option, you'll have to treat that one a bit specially compared to the other totally new new options. In particular, if the JRE property is set, we must give priority to its value over the preference value in WSDL2JavaCommand. Secondly, if the JRE property is set and the user opens the preference page, we should set the timeout field to the value of the JRE property, disable the field, and explain to the user why the field is disabled (because they're using the JRE property). That's all for now. Created attachment 36710 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.core
This patch only contains 3 checkbox preferences, and wsdl2java and java2wsdl have not been updated yet.
Created attachment 36711 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
This patch only contains 3 checkbox preferences:
-a All
-h helpGen
-W wrapArrays
Created attachment 36824 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.core
all options included (except for -debug, -verbose and -silent)
logic in wsdl2java and java2wsdl has been added
special process is added for special case: time out
so it's probably done for this plugin
Created attachment 36825 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
functionality is done. left thing to do is to make the preference page more beautiful or prefessinal
Created attachment 36985 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.core
final version
Created attachment 36986 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
final version
Created attachment 37001 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
final version
Created attachment 37003 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
A little bit of change
Created attachment 37097 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
add around for seconds = Math.ceil(millseconds/1000.0) Now 100, 2200 millseconds will be displayed with 1 second and 3 seconds.
Created attachment 37262 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.core
Created attachment 37263 [details]
patch fix to org.eclipse.jst.ws.axis.consumption.ui
Kathy, I have updated what you mentioned this afternoon ( copyright head, comment of head, timeout=-3..., load default for timeout with property...). execpt the log file information statement for scope option because the statment need different information for each type of scope. Patches reviewed, committed and released to WTP 1.5 as v200603300448. Verified in RC2. Closed |