Bug 123893

Description Dirk Baeumer 2006-01-14 17:58:22 EST

A class cast exception happens in getAllMemberValuePairs due to the fact that the names array is an array of Strings and the comparator cast those elements to char[].

Additionally the insertion loop at the end can produce an AIOBE since the returned value from binarySearch is the negative insertion index and can therefore be less than -1. 

The correct code of the method should be as follows:

		// handle case of more methods than declared members
		char[][] names = new char[declaredLength][];
		for (int i = 0; i < declaredLength; i++)
			names[i] = pairs[i].getName().toCharArray();
		Comparator comparator = new Comparator() {
			public int compare(Object arg0, Object arg1) {
				return CharOperation.compareWith((char[]) arg0, (char[]) arg1);
			}
		};
		Arrays.sort(names, comparator);
		IResolvedMemberValuePair[] allPairs = new  IResolvedMemberValuePair[methodLength];
		for (int i = 0; i < methodLength; i++) {
			int index = Arrays.binarySearch(names, methods[i].selector, comparator);
			allPairs[i] = index < 0 
				? new ResolvedDefaultValuePair(methods[i], this.bindingResolver) 
				: pairs[index];
		}
		return allPairs;

The are some additionally comments here:

- the algorithm sorts the names not the pairs but the index is used at the end 
  to access the pairs not the names. So this only works if all names are found
  since the picked pair might not match the name for which the binary search
  is used.