Bug 121395

Summary: invalid aspectj path throws filenotfoundexception
Product: [Tools] AspectJ Reporter: Frank Stolle <frank>
Component: CompilerAssignee: Andrew Clement <aclement>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: DEVELOPMENT   
Target Milestone: 1.5.1   
Hardware: Macintosh   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Frank Stolle CLA 2005-12-19 06:28:40 EST
An invalid aspectj path (missing jar file) throws an filenotfoundexception:

java.io.FileNotFoundException
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(FileInputStream.java:106)
at org.aspectj.weaver.bcel.BcelWeaver.addAspectsFromJarFile(BcelWeaver.java:202)
at org.aspectj.weaver.bcel.BcelWeaver.addLibraryJarFile(BcelWeaver.java:192)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.initBcelWorld(AjBuildManager.java:623)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:209)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:185)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild(AjBuildManager.java:163)
at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:117)
at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:191)

FileNotFoundException thrown: /Users/frankstolle/Documents/workspace/lib_aspects/deploy/lib_aspects.jar (No such file or directory)



should generate an problem entry in the problems-list.
Comment 1 Sian January CLA 2005-12-20 06:29:21 EST
This seems to be ok on the command line - you get a message saying "Bad aspectpath ...".  In the AJDT environment we'd like the compiler to return a compile problem rather than throw an exception.
Comment 2 Andrew Clement CLA 2006-01-27 07:28:50 EST
command line verification is done in BuildArgParser.  AJDT takes a different route into the weaver. I've changed AjBuildManager to report a problem for entries on the aspectpath that don't exist.

I also upgraded the AJDT-like test harness we had to allow setting of an aspectpath for a project.

fix checked in, waiting on build.
Comment 3 Andrew Clement CLA 2006-01-31 09:19:40 EST
fix available.