Bug 120764

Summary:	ComponentEditPolicy doesn't preserve "show delete dialog" parameter
Product:	[Modeling] GMF-Runtime	Reporter:	Min Idzelis <min123>
Component:	General	Assignee:	Cherie Revells <crevells>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1
Version:	1.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Min Idzelis

2005-12-13 17:59:59 EST

When deleting a node via keyboard, a createDeleteSemanticCommand object is generated. If the deleteRequest is a GroupRequestViaKeyboard, it contains a "showInformationDialog" field. This field should be passed to the DestroyElementRequest, but it's hardcoded to always be false. 

See Line 148 in ComponentEditPolicy

Comment 1 Steven R. Shaw

2005-12-16 10:49:54 EST

should be an easy one to fix...

Comment 2 Cherie Revells

2006-01-10 14:44:18 EST

Here is some of what is left:
Remnants of the semantic service, The method setXORMode(boolean) from the type GC is deprecated DiagramPrinter, The method loadResource(String) from the type MEditingDomain is deprecated.  Something about an EditPolicyIterator, ListenerList, deprecations in RenderedImage.

Comment 3 Cherie Revells

2006-01-10 15:01:51 EST

Ignore the previous comment, it was added to the wrong bugzilla.  :-(

Comment 4 Cherie Revells

2006-05-25 16:26:04 EDT

Purpose: 
Bugzilla#120764 ComponentEditPolicy doesn't preserve "show delete dialog" parameter
- Pass on the "show delete dialog" parameter Pass on the to the DestroyElementRequest.to the DestroyElementRequest.  Note:  This does not affect canonical delete behavior because there is a check if the parent is canonical prior to showing the dialog in SemanticEditPolicy.getSemanticCommand().

Activities: 
Bugzilla#120764 gmf_head cmahoney 060525 ComponentEditPolicy doesn't preserve "show delete dialog" parameter

Code Reviewed by:
Steve

Comment 5 Eclipse Webmaster

2010-07-19 12:30:28 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug