Bug 115704

Description Dusko 2005-11-09 16:28:19 EST

Methods ResourceUtil.load(...) and MSLEditingDomain.loadResource(...) unload 
resources that threw an exception during their load. The MSL resources throw 
exception at the end of the load if there were any errors during the load, 
unless run in the compatibility mode.

So, the logic goes like this:
1) ResourceUtil.load(...) and MSLEditingDomain.loadResource(...) initiates 
load of the MSL resource.
2) The resource loader encounters an error. In one very common use case 
(missing schema) that error is encountered at the very beginning. The loader 
puts the error in the error list and continues.
3) The resource is eventually completely loaded.
4) The code checks if there are any errors in the error list. Since there is 
one, an exception is thrown.
5) The load was not in the compatibility mode. The resource gets unloaded.

In my example, I had a customer model with an unrecognized schema. Initially 
we try to open it using ResourceUtil.load(...) without using the compatibility 
mode. In my environment it takes 20 seconds to load it and then almost another 
20 seconds to unload. Total 40 seconds for the load(…) call to come back and 
the resource is not loaded at the end.

Obviously this could be optimized at least for the MSL resources. The 
ResourceUtil.load(...) and MSLEditingDomain.loadResource(...) could pass down 
to resource implementation some flag to indicate that it should throw the 
exception right away and not at the end. Of course, the flag would not apply 
in the compatibility mode case since exceptions are not thrown in that case. 
The performance improvement in my case would be going down from 40 seconds to 
around 5 seconds.