Summary: | no aspectOf() on parameterized perobject aspects | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Wes Isberg <wes> |
Component: | Compiler | Assignee: | Andrew Clement <aclement> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P2 | ||
Version: | 1.5.0M4 | ||
Target Milestone: | 1.5.0RC1 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Wes Isberg
2005-11-06 08:09:40 EST
I think it is generating an aspectOf() - the problem is the type checking during compilation isn't able to *see* the aspectOf(), it is probably asking the wrong object (maybe the generic type, when the aspectOf is on the parameterized form). oops - spoke too soon, aspectOf() that is generated isnt quite right... What a can of worms!! The problem was that we werent correctly looking up the perclause of the super aspect if it was a parameterized type - I added the logic for this. Without this we default to persingleton(). This then revealed some problems with @AJ processing of per clauses - I am concerned that we test whether a class is 'AnnotationStyleAspect' by checking for the existence of the 'Aspect' annotation - because we have a visitor that runs over any code style aspect and adds those annotations. I haven't fixed this problem but merely fixed up the handling of perclauses to be correct (at least correct enough for all our existing testcases). fix checked in. fix available. |