Bugzilla – Full Text Bug Listing
| Summary: | Scanner#getNextToken() behavior doesn't seems consistent if there is an unicode inside a string. | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | David Audel <david_audel> |
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | philippe_mulet |
| Version: | 3.2 | ||
| Target Milestone: | 3.2 M3 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
I found a visible bug. With "a\u000Da" the end of the error is just before 'D'
and if the string start with an unicode ("\u004Ca\u000Da") the end of the error
is at '"'.
In fact the problem is worth than that.
public class X {
public static void main(String[] args) {
System.out.println("\u004Ca\u000D");
}
}
Return a string literal not properly closed by a double-quote where I would
expect an error about an illegal character in a string literal.
In fact we convert the INVALID_CHAR_IN_STRING in an unterminated string error. I would rather like to locate the invalid character in the string literal. We could then get rid of the lookahead and report the error only against the invalid character. When we hightlight the whole string literal, we don't help the user to locate the error. Philippe, any thought? I do have a fix for the problem reported in comment 1. Fixed and released in HEAD. Regression tests added in org.eclipse.jdt.core.tests.compiler.regression.ScannerTest.test042/43/44. Fixed in both PublicScanner and internal scanner. See bug 112246 for error reporting inside string literals. Verified for 3.2 M3 using build I20051102-1600. |
build I20050928-1300 + jdtcore head In the method Scanner#getNextToken() at line 1212, the lookahead loop haven't the same behavior with "\u004Ca\n" as with "\u004Ca\n\u0022 (\u004C=Z \u0022=") and that's seems strange. In both case an InvalidInputException is thrown but currentPosition is not the same and i don't find why. The algorithm looks strange but i didn't find a visible bug. Another question is why this code is reach only if the first character is an unicode ? --------------------------------------------------------------- if (isUnicode) { int start = this.currentPosition; for (int lookAhead = 0; lookAhead < 50; lookAhead++) { if (this.currentPosition >= this.eofPosition) { this.currentPosition = start; break; } if (((this.currentCharacter = this.source[this.currentPosition++]) == '\\') && (this.source[this.currentPosition] == 'u')) { isUnicode = true; getNextUnicodeChar(); } else { isUnicode = false; } if (!isUnicode && this.currentCharacter == '\n') { this.currentPosition--; // set current position on new line character break; } if (this.currentCharacter == '\"') { throw new InvalidInputException(INVALID_CHAR_IN_STRING); } } } else { this.currentPosition--; // set current position on new line character } throw new InvalidInputException(INVALID_CHAR_IN_STRING);