Bug 111935

Summary: API: Gate infrastructure consistency issues
Product: [Modeling] GMF-Runtime Reporter: Steven R. Shaw <steveshaw>
Component: GeneralAssignee: Cherie Revells <crevells>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P1 Keywords: api
Version: 1.0   
Target Milestone: 1.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
API Changes none

Description Steven R. Shaw CLA 2005-10-07 11:55:42 EDT 
GateEditPart
1. In the header you mention this should inherit from GatedShapeEditPart 
eventually.  Is this still true?  The class method signatures seem to support 
this.  What would be the ramfications of making this change.

2. The method "createMainFigure" is never called from anywhere.  Yet the 
getMainFigure is called  using the "getElementPane"  method to return if the 
top level figure is a GatedPaneFigure.  Are these 2 method necessary at all?
Comment 1 Steven R. Shaw CLA 2005-10-07 11:56:39 EDT 
#1.  GateEditPart and GatedShapeEditPart could be collapsed into one.    In 
the beginning we wanted to keep two separate editparts but gates themselves 
could contain gates.

#2. Yes we can remove some of these functions... I'm not sure who added 
them.   I believe it was for ease of use.  We probably evolved out of them.

Also,

#3. FixedDistanceGatedPane* should be removed.  

#4. One downside to the current implementation of gates is that their bounds 
are not taken into account  in viewports.  We should move to a design where we 
have some larger figure as a parent and gates within.  We would therefore not 
need to override the paint and clipping region.  

#5. remove GatedFigure.addGate() .. use the GEF default .add() etc.
Comment 2 Steven R. Shaw CLA 2005-10-07 11:57:27 EDT 
Also classes should be renamed to something more generic: Border, Bordered etc.
Comment 3 Steven R. Shaw CLA 2005-10-19 16:53:57 EDT 
Gate naming issue is captured by bugzilla 113157
Comment 4 Cherie Revells CLA 2005-10-28 12:29:33 EDT 
Consider making BorderItemContainerFigure private.
Comment 5 Cherie Revells CLA 2006-01-04 14:38:52 EST 
Created attachment 32478 [details]
API Changes

Document describing the API changes.
Comment 6 Cherie Revells CLA 2006-01-04 14:39:45 EST 
See attached doc for API changes.
Comment 7 Richard Gronback CLA 2008-08-13 13:06:23 EDT 
[target cleanup] 1.0 M4 was the original target milestone for this bug
Comment 8 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug