Bug 109806

Description Nick Edgar 2005-09-16 20:00:20 EDT

3.1

I have an ShowViewAction class that tracks whether the view it shows is already
showing (it's a toggle action).
It has a listener like:

	private IPartListener partListener = new IPartListener() {
		public void partOpened(IWorkbenchPart part) {
			if (part instanceof IViewPart) {
				updateSelection();
			}
		}
		public void partDeactivated(IWorkbenchPart part) {
		}
		public void partClosed(IWorkbenchPart part) {
			if (part instanceof IViewPart) {
				updateSelection();
			}
		}
		public void partBroughtToTop(IWorkbenchPart part) {
		}
		public void partActivated(IWorkbenchPart part) {
		}
	};

where updateSelection() is:

	private void updateSelection() {
		boolean viewFound = false;
		IWorkbenchPage page = window.getActivePage();
		if (page != null) {
			IViewReference ref = page.findViewReference(desc.getId());
			if (ref != null) {
				viewFound = true;
			}
		}
		setChecked(viewFound);
	}

This is not working correctly because when partOpened is fired, the view is not
found by findViewReference.

It should be the case that by the time partOpened is sent, the part can be found
in the list (the notification is past tense).

Should investigate whether this is a regression from previous releases.