Summary: | [javadoc][dom] ASTNode not including javadoc | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Kapil Katyal <kkatyal> | ||||||
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | major | ||||||||
Priority: | P3 | CC: | markus.kell.r, martinae, Olivier_Thomann, philippe_mulet, ttv727 | ||||||
Version: | 3.1 | ||||||||
Target Milestone: | 3.1.2 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Kapil Katyal
2005-09-01 15:22:35 EDT
Reproduced. I am investigating. Simple test case: /** * */ public abstract class X { /** * */ public abstract Zork getFoo(); /** */ public abstract void setFoo(Zork dept); } If bindings are requested, the two methods don't have javadoc. If no bindings are requested, they do have javadoc. I am investigating. Javadoc should always be there. The binding might be null when the signature of the method cannot be resolved, but there is no reason why the javadoc is not there. *** Bug 108639 has been marked as a duplicate of this bug. *** Olivier, this is a side effect of fix for bug 84049. We have to talk with Martin to find an agreement on ASTConverter behavior in this case... The javadoc should always be set. It is a syntactical element. The tree should be consistent when bindings are requested or not. Martin, If I put back Javadoc in this case this would break fix for bug 84049. I'd like to have your feedback about it before... Fix is simple and safe: just remove bug 84049 fix... I think it's a good candidate for 3.1.1 Created attachment 27034 [details] Patch to fix this issue Just put back code before bug 84049 fix. This does not have any impact on JDT/UI tests... Created attachment 27035 [details] Test case added to ASTConverterJavadocTest Note that test for bug 84049 was not disabled but I've added assertions and commented them instead... This allow to verify that even for this test case, javadoc comment is well put back on method declaration. Patches released in HEAD. Verified in I20050920-0010 for 3.2M2 verified this is fixed +1 for 3.1.2 (philippe) Reopen to put it in R3_1_maintenance stream Fix released in R3_1_maintenance stream Verified for 3.1.2 using build M20060109-1200. Verified for 3.1.2 using build M20060109-1200 (maxime) |