Bug 108558

Summary: [code style] [general issue] arguments of generated methods to be final
Product: [Eclipse Project] JDT Reporter: Timo Nentwig <eclipse>
Component: UIAssignee: Benno Baumgartner <benno.baumgartner>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P3 CC: bmiller, eclipse, grk, jimisola, markus.kell.r, nikolaymetchev, tobias_widmer
Version: 3.2   
Target Milestone: 3.2 M6   
Hardware: PC   
OS: All   
Whiteboard:

Description Timo Nentwig CLA 2005-09-01 05:06:49 EDT 
I miss the ability to have method arguments to be final all over eclipse:

Refactor > Extract Method
Refactor > Change Method Signature
Source > Override/Implement Methods
Source > Generate Getter/Setter
Quick Fix (create method 'foo()')
...

Despite only few people seem to do it IMHO making method argument final makes 
sense and prevents bugs.
Comment 1 Dirk Baeumer CLA 2005-09-05 13:03:06 EDT 
The way to go here is to have a global code style preference that forces final
parameters.
Comment 2 Martin Aeschlimann CLA 2006-01-04 09:14:19 EST 
*** Bug 122271 has been marked as a duplicate of this bug. ***
Comment 3 Martin Aeschlimann CLA 2006-01-24 04:53:42 EST 
would be a useful new code style option
Comment 4 Benno Baumgartner CLA 2006-01-24 05:01:02 EST 
Plus a clean up? Quick assist? Make final if possible...
Comment 5 Brian Miller CLA 2006-01-24 09:48:38 EST 
"Make final if possible" quikfix would be sweet, especially if it had it's own warning/error/ignore configurability.  IntelliJ has had this for years.  Please consider it.
Comment 6 Benno Baumgartner CLA 2006-02-22 03:51:00 EST 
See also Bug 123946
Comment 7 Markus Keller CLA 2006-02-22 05:38:40 EST 
This is a dup of bug 40078.
Comment 8 Benno Baumgartner CLA 2006-03-24 08:32:30 EST 

*** This bug has been marked as a duplicate of 40078 ***
Comment 9 Benno Baumgartner CLA 2006-03-24 08:33:35 EST 
Made a quick assist and a clean up. The option has to wait post 3.2