Bug 10754

Summary:	Compare actions should target source window
Product:	[Eclipse Project] Platform	Reporter:	Simon Arsenault <simon_arsenault>
Component:	Team	Assignee:	Jean-Michel Lemieux <jean-michel_lemieux>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	veronika_irvine
Version:	2.0
Target Milestone:	2.1 RC2
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Simon Arsenault

2002-03-05 08:50:50 EST

In build 2002-02-14, I selected a project (from the packages view) and then I 
invoked the action Compare With > Repository Contents. Since it was a slow 
operation (an no busy indicator came up right away), I clicked on another 
workbench window.

When the compare action was finally done, it opened the compare editor. 
However, it opened it in the last window I had given focus to instead of the 
original window I invoked the Compare action from.

The action should have enough context to know which window it was invoked from 
instead of calling IWorkbench.getActiveWorkbenchWindow.

Comment 1 Andre Weinand

2003-02-10 09:18:54 EST

*** Bug 17731 has been marked as a duplicate of this bug. ***

Comment 2 Andre Weinand

2003-02-12 10:19:08 EST

fixed for "Compare with Each Other" for I20030213

The CompareAction now opens the ComparEditorInput into a CompareEditor by calling
      CompareUI.openCompareEditorOnPage(fInput, fWorkbenchPage)
instead of
      CompareUI.openCompareEditor(fInput)

The other VCM Compare actions should probably do the same.

Comment 3 Andre Weinand

2003-02-14 02:48:15 EST

Moving to VCM

Comment 4 Jean-Michel Lemieux

2003-03-02 20:41:34 EST

Fixed and released to HEAD. Although I have to admit that I wasn't able to
reproduce. The progress dialog appears too quickly and I'm not quick enough to
change to another workbench window :(

So for those with quick mouse fingers, I've updated all VCM references to
CompareUI.openCompareEditor() to CompareUI.openCompareEditorOnPage().