Bug 105041

Summary:

[IDE] Double-clicking on a closed project should open it

Product:

[Eclipse Project] Platform

Reporter:

Oliver Klee <eclipse-01>

Component:

IDE

Assignee:

Boris Bokowski <bokowski>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

b.muskalla, caniszczyk, pombredanne, wassim.melhem

Version:

3.0.2

Keywords:

contributed

Target Milestone:

3.3 M4

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

167554

Attachments:

Description	Flags
open_project_dblclick.diff	none
updated patch	none

Description Oliver Klee

2005-07-25 12:11:58 EDT

Double-clicking on a closed project should open it.

Steps to reproduce:
1. Click on a closed project.

Expected results:
The project gets opened.

Actual results:
Nada.

Comment 1 Annonygmouse

2005-08-26 02:49:41 EDT

I also agree that a double click on a closed project would be great
from the usability's point of view.

I have voted for this bug.

Comment 2 Michael Van Meekeren

2005-08-29 15:16:03 EDT

anyone interested in providing a patch for this?

Comment 3 Wassim Melhem

2006-07-20 18:32:00 EDT

you're in luck.  I also want this feature and it is now assigned to me :)

Comment 4 Benjamin Muskalla

2006-07-20 18:52:28 EDT

Do you want to do this? I would like to write a patch for it this night :)

Comment 5 Wassim Melhem

2006-07-20 18:56:59 EDT

I am not going to fight over it.  go ahead :)

Comment 6 Benjamin Muskalla

2006-07-20 21:45:34 EDT

Created attachment 46616 [details]
open_project_dblclick.diff

Here is a way to get this fixed.

But why need I set the selection by myself here? (without it, the action is canceled)

Comment 7 Eric Moffatt

2006-08-17 11:11:29 EDT

I'm +1 for this...

Comment 8 Benjamin Muskalla

2006-12-08 17:11:15 EST

Any chance to get this into next milestone?

Comment 9 Philippe Ombredanne

2006-12-09 00:15:04 EST

+1 too

Comment 10 Wassim Melhem

2006-12-09 00:18:49 EST

You would need to get a platform/ui committer to review it.

Comment 11 Boris Bokowski

2006-12-09 10:13:59 EST

Created attachment 55358 [details]
updated patch

- added contribution comment
- checked that the selection has only one element
- IResource.getType() does not return a bit mask
- before running the action, should check that it is enabled

Comment 12 Boris Bokowski

2006-12-09 10:17:33 EST

Released >20061209.

Note that this will only work in the resource navigator view.  Could you look at the package explorer and the project explorer too, to make the behaviour consistent?  Note that there are plans to make the the project explorer (based on the common navigator) the default navigator view in the resource perspective.

Comment 13 Benjamin Muskalla

2007-01-19 10:43:18 EST

Works in Package Explorer of JDT (see bug 167554) but not in Project Explorer. Will care for that and file a new bug for that with attached patch.