Summary: | [Dialogs] Add fitering mechanism to FilteredResourcesSelectionDialog | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Andrew Premdas <a.premdas> | ||||||
Component: | IDE | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||||
Status: | NEW --- | QA Contact: | |||||||
Severity: | enhancement | ||||||||
Priority: | P3 | CC: | cbridgha, dirk_baeumer, mdelder, Szymon.Brandys | ||||||
Version: | 3.1 | ||||||||
Target Milestone: | --- | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Andrew Premdas
2005-06-16 12:59:39 EDT
Created attachment 23343 [details]
Shows problem with OpenResource
This shows how two versions of a critical file are selected and how the build
one is the default
Created attachment 23344 [details]
2nd example of problem
Showing the inclusion of .svn files and .class files.
Its been 2 months since I raised this bug and I haven't had any response. As this is by far the most serious bug I've ever found with eclipse I would like to at least try and get a response for it. We are able to hide java class files that are part of the output folders for java projects, so this would seem possible, adding Dirk as a cc. Michael, Andrew isn't only talking about class files. The problem are also resource files (for example .properties, ...) which are copied by the builder to the output folder (in this case the build folder). The way how JDT ensure that these are filter is that the builder marks all files copied into the output folder as derived and the open resource dialog by default filters derived resources. So I opt to pass this PR to Web Tools. The have to make sure that the files in the output folder are marked as derived so that we know they aren't important to the users. First of all thanks for responding :) I am talking about all sorts of files here, including .properties .xml and possiblly just about any other extension except perhaps .java. This is why the ability to tell Open Resource not too look in certain places would be an ideal solution. You also have to be aware that these files may get into these locations via methods outside the IDE (particularly Ant build scripts). So maybe marking the files with the Builder isn't the way to go. Finally a good failsave would be to modify the UI of the open resource dialog so that if a file has multiple selections you have to specifically select one of the options (there is no default selections). So in my first screenshot you could not select action-servlet.xml by double clicking on it in the top section. Instead you would have to go to the bottom section and choose one of the two entries) Adding Michael Elder, is there a WTP person who ownes the builder and can investigate marking of resources as derived where appropriate? If this is in specific reference to the WTP builder, I would refer you to Chuck Bridgham. I happen to know that there are plans to change how that builder works, but it should be a simple enough change at least for now to mark all resources that are put in a WTP output structure as derived (if they are not already). Andrew -- Can you confirm if you are seeing this problem under WTP? The problem happens with and without WTP. Any fix that is dependent on having WTP installed based wouldn't be sufficient in my opinion, because this problem really bites even when your not using WTP. Hope this helps :) Andrew, Could you check it once again in Eclipse 3.3 ? 1. Now to filter build file we use derived flag. As i understand it's insufficient and you expect to add filter mechanism similar to this from package explorer. 2. All svn file should be marked as team private resources by svn plug-in similar to cvs solution. All svn res marked as IResource.TEAM_PRIVATE should be hidden. In conclusion, we will provide filtering feature for FilteredResourcesSelectionDialog. Krzysztof left the team some time ago. I'm removing the target milestone. I will reassign it to the right person, when I find out who it is. Reassigning to Susan. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |