Bug 100393

Summary:	Defaults for compiler errors/warnings settings
Product:	[Eclipse Project] JDT	Reporter:	Marcelo Paternostro <marcelop>
Component:	Core	Assignee:	Frederic Fusier <frederic_fusier>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	dirk_baeumer, erich_gamma, gunnar
Version:	3.1
Target Milestone:	3.1 RC3
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Marcelo Paternostro

2005-06-16 09:27:08 EDT

Is it possible to set the default value of the following settings to "ignore"
(as it was in RC1)?

"Local variable declaration hides another field or variable"
"Field declaration hides another field or variable"

Comment 1 Philipe Mulet

2005-06-16 09:35:50 EDT

Usecase is for some code generation tools which are using these patterns a lot
(knowing what they do).

+1 for RC3.

Erich - can you cast your vote ?

Comment 2 Philipe Mulet

2005-06-16 09:36:34 EDT

Motivation is that we changed the setting default late in the game, and some
clients cannot adopt it. Thus request to revert.

Comment 3 Frederic Fusier

2005-06-16 09:59:24 EDT

Partial rollback from bug 76530 is trivial:
Index: CompilerOptions.java
===================================================================
RCS file:
/home/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java,v
retrieving revision 1.139
diff -u -r1.139 CompilerOptions.java
--- CompilerOptions.java	9 Jun 2005 00:36:29 -0000	1.139
+++ CompilerOptions.java	16 Jun 2005 13:59:24 -0000
@@ -208,8 +208,6 @@
 		| UnhandledWarningToken
 		| UnusedLocalVariable
 		| UnusedPrivateMember
-		| FieldHiding
-		| LocalVariableHiding
 		/*| NullReference*/;
 
 	// Debug attributes

Comment 4 Philipe Mulet

2005-06-16 10:42:49 EDT

I am a bit concerned about our test suites.
Dirk, comments ?

Comment 5 Dirk Baeumer

2005-06-16 11:02:26 EDT

I will run them here with the patch.

Comment 6 Dirk Baeumer

2005-06-16 11:33:56 EDT

I ran the tests that failed the last time and they still pass. We adpated the
test to set their expected compiler options to make the independent of changes.
I will run the refactoring tests as well to be 100% sure. But this will last
another hour

Comment 7 Erich Gamma

2005-06-16 14:24:32 EDT

Given that this was a last minute change +1  (I still think the new defaults are
goodness for our developers)

Comment 8 Olivier Thomann

2005-06-16 15:21:40 EDT

Fixed and released in HEAD.

Comment 9 Olivier Thomann

2005-06-16 15:26:17 EDT

Verified using build N20050616-0010 + JDT Core HEAD.