Attachment 78440 Details for Bug 197855 – Removes canWrite checks

[patch] Removes canWrite checks

patch.txt (text/plain), 2.56 KB, created by Kevin Doyle

on 2007-09-14 11:31:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2007-09-14 11:31:41 EDT

Size: 2.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.files.ui
>Index: src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java,v
>retrieving revision 1.43
>diff -u -r1.43 SystemViewRemoteFileAdapter.java
>--- src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java	11 Sep 2007 16:30:45 -0000	1.43
>+++ src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java	14 Sep 2007 15:24:09 -0000
>@@ -29,6 +29,7 @@
>  * David McKnight   (IBM)        - [197784] Need to check if last separator is at 0
>  * Kevin Doyle  (IBM)            - [198576] Renaming a folder directly under a Filter doesn't update children
>  * David McKnight   (IBM)        - [199568] Removing synchronized from internalGetChildren
>+ * Kevin Doyle (IBM) 			 - [197855] Can't Delete/Rename/Move a Read-Only File
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.files.ui.view;
>@@ -311,7 +312,7 @@
> 
> 		if ((elementType == 1 || (isArchive && supportsArchiveManagement)))
> 		{
>-			if (!foldersOnly && canRead && canWrite)
>+			if (!foldersOnly && canRead)
> 			{
> 				if (addNewFile == null)
> 				{
>@@ -321,7 +322,7 @@
> 			}
> 			if (!filesOnly)
> 			{
>-			    if (canRead && canWrite)
>+			    if (canRead)
> 			    {
> 			        if (addNewFolder == null)
> 			        {
>@@ -420,12 +421,12 @@
> 
> 		if (elementType == 1 || (isArchive && supportsArchiveManagement))
> 		{
>-		    if (canRead && canWrite)
>+		    if (canRead)
> 		    {
> 		        menu.add(menuGroup, pasteClipboardAction);
> 		    }
> 		}
>-		if (!firstFile.isRoot() && canRead && canWrite)
>+		if (!firstFile.isRoot() && canRead)
> 		{
> 			menu.add(menuGroup, moveAction);
> 		}
>@@ -2302,7 +2303,7 @@
> 	{
> 		IRemoteFile file = (IRemoteFile) element;
> 		//System.out.println("INSIDE CANDELETE FOR ADAPTER: RETURNING " + !file.isRoot());
>-		return !file.isRoot() && file.canRead() && file.canWrite();
>+		return !file.isRoot() && file.canRead();
> 	}
> 
> 	
>@@ -2425,7 +2426,7 @@
> 	public boolean canRename(Object element)
> 	{
> 		IRemoteFile file = (IRemoteFile) element;
>-		return !file.isRoot() && file.canRead() && file.canWrite();
>+		return !file.isRoot() && file.canRead();
> 	}
> 
> 	private void moveTempResource(IResource localResource, IPath newLocalPath, IRemoteFileSubSystem ss, String newRemotePath)

Flags:

mober.at+eclipse: iplog+

Actions: View | Diff

Attachments on bug 197855: 78440