Attachment 78307 Details for Bug 199773 – patch with simplified logic

[patch] patch with simplified logic

patch.txt (text/plain), 1.76 KB, created by Javier Montalvo Orús

on 2007-09-13 09:45:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Javier Montalvo Orús

Created: 2007-09-13 09:45:41 EDT

Size: 1.76 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.subsystems.files.core
>Index: src/org/eclipse/rse/subsystems/files/core/servicesubsystem/FileServiceSubSystem.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.subsystems.files.core/src/org/eclipse/rse/subsystems/files/core/servicesubsystem/FileServiceSubSystem.java,v
>retrieving revision 1.41
>diff -u -r1.41 FileServiceSubSystem.java
>--- src/org/eclipse/rse/subsystems/files/core/servicesubsystem/FileServiceSubSystem.java	18 May 2007 00:53:52 -0000	1.41
>+++ src/org/eclipse/rse/subsystems/files/core/servicesubsystem/FileServiceSubSystem.java	13 Sep 2007 13:44:12 -0000
>@@ -18,6 +18,7 @@
>  * Martin Oberhuber (Wind River) - [177523] Unify singleton getter methods
>  * Martin Oberhuber (Wind River) - [186128] Move IProgressMonitor last in all API
>  * Martin Oberhuber (Wind River) - [183824] Forward SystemMessageException from IRemoteFileSubsystem
>+ * Javier Montalvo Orus (Symbian) - [199773] Default file transfer mode is ignored for some file types
>  *******************************************************************************/
> 
> package org.eclipse.rse.subsystems.files.core.servicesubsystem;
>@@ -452,10 +453,8 @@
> 	
> 	protected boolean isBinary(String localEncoding, String hostEncoding, String remotePath)
> 	{
>-		boolean isText = !hostEncoding.equals(localEncoding) && 
>-		SystemFileTransferModeRegistry.getInstance().isText(remotePath) && 
>-		!SystemEncodingUtil.getInstance().isXML(remotePath) ;
>-		return !isText;
>+		return SystemFileTransferModeRegistry.getInstance().isBinary(remotePath) ||
>+		       SystemEncodingUtil.getInstance().isXML(remotePath);	
> 	}
> 	
> 	protected boolean isBinary(IRemoteFile source)

Flags:

mober.at+eclipse: iplog-

Actions: View | Diff

Attachments on bug 199773: 78177 | 78297 | 78307