Attachment #78286 for bug #203061




}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation
public void test1161() {
	this.runConformTest(
		new String[] {
			"X.java",
			"class Y<T extends Y<T>> {}\n" + 

}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation
public void test1162() {
	this.runConformTest(
		new String[] {
			"X.java",
			"class Y<T extends Y<T>> {}\n" + 

		},
		"");
}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
public void test1163() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public final class X<T> {\n" + 
			"	private final Object mObj;\n" + 
			"	private final Object mDependent = new Object() {\n" + 
			"		{\n" + 
			"			Object o1 = mObj;\n" + 
			"		}\n" + 
			"		Object o2 = mObj;\n" + 
			"		void foo() {\n" + 
			"			Object o3 = mObj;\n" + 
			"		}\n" + 
			"	};\n" + 
			"	public X() {\n" + 
			"		mObj = \"\";\n" + 
			"	}\n" + 
			"}\n", // =================
		},
		"----------\n" + 
		"1. WARNING in X.java (at line 3)\n" + 
		"	private final Object mDependent = new Object() {\n" + 
		"	                     ^^^^^^^^^^\n" + 
		"The field X<T>.mDependent is never read locally\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"4. WARNING in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	       ^^\n" + 
		"The field new Object(){}.o2 is never read locally\n" + 
		"----------\n" + 
		"5. WARNING in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"6. ERROR in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"7. WARNING in X.java (at line 8)\n" + 
		"	void foo() {\n" + 
		"	     ^^^^^\n" + 
		"The method foo() from the type new Object(){} is never used locally\n" + 
		"----------\n" + 
		"8. WARNING in X.java (at line 9)\n" + 
		"	Object o3 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n");
}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
public void test1164() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public final class X<T> {\n" + 
			"	private final Object mObj;\n" + 
			"	private final Object mDependent = new Object() {\n" + 
			"		{\n" + 
			"			Object o1 = mObj;\n" + 
			"			mObj = \"1\";\n" + 
			"		}\n" + 
			"		Object o2 = mObj = \"2\";\n" + 
			"		void foo() {\n" + 
			"			Object o3 = mObj;\n" + 
			"			mObj = \"3\";\n" + 
			"		}\n" + 
			"	};\n" + 
			"	public X() {\n" + 
			"		mObj = \"\";\n" + 
			"	}\n" + 
			"}\n"
		}, 
		"----------\n" + 
		"1. WARNING in X.java (at line 3)\n" + 
		"	private final Object mDependent = new Object() {\n" + 
		"	                     ^^^^^^^^^^\n" + 
		"The field X<T>.mDependent is never read locally\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"4. WARNING in X.java (at line 6)\n" + 
		"	mObj = \"1\";\n" + 
		"	^^^^\n" + 
		"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"5. ERROR in X.java (at line 6)\n" + 
		"	mObj = \"1\";\n" + 
		"	^^^^\n" + 
		"The final field X<T>.mObj cannot be assigned\n" + 
		"----------\n" + 
		"6. WARNING in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	       ^^\n" + 
		"The field new Object(){}.o2 is never read locally\n" + 
		"----------\n" + 
		"7. WARNING in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	            ^^^^\n" + 
		"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"8. ERROR in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	            ^^^^\n" + 
		"The final field X<T>.mObj cannot be assigned\n" + 
		"----------\n" + 
		"9. WARNING in X.java (at line 9)\n" + 
		"	void foo() {\n" + 
		"	     ^^^^^\n" + 
		"The method foo() from the type new Object(){} is never used locally\n" + 
		"----------\n" + 
		"10. WARNING in X.java (at line 10)\n" + 
		"	Object o3 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"11. WARNING in X.java (at line 11)\n" + 
		"	mObj = \"3\";\n" + 
		"	^^^^\n" + 
		"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"12. ERROR in X.java (at line 11)\n" + 
		"	mObj = \"3\";\n" + 
		"	^^^^\n" + 
		"The final field X<T>.mObj cannot be assigned\n" + 
		"----------\n");
}
}

Lines 41-47 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/SingleNameReference.java (-2 / +2 lines)
41	case Binding.FIELD : // reading a field	41	case Binding.FIELD : // reading a field
42	FieldBinding fieldBinding;	42	FieldBinding fieldBinding;
43	if ((fieldBinding = (FieldBinding) binding).isBlankFinal()	43	if ((fieldBinding = (FieldBinding) binding).isBlankFinal()
44	&& currentScope.allowBlankFinalFieldAssignment(fieldBinding)) {	44	&& currentScope.needBlankFinalFieldInitializationCheck(fieldBinding)) {
45	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {	45	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {
46	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);	46	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);
47	}	47	}
Lines 152-158 Link Here
152	}	152	}
153	}	153	}
154	// check if reading a final blank field	154	// check if reading a final blank field
155	if (fieldBinding.isBlankFinal() && currentScope.allowBlankFinalFieldAssignment(fieldBinding)) {	155	if (fieldBinding.isBlankFinal() && currentScope.needBlankFinalFieldInitializationCheck(fieldBinding)) {
156	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {	156	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {
157	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);	157	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);
158	}	158	}

Lines 46-52 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/FieldReference.java (-1 / +1 lines)
46	if (isCompound) { // check the variable part is initialized if blank final	46	if (isCompound) { // check the variable part is initialized if blank final
47	if (binding.isBlankFinal()	47	if (binding.isBlankFinal()
48	&& receiver.isThis()	48	&& receiver.isThis()
49	&& currentScope.allowBlankFinalFieldAssignment(binding)	49	&& currentScope.needBlankFinalFieldInitializationCheck(binding)
50	&& (!flowInfo.isDefinitelyAssigned(binding))) {	50	&& (!flowInfo.isDefinitelyAssigned(binding))) {
51	currentScope.problemReporter().uninitializedBlankFinalField(binding, this);	51	currentScope.problemReporter().uninitializedBlankFinalField(binding, this);
52	// we could improve error msg here telling "cannot use compound assignment on final blank field"	52	// we could improve error msg here telling "cannot use compound assignment on final blank field"




			// check if final blank field
			if (lastFieldBinding.isBlankFinal()
				    && this.otherBindings != null // the last field binding is only assigned
	 				&& currentScope.needBlankFinalFieldInitializationCheck(lastFieldBinding)) {
				if (!flowInfo.isDefinitelyAssigned(lastFieldBinding)) {
					currentScope.problemReporter().uninitializedBlankFinalField(
						lastFieldBinding,

	if (isCompound) {
		if (otherBindingsCount == 0
				&& lastFieldBinding.isBlankFinal()
				&& currentScope.needBlankFinalFieldInitializationCheck(lastFieldBinding)
				&& (!flowInfo.isDefinitelyAssigned(lastFieldBinding))) {
			currentScope.problemReporter().uninitializedBlankFinalField(lastFieldBinding, this);
		}

				}				
				// check if reading a final blank field
				if (fieldBinding.isBlankFinal()
						&& currentScope.needBlankFinalFieldInitializationCheck(fieldBinding)
						&& !flowInfo.isDefinitelyAssigned(fieldBinding)) {
					currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);
				}




import org.eclipse.jdt.internal.compiler.problem.ProblemReporter;

/**
 * Specific block scope used for methods, constructors or clinits, representing
 * its outermost blockscope. Note also that such a scope will be provided to enclose
 * field initializers subscopes as well.
 */

	// inner-emulation
	public SyntheticArgumentBinding[] extraSyntheticArguments;
	
public MethodScope(ClassScope parent, ReferenceContext context, boolean isStatic) {
	super(METHOD_SCOPE, parent);
	locals = new LocalVariableBinding[5];
	this.referenceContext = context;
	this.isStatic = isStatic;
	this.startIndex = 0;
}

String basicToString(int tab) {
	String newLine = "\n"; //$NON-NLS-1$
	for (int i = tab; --i >= 0;)
		newLine += "\t"; //$NON-NLS-1$

	String s = newLine + "--- Method Scope ---"; //$NON-NLS-1$
	newLine += "\t"; //$NON-NLS-1$
	s += newLine + "locals:"; //$NON-NLS-1$
	for (int i = 0; i < localIndex; i++)
		s += newLine + "\t" + locals[i].toString(); //$NON-NLS-1$
	s += newLine + "startIndex = " + startIndex; //$NON-NLS-1$
	s += newLine + "isConstructorCall = " + isConstructorCall; //$NON-NLS-1$
	s += newLine + "initializedField = " + initializedField; //$NON-NLS-1$
	s += newLine + "lastVisibleFieldID = " + lastVisibleFieldID; //$NON-NLS-1$
	s += newLine + "referenceContext = " + referenceContext; //$NON-NLS-1$
	return s;
}

/**
 * Spec : 8.4.3 & 9.4
 */
private void checkAndSetModifiersForConstructor(MethodBinding methodBinding) {
	int modifiers = methodBinding.modifiers;
	final ReferenceBinding declaringClass = methodBinding.declaringClass;
	if ((modifiers & ExtraCompilerModifiers.AccAlternateModifierProblem) != 0)
		problemReporter().duplicateModifierForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

	if ((((ConstructorDeclaration) referenceContext).bits & ASTNode.IsDefaultConstructor) != 0) {
		// certain flags are propagated from declaring class onto constructor
		final int DECLARING_FLAGS = ClassFileConstants.AccEnum|ClassFileConstants.AccPublic|ClassFileConstants.AccProtected;
		final int VISIBILITY_FLAGS = ClassFileConstants.AccPrivate|ClassFileConstants.AccPublic|ClassFileConstants.AccProtected;
		int flags;
		if ((flags = declaringClass.modifiers & DECLARING_FLAGS) != 0) {
			if ((flags & ClassFileConstants.AccEnum) != 0) {
				modifiers &= ~VISIBILITY_FLAGS;
				modifiers |= ClassFileConstants.AccPrivate; // default constructor is implicitly private in enum
			} else {
				modifiers &= ~VISIBILITY_FLAGS;
				modifiers |= flags; // propagate public/protected
			}
		}
	}

	// after this point, tests on the 16 bits reserved.
	int realModifiers = modifiers & ExtraCompilerModifiers.AccJustFlag;

	// check for abnormal modifiers
	final int UNEXPECTED_MODIFIERS = ~(ClassFileConstants.AccPublic | ClassFileConstants.AccPrivate | ClassFileConstants.AccProtected | ClassFileConstants.AccStrictfp);
	if (declaringClass.isEnum() && (((ConstructorDeclaration) referenceContext).bits & ASTNode.IsDefaultConstructor) == 0) {
		final int UNEXPECTED_ENUM_CONSTR_MODIFIERS = ~(ClassFileConstants.AccPrivate | ClassFileConstants.AccStrictfp);
		if ((realModifiers & UNEXPECTED_ENUM_CONSTR_MODIFIERS) != 0) {
			problemReporter().illegalModifierForEnumConstructor((AbstractMethodDeclaration) referenceContext);
			modifiers &= ~ExtraCompilerModifiers.AccJustFlag | ~UNEXPECTED_ENUM_CONSTR_MODIFIERS;
			} else if ((((AbstractMethodDeclaration) referenceContext).modifiers & ClassFileConstants.AccStrictfp) != 0) {
				// must check the parse node explicitly
				problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
			}
			modifiers |= ClassFileConstants.AccPrivate; // enum constructor is implicitly private
		} else if ((realModifiers & UNEXPECTED_MODIFIERS) != 0) {
			problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
			modifiers &= ~ExtraCompilerModifiers.AccJustFlag | ~UNEXPECTED_MODIFIERS;
		} else if ((((AbstractMethodDeclaration) referenceContext).modifiers & ClassFileConstants.AccStrictfp) != 0) {
			// must check the parse node explicitly
			problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
		}
		modifiers |= ClassFileConstants.AccPrivate; // enum constructor is implicitly private
	} else if ((realModifiers & UNEXPECTED_MODIFIERS) != 0) {
		problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
		modifiers &= ~ExtraCompilerModifiers.AccJustFlag | ~UNEXPECTED_MODIFIERS;
	} else if ((((AbstractMethodDeclaration) referenceContext).modifiers & ClassFileConstants.AccStrictfp) != 0) {
		// must check the parse node explicitly
		problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
	}

	// check for incompatible modifiers in the visibility bits, isolate the visibility bits
	int accessorBits = realModifiers & (ClassFileConstants.AccPublic | ClassFileConstants.AccProtected | ClassFileConstants.AccPrivate);
	if ((accessorBits & (accessorBits - 1)) != 0) {
		problemReporter().illegalVisibilityModifierCombinationForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

		// need to keep the less restrictive so disable Protected/Private as necessary
		if ((accessorBits & ClassFileConstants.AccPublic) != 0) {
			if ((accessorBits & ClassFileConstants.AccProtected) != 0)
				modifiers &= ~ClassFileConstants.AccProtected;
			if ((accessorBits & ClassFileConstants.AccPrivate) != 0)
				modifiers &= ~ClassFileConstants.AccPrivate;
		} else if ((accessorBits & ClassFileConstants.AccProtected) != 0 && (accessorBits & ClassFileConstants.AccPrivate) != 0) {
			modifiers &= ~ClassFileConstants.AccPrivate;
		}
	}

//		// if the receiver's declaring class is a private nested type, then make sure the receiver is not private (causes problems for inner type emulation)
//		if (declaringClass.isPrivate() && (modifiers & ClassFileConstants.AccPrivate) != 0)
//			modifiers &= ~ClassFileConstants.AccPrivate;

	methodBinding.modifiers = modifiers;
}
	
	/* Spec : 8.4.3 & 9.4
	 */
	private void checkAndSetModifiersForMethod(MethodBinding methodBinding) {
		
		int modifiers = methodBinding.modifiers;
		final ReferenceBinding declaringClass = methodBinding.declaringClass;
		if ((modifiers & ExtraCompilerModifiers.AccAlternateModifierProblem) != 0)
			problemReporter().duplicateModifierForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

		// after this point, tests on the 16 bits reserved.
		int realModifiers = modifiers & ExtraCompilerModifiers.AccJustFlag;

		// set the requested modifiers for a method in an interface/annotation
		if (declaringClass.isInterface()) {
			if ((realModifiers & ~(ClassFileConstants.AccPublic | ClassFileConstants.AccAbstract)) != 0) {
				if ((declaringClass.modifiers & ClassFileConstants.AccAnnotation) != 0)
					problemReporter().illegalModifierForAnnotationMember((AbstractMethodDeclaration) referenceContext);
				else
					problemReporter().illegalModifierForInterfaceMethod((AbstractMethodDeclaration) referenceContext);
			}
			return;
		}

		// check for abnormal modifiers
		final int UNEXPECTED_MODIFIERS = ~(ClassFileConstants.AccPublic | ClassFileConstants.AccPrivate | ClassFileConstants.AccProtected
			| ClassFileConstants.AccAbstract | ClassFileConstants.AccStatic | ClassFileConstants.AccFinal | ClassFileConstants.AccSynchronized | ClassFileConstants.AccNative | ClassFileConstants.AccStrictfp);
		if ((realModifiers & UNEXPECTED_MODIFIERS) != 0) {
			problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
			modifiers &= ~ExtraCompilerModifiers.AccJustFlag | ~UNEXPECTED_MODIFIERS;
		}

/**
 * Spec : 8.4.3 & 9.4
 */
private void checkAndSetModifiersForMethod(MethodBinding methodBinding) {
	int modifiers = methodBinding.modifiers;
	final ReferenceBinding declaringClass = methodBinding.declaringClass;
	if ((modifiers & ExtraCompilerModifiers.AccAlternateModifierProblem) != 0)
		problemReporter().duplicateModifierForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

	// after this point, tests on the 16 bits reserved.
	int realModifiers = modifiers & ExtraCompilerModifiers.AccJustFlag;

	// set the requested modifiers for a method in an interface/annotation
	if (declaringClass.isInterface()) {
		if ((realModifiers & ~(ClassFileConstants.AccPublic | ClassFileConstants.AccAbstract)) != 0) {
			if ((declaringClass.modifiers & ClassFileConstants.AccAnnotation) != 0)
				problemReporter().illegalModifierForAnnotationMember((AbstractMethodDeclaration) referenceContext);
			else
				problemReporter().illegalModifierForInterfaceMethod((AbstractMethodDeclaration) referenceContext);
		}
		return;
	}

	// check for abnormal modifiers
	final int UNEXPECTED_MODIFIERS = ~(ClassFileConstants.AccPublic | ClassFileConstants.AccPrivate | ClassFileConstants.AccProtected
		| ClassFileConstants.AccAbstract | ClassFileConstants.AccStatic | ClassFileConstants.AccFinal | ClassFileConstants.AccSynchronized | ClassFileConstants.AccNative | ClassFileConstants.AccStrictfp);
	if ((realModifiers & UNEXPECTED_MODIFIERS) != 0) {
		problemReporter().illegalModifierForMethod((AbstractMethodDeclaration) referenceContext);
		modifiers &= ~ExtraCompilerModifiers.AccJustFlag | ~UNEXPECTED_MODIFIERS;
	}

	// check for incompatible modifiers in the visibility bits, isolate the visibility bits
	int accessorBits = realModifiers & (ClassFileConstants.AccPublic | ClassFileConstants.AccProtected | ClassFileConstants.AccPrivate);
	if ((accessorBits & (accessorBits - 1)) != 0) {
		problemReporter().illegalVisibilityModifierCombinationForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

		// need to keep the less restrictive so disable Protected/Private as necessary
		if ((accessorBits & ClassFileConstants.AccPublic) != 0) {
			if ((accessorBits & ClassFileConstants.AccProtected) != 0)
				modifiers &= ~ClassFileConstants.AccProtected;
			if ((accessorBits & ClassFileConstants.AccPrivate) != 0)
				modifiers &= ~ClassFileConstants.AccPrivate;
		} else if ((accessorBits & ClassFileConstants.AccProtected) != 0 && (accessorBits & ClassFileConstants.AccPrivate) != 0) {
			modifiers &= ~ClassFileConstants.AccPrivate;
		}
	}

	// check for modifiers incompatible with abstract modifier
	if ((modifiers & ClassFileConstants.AccAbstract) != 0) {
		int incompatibleWithAbstract = ClassFileConstants.AccPrivate | ClassFileConstants.AccStatic | ClassFileConstants.AccFinal | ClassFileConstants.AccSynchronized | ClassFileConstants.AccNative | ClassFileConstants.AccStrictfp;
		if ((modifiers & incompatibleWithAbstract) != 0)
			problemReporter().illegalAbstractModifierCombinationForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);
		if (!methodBinding.declaringClass.isAbstract())
			problemReporter().abstractMethodInAbstractClass((SourceTypeBinding) declaringClass, (AbstractMethodDeclaration) referenceContext);
		}

		/* DISABLED for backward compatibility with javac (if enabled should also mark private methods as final)
		// methods from a final class are final : 8.4.3.3 
		if (methodBinding.declaringClass.isFinal())
			modifiers |= AccFinal;
		*/
		// native methods cannot also be tagged as strictfp
		if ((modifiers & ClassFileConstants.AccNative) != 0 && (modifiers & ClassFileConstants.AccStrictfp) != 0)
			problemReporter().nativeMethodsCannotBeStrictfp(declaringClass, (AbstractMethodDeclaration) referenceContext);

		// static members are only authorized in a static member or top level type
		if (((realModifiers & ClassFileConstants.AccStatic) != 0) && declaringClass.isNestedType() && !declaringClass.isStatic())
			problemReporter().unexpectedStaticModifierForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

		methodBinding.modifiers = modifiers;
	}

	/* DISABLED for backward compatibility with javac (if enabled should also mark private methods as final)
	// methods from a final class are final : 8.4.3.3 
	if (methodBinding.declaringClass.isFinal())
		modifiers |= AccFinal;
	*/
	// native methods cannot also be tagged as strictfp
	if ((modifiers & ClassFileConstants.AccNative) != 0 && (modifiers & ClassFileConstants.AccStrictfp) != 0)
		problemReporter().nativeMethodsCannotBeStrictfp(declaringClass, (AbstractMethodDeclaration) referenceContext);

	// static members are only authorized in a static member or top level type
	if (((realModifiers & ClassFileConstants.AccStatic) != 0) && declaringClass.isNestedType() && !declaringClass.isStatic())
		problemReporter().unexpectedStaticModifierForMethod(declaringClass, (AbstractMethodDeclaration) referenceContext);

	methodBinding.modifiers = modifiers;
}

/**
 * Compute variable positions in scopes given an initial position offset
 * ignoring unused local variables.
 * 
 * Deal with arguments here, locals and subscopes are processed in BlockScope method
 */
public void computeLocalVariablePositions(int initOffset, CodeStream codeStream) {

	boolean isReportingUnusedArgument = false;

	if (referenceContext instanceof AbstractMethodDeclaration) {
		AbstractMethodDeclaration methodDecl = (AbstractMethodDeclaration)referenceContext;
		MethodBinding method = methodDecl.binding;
		if (!(method.isAbstract()
				|| (method.isImplementing() && !compilerOptions().reportUnusedParameterWhenImplementingAbstract) 
				|| (method.isOverriding() && !method.isImplementing() && !compilerOptions().reportUnusedParameterWhenOverridingConcrete)
				|| method.isMain())) {
			isReportingUnusedArgument = true;
		}
	}
	this.offset = initOffset;
	this.maxOffset = initOffset;

	// manage arguments	
	int ilocal = 0, maxLocals = this.localIndex;
	while (ilocal < maxLocals) {
		LocalVariableBinding local = locals[ilocal];
		if (local == null || ((local.tagBits & TagBits.IsArgument) == 0)) break; // done with arguments

		// do not report fake used variable
		if (isReportingUnusedArgument
				&& local.useFlag == LocalVariableBinding.UNUSED
				&& ((local.declaration.bits & ASTNode.IsLocalDeclarationReachable) != 0)) { // declaration is reachable
			this.problemReporter().unusedArgument(local.declaration);
		}

		// record user-defined argument for attribute generation
		codeStream.record(local); 

		// assign variable position
		local.resolvedPosition = this.offset;

		if ((local.type == TypeBinding.LONG) || (local.type == TypeBinding.DOUBLE)) {
			this.offset += 2;
		} else {
			this.offset++;
		}
		// check for too many arguments/local variables
		if (this.offset > 0xFF) { // no more than 255 words of arguments
			this.problemReporter().noMoreAvailableSpaceForArgument(local, local.declaration);
		}
		ilocal++;
	}
	
	// sneak in extra argument before other local variables
	if (extraSyntheticArguments != null) {
		for (int iarg = 0, maxArguments = extraSyntheticArguments.length; iarg < maxArguments; iarg++){
			SyntheticArgumentBinding argument = extraSyntheticArguments[iarg];
			argument.resolvedPosition = this.offset;
			if ((argument.type == TypeBinding.LONG) || (argument.type == TypeBinding.DOUBLE)){
				this.offset += 2;
			} else {
				this.offset++;
			}
			// check for too many arguments/local variables
			if (this.offset > 0xFF) { // no more than 255 words of arguments
				this.problemReporter().noMoreAvailableSpaceForArgument(argument, (ASTNode)this.referenceContext); 
			}
			ilocal++;
		}
		
		// sneak in extra argument before other local variables
		if (extraSyntheticArguments != null) {
			for (int iarg = 0, maxArguments = extraSyntheticArguments.length; iarg < maxArguments; iarg++){
				SyntheticArgumentBinding argument = extraSyntheticArguments[iarg];
				argument.resolvedPosition = this.offset;
				if ((argument.type == TypeBinding.LONG) || (argument.type == TypeBinding.DOUBLE)){
					this.offset += 2;
				} else {
					this.offset++;
				}
				if (this.offset > 0xFF) { // no more than 255 words of arguments
					this.problemReporter().noMoreAvailableSpaceForArgument(argument, (ASTNode)this.referenceContext); 
				}
			}
		}
		this.computeLocalVariablePositions(ilocal, this.offset, codeStream);
	}
	this.computeLocalVariablePositions(ilocal, this.offset, codeStream);
}

/**
 * Error management:
 * 		keep null for all the errors that prevent the method to be created
 * 		otherwise return a correct method binding (but without the element
 *		that caused the problem) : ie : Incorrect thrown exception
 */
MethodBinding createMethod(AbstractMethodDeclaration method) {
	// is necessary to ensure error reporting
	this.referenceContext = method;
	method.scope = this;
	SourceTypeBinding declaringClass = referenceType().binding;
	int modifiers = method.modifiers | ExtraCompilerModifiers.AccUnresolved;
	if (method.isConstructor()) {
		if (method.isDefaultConstructor())
			modifiers |= ExtraCompilerModifiers.AccIsDefaultConstructor;
		method.binding = new MethodBinding(modifiers, null, null, declaringClass);
		checkAndSetModifiersForConstructor(method.binding);
	} else {
		if (declaringClass.isInterface()) // interface or annotation type
			modifiers |= ClassFileConstants.AccPublic | ClassFileConstants.AccAbstract;
		method.binding =
			new MethodBinding(modifiers, method.selector, null, null, null, declaringClass);
		checkAndSetModifiersForMethod(method.binding);
	}
	this.isStatic = method.binding.isStatic();

	Argument[] argTypes = method.arguments;
	int argLength = argTypes == null ? 0 : argTypes.length;
	if (argLength > 0 && compilerOptions().sourceLevel >= ClassFileConstants.JDK1_5) {
		if (argTypes[--argLength].isVarArgs())
			method.binding.modifiers |= ClassFileConstants.AccVarargs;
		while (--argLength >= 0) {
			if (argTypes[argLength].isVarArgs())
				problemReporter().illegalVararg(argTypes[argLength], method);
			}
		}
		
		TypeParameter[] typeParameters = method.typeParameters();
	    // do not construct type variables if source < 1.5
		if (typeParameters == null || compilerOptions().sourceLevel < ClassFileConstants.JDK1_5) {
		    method.binding.typeVariables = Binding.NO_TYPE_VARIABLES;
		} else {
			method.binding.typeVariables = createTypeVariables(typeParameters, method.binding);
			method.binding.modifiers |= ExtraCompilerModifiers.AccGenericSignature;
		}
		return method.binding;
	}

	/* Overridden to detect the error case inside an explicit constructor call:
	
	TypeParameter[] typeParameters = method.typeParameters();
    // do not construct type variables if source < 1.5
	if (typeParameters == null || compilerOptions().sourceLevel < ClassFileConstants.JDK1_5) {
	    method.binding.typeVariables = Binding.NO_TYPE_VARIABLES;
	} else {
		method.binding.typeVariables = createTypeVariables(typeParameters, method.binding);
		method.binding.modifiers |= ExtraCompilerModifiers.AccGenericSignature;
	}
	return method.binding;
}
		TypeBinding receiverType,
		char[] fieldName,
		InvocationSite invocationSite,
		boolean needResolve) {

		FieldBinding field = super.findField(receiverType, fieldName, invocationSite, needResolve);
		if (field == null)
			return null;
		if (!field.isValidBinding())
			return field; // answer the error field
		if (field.isStatic())
			return field; // static fields are always accessible

/**
 * Overridden to detect the error case inside an explicit constructor call:
class X {
	int i;
	X myX;
	X(X x) {
		this(i, myX.i, x.i); // same for super calls... only the first 2 field accesses are errors
	}
}
 */
public FieldBinding findField(TypeBinding receiverType, char[] fieldName, InvocationSite invocationSite, boolean needResolve) {

	FieldBinding field = super.findField(receiverType, fieldName, invocationSite, needResolve);
	if (field == null)
		return null;
	if (!field.isValidBinding())
		return field; // answer the error field
	if (field.isStatic())
		return field; // static fields are always accessible

	if (!isConstructorCall || receiverType != enclosingSourceType())
		return field;

	if (invocationSite instanceof SingleNameReference)
		return new ProblemFieldBinding(
			field, // closest match
			field.declaringClass,
			fieldName,
			ProblemReasons.NonStaticReferenceInConstructorInvocation);
	if (invocationSite instanceof QualifiedNameReference) {
		// look to see if the field is the first binding
		QualifiedNameReference name = (QualifiedNameReference) invocationSite;
		if (name.binding == null)
			// only true when the field is the fieldbinding at the beginning of name's tokens
			return new ProblemFieldBinding(
				field, // closest match
				field.declaringClass,
				fieldName,
				ProblemReasons.NonStaticReferenceInConstructorInvocation);
		if (invocationSite instanceof QualifiedNameReference) {
			// look to see if the field is the first binding
			QualifiedNameReference name = (QualifiedNameReference) invocationSite;
			if (name.binding == null)
				// only true when the field is the fieldbinding at the beginning of name's tokens
				return new ProblemFieldBinding(
					field, // closest match
					field.declaringClass,
					fieldName,
					ProblemReasons.NonStaticReferenceInConstructorInvocation);
		}
		return field;
	}

	public boolean isInsideConstructor() {

		return (referenceContext instanceof ConstructorDeclaration);
	}
	
	public boolean isInsideInitializer() {

		return (referenceContext instanceof TypeDeclaration);
	}
	return field;
}

public boolean isInsideConstructor() {
	return (referenceContext instanceof ConstructorDeclaration);
}

public boolean isInsideInitializer() {
	return (referenceContext instanceof TypeDeclaration);
}

public boolean isInsideInitializerOrConstructor() {
	return (referenceContext instanceof TypeDeclaration)
		|| (referenceContext instanceof ConstructorDeclaration);
}
	 * to abort.
	 */
	public ProblemReporter problemReporter() {

/**
 * Answer the problem reporter to use for raising new problems.
 *
 * Note that as a side-effect, this updates the current reference context
 * (unit, type or method) in case the problem handler decides it is necessary
 * to abort.
 */
public ProblemReporter problemReporter() {
	MethodScope outerMethodScope;
	if ((outerMethodScope = outerMostMethodScope()) == this) {
		ProblemReporter problemReporter = referenceCompilationUnit().problemReporter;
		problemReporter.referenceContext = referenceContext;
		return problemReporter;
	}
	return outerMethodScope.problemReporter();
}

public final int recordInitializationStates(FlowInfo flowInfo) {
	if ((flowInfo.tagBits & FlowInfo.UNREACHABLE) != 0) return -1;
	UnconditionalFlowInfo unconditionalFlowInfo = flowInfo.unconditionalInitsWithoutSideEffect();
	long[] extraInits = unconditionalFlowInfo.extra == null ?
			null : unconditionalFlowInfo.extra[0];
	long inits = unconditionalFlowInfo.definiteInits;
	checkNextEntry : for (int i = lastIndex; --i >= 0;) {
		if (definiteInits[i] == inits) {
			long[] otherInits = extraDefiniteInits[i];
			if ((extraInits != null) && (otherInits != null)) {
				if (extraInits.length == otherInits.length) {
					int j, max;
					for (j = 0, max = extraInits.length; j < max; j++) {
						if (extraInits[j] != otherInits[j]) {
							continue checkNextEntry;
							if (extraInits[j] != otherInits[j]) {
								continue checkNextEntry;
							}
						}
						return i;
					}
				} else {
					if ((extraInits == null) && (otherInits == null)) {
						return i;
					}
					return i;
				}
			} else {
				if ((extraInits == null) && (otherInits == null)) {
					return i;
				}
			}
		}

		// add a new entry
		if (definiteInits.length == lastIndex) {
			// need a resize
			System.arraycopy(
				definiteInits,
				0,
				(definiteInits = new long[lastIndex + 20]),
				0,
				lastIndex);
			System.arraycopy(
				extraDefiniteInits,
				0,
				(extraDefiniteInits = new long[lastIndex + 20][]),
				0,
				lastIndex);
		}
		definiteInits[lastIndex] = inits;
		if (extraInits != null) {
			extraDefiniteInits[lastIndex] = new long[extraInits.length];
			System.arraycopy(
				extraInits,
				0,
				extraDefiniteInits[lastIndex],
				0,
				extraInits.length);
		}
		return lastIndex++;
	}

	/* Answer the reference method of this scope, or null if initialization scoope.
	*/
	public AbstractMethodDeclaration referenceMethod() {

		if (referenceContext instanceof AbstractMethodDeclaration) return (AbstractMethodDeclaration) referenceContext;
		return null;
	}

	// add a new entry
	if (definiteInits.length == lastIndex) {
		// need a resize
		System.arraycopy(
			definiteInits,
			0,
			(definiteInits = new long[lastIndex + 20]),
			0,
			lastIndex);
		System.arraycopy(
			extraDefiniteInits,
			0,
			(extraDefiniteInits = new long[lastIndex + 20][]),
			0,
			lastIndex);
	}
	definiteInits[lastIndex] = inits;
	if (extraInits != null) {
		extraDefiniteInits[lastIndex] = new long[extraInits.length];
		System.arraycopy(
			extraInits,
			0,
			extraDefiniteInits[lastIndex],
			0,
			extraInits.length);
	}
	return lastIndex++;
}

/**
 *  Answer the reference method of this scope, or null if initialization scoope.
 */
public AbstractMethodDeclaration referenceMethod() {
	if (referenceContext instanceof AbstractMethodDeclaration) return (AbstractMethodDeclaration) referenceContext;
	return null;
}
		newLine += "\t"; //$NON-NLS-1$
		s += newLine + "locals:"; //$NON-NLS-1$
		for (int i = 0; i < localIndex; i++)
			s += newLine + "\t" + locals[i].toString(); //$NON-NLS-1$
		s += newLine + "startIndex = " + startIndex; //$NON-NLS-1$
		s += newLine + "isConstructorCall = " + isConstructorCall; //$NON-NLS-1$
		s += newLine + "initializedField = " + initializedField; //$NON-NLS-1$
		s += newLine + "lastVisibleFieldID = " + lastVisibleFieldID; //$NON-NLS-1$
		s += newLine + "referenceContext = " + referenceContext; //$NON-NLS-1$
		return s;
	}

/**
 *  Answer the reference type of this scope.
 * It is the nearest enclosing type of this scope.
 */
public TypeDeclaration referenceType() {
	return ((ClassScope) parent).referenceContext;
}
}




	this.subscopes[this.subscopeCount++] = childScope;
}

/**
 * Answer true if the receiver is suitable for assigning final blank fields.
 * in other words, it is inside an initializer, a constructor or a clinit 
 */
public final boolean allowBlankFinalFieldAssignment(FieldBinding binding) {

	return methodScope.isInsideInitializer() // inside initializer
			|| ((AbstractMethodDeclaration) methodScope.referenceContext).isInitializationMethod(); // inside constructor or clinit
}

String basicToString(int tab) {
	String newLine = "\n"; //$NON-NLS-1$
	for (int i = tab; --i >= 0;)

	return max;
}

/**
 * Returns true if the context requires to check initialization of final blank fields.
 * in other words, it is inside an initializer, a constructor or a clinit 
 */
public final boolean needBlankFinalFieldInitializationCheck(FieldBinding binding) {
	boolean isStatic = binding.isStatic();
	ReferenceBinding fieldDeclaringClass = binding.declaringClass;
	// loop in enclosing context, until reaching the field declaring context
	MethodScope methodScope = methodScope();
	while (methodScope != null) {
		if (methodScope.isStatic != isStatic)
			return false;
		if (!methodScope.isInsideInitializer() // inside initializer
				&& !((AbstractMethodDeclaration) methodScope.referenceContext).isInitializationMethod()) { // inside constructor or clinit
			return false; // found some non-initializer context
		}
		if (fieldDeclaringClass == methodScope.enclosingReceiverType()) {
			return true; // found the field context, no need to check any further
		}
		methodScope = methodScope.enclosingMethodScope();
	}
	return false;
}

/* Answer the problem reporter to use for raising new problems.
 *
 * Note that as a side-effect, this updates the current reference context

Lines 56-62 Link Here

(-)eval/org/eclipse/jdt/internal/eval/CodeSnippetSingleNameReference.java (-1 / +1 lines)
56	// check if reading a final blank field	56	// check if reading a final blank field
57	FieldBinding fieldBinding;	57	FieldBinding fieldBinding;
58	if ((fieldBinding = (FieldBinding) this.binding).isBlankFinal()	58	if ((fieldBinding = (FieldBinding) this.binding).isBlankFinal()
59	&& currentScope.allowBlankFinalFieldAssignment(fieldBinding)) {	59	&& currentScope.needBlankFinalFieldInitializationCheck(fieldBinding)) {
60	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {	60	if (!flowInfo.isDefinitelyAssigned(fieldBinding)) {
61	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);	61	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);
62	}	62	}




		assertTrue(false);
	}			
}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061
public void test192() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public final class X {\n" + 
			"	private final Object mObj;\n" + 
			"	private final Object mDependent = new Object() {\n" + 
			"		{\n" + 
			"			Object o1 = mObj;\n" + 
			"		}\n" + 
			"		Object o2 = mObj;\n" + 
			"		void foo() {\n" + 
			"			Object o3 = mObj;\n" + 
			"		}\n" + 
			"	};\n" + 
			"	public X() {\n" + 
			"		mObj = \"\";\n" + 
			"	}\n" + 
			"}\n"
		}, 
		"----------\n" + 
		"1. WARNING in X.java (at line 3)\n" + 
		"	private final Object mDependent = new Object() {\n" + 
		"	                     ^^^^^^^^^^\n" + 
		"The field X.mDependent is never read locally\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"4. WARNING in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	       ^^\n" + 
		"The field new Object(){}.o2 is never read locally\n" + 
		"----------\n" + 
		"5. WARNING in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"6. ERROR in X.java (at line 7)\n" + 
		"	Object o2 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"7. WARNING in X.java (at line 8)\n" + 
		"	void foo() {\n" + 
		"	     ^^^^^\n" + 
		"The method foo() from the type new Object(){} is never used locally\n" + 
		"----------\n" + 
		"8. WARNING in X.java (at line 9)\n" + 
		"	Object o3 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n");
}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
public void test193() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public final class X {\n" + 
			"	private final Object mObj;\n" + 
			"	private final Object mDependent = new Object() {\n" + 
			"		{\n" + 
			"			Object o1 = mObj;\n" + 
			"			mObj = \"1\";\n" + 
			"		}\n" + 
			"		Object o2 = mObj = \"2\";\n" + 
			"		void foo() {\n" + 
			"			Object o3 = mObj;\n" + 
			"			mObj = \"3\";\n" + 
			"		}\n" + 
			"	};\n" + 
			"	public X() {\n" + 
			"		mObj = \"\";\n" + 
			"	}\n" + 
			"}\n"
		}, 
		"----------\n" + 
		"1. WARNING in X.java (at line 3)\n" + 
		"	private final Object mDependent = new Object() {\n" + 
		"	                     ^^^^^^^^^^\n" + 
		"The field X.mDependent is never read locally\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 5)\n" + 
		"	Object o1 = mObj;\n" + 
		"	            ^^^^\n" + 
		"The blank final field mObj may not have been initialized\n" + 
		"----------\n" + 
		"4. WARNING in X.java (at line 6)\n" + 
		"	mObj = \"1\";\n" + 
		"	^^^^\n" + 
		"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"5. ERROR in X.java (at line 6)\n" + 
		"	mObj = \"1\";\n" + 
		"	^^^^\n" + 
		"The final field X.mObj cannot be assigned\n" + 
		"----------\n" + 
		"6. WARNING in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	       ^^\n" + 
		"The field new Object(){}.o2 is never read locally\n" + 
		"----------\n" + 
		"7. WARNING in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	            ^^^^\n" + 
		"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"8. ERROR in X.java (at line 8)\n" + 
		"	Object o2 = mObj = \"2\";\n" + 
		"	            ^^^^\n" + 
		"The final field X.mObj cannot be assigned\n" + 
		"----------\n" + 
		"9. WARNING in X.java (at line 9)\n" + 
		"	void foo() {\n" + 
		"	     ^^^^^\n" + 
		"The method foo() from the type new Object(){} is never used locally\n" + 
		"----------\n" + 
		"10. WARNING in X.java (at line 10)\n" + 
		"	Object o3 = mObj;\n" + 
		"	            ^^^^\n" + 
		"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"11. WARNING in X.java (at line 11)\n" + 
		"	mObj = \"3\";\n" + 
		"	^^^^\n" + 
		"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" + 
		"----------\n" + 
		"12. ERROR in X.java (at line 11)\n" + 
		"	mObj = \"3\";\n" + 
		"	^^^^\n" + 
		"The final field X.mObj cannot be assigned\n" + 
		"----------\n");
}
public static Class testClass() {
	return InitializationTest.class;
}

Return to bug 203061

Lines 38757-38763 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java (-2 / +150 lines)
38757	}	38757	}
38758	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation	38758	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation
38759	public void test1161() {	38759	public void test1161() {
38760	this.runNegativeTest(	38760	this.runConformTest(
38761	new String[] {	38761	new String[] {
38762	"X.java",	38762	"X.java",
38763	"class Y<T extends Y<T>> {}\n" +	38763	"class Y<T extends Y<T>> {}\n" +
Lines 38770-38776 Link Here
38770	}	38770	}
38771	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation	38771	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=202404 - variation
38772	public void test1162() {	38772	public void test1162() {
38773	this.runNegativeTest(	38773	this.runConformTest(
38774	new String[] {	38774	new String[] {
38775	"X.java",	38775	"X.java",
38776	"class Y<T extends Y<T>> {}\n" +	38776	"class Y<T extends Y<T>> {}\n" +
Lines 38781-38784 Link Here
38781	},	38781	},
38782	"");	38782	"");
38783	}	38783	}
		38784	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
		38785	public void test1163() {
		38786	this.runNegativeTest(
		38787	new String[] {
		38788	"X.java",
		38789	"public final class X<T> {\n" +
		38790	" private final Object mObj;\n" +
		38791	" private final Object mDependent = new Object() {\n" +
		38792	" {\n" +
		38793	" Object o1 = mObj;\n" +
		38794	" }\n" +
		38795	" Object o2 = mObj;\n" +
		38796	" void foo() {\n" +
		38797	" Object o3 = mObj;\n" +
		38798	" }\n" +
		38799	" };\n" +
		38800	" public X() {\n" +
		38801	" mObj = \"\";\n" +
		38802	" }\n" +
		38803	"}\n", // =================
		38804	},
		38805	"----------\n" +
		38806	"1. WARNING in X.java (at line 3)\n" +
		38807	" private final Object mDependent = new Object() {\n" +
		38808	" ^^^^^^^^^^\n" +
		38809	"The field X<T>.mDependent is never read locally\n" +
		38810	"----------\n" +
		38811	"2. WARNING in X.java (at line 5)\n" +
		38812	" Object o1 = mObj;\n" +
		38813	" ^^^^\n" +
		38814	"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		38815	"----------\n" +
		38816	"3. ERROR in X.java (at line 5)\n" +
		38817	" Object o1 = mObj;\n" +
		38818	" ^^^^\n" +
		38819	"The blank final field mObj may not have been initialized\n" +
		38820	"----------\n" +
		38821	"4. WARNING in X.java (at line 7)\n" +
		38822	" Object o2 = mObj;\n" +
		38823	" ^^\n" +
		38824	"The field new Object(){}.o2 is never read locally\n" +
		38825	"----------\n" +
		38826	"5. WARNING in X.java (at line 7)\n" +
		38827	" Object o2 = mObj;\n" +
		38828	" ^^^^\n" +
		38829	"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		38830	"----------\n" +
		38831	"6. ERROR in X.java (at line 7)\n" +
		38832	" Object o2 = mObj;\n" +
		38833	" ^^^^\n" +
		38834	"The blank final field mObj may not have been initialized\n" +
		38835	"----------\n" +
		38836	"7. WARNING in X.java (at line 8)\n" +
		38837	" void foo() {\n" +
		38838	" ^^^^^\n" +
		38839	"The method foo() from the type new Object(){} is never used locally\n" +
		38840	"----------\n" +
		38841	"8. WARNING in X.java (at line 9)\n" +
		38842	" Object o3 = mObj;\n" +
		38843	" ^^^^\n" +
		38844	"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		38845	"----------\n");
		38846	}
		38847	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
38848	public void test1164() {
38849	this.runNegativeTest(
38850	new String[] {
38851	"X.java",
38852	"public final class X<T> {\n" +
38853	" private final Object mObj;\n" +
38854	" private final Object mDependent = new Object() {\n" +
38855	" {\n" +
38856	" Object o1 = mObj;\n" +
38857	" mObj = \"1\";\n" +
38858	" }\n" +
38859	" Object o2 = mObj = \"2\";\n" +
38860	" void foo() {\n" +
38861	" Object o3 = mObj;\n" +
38862	" mObj = \"3\";\n" +
38863	" }\n" +
38864	" };\n" +
38865	" public X() {\n" +
38866	" mObj = \"\";\n" +
38867	" }\n" +
38868	"}\n"
38869	},
38870	"----------\n" +
38871	"1. WARNING in X.java (at line 3)\n" +
38872	" private final Object mDependent = new Object() {\n" +
38873	" ^^^^^^^^^^\n" +
38874	"The field X<T>.mDependent is never read locally\n" +
38875	"----------\n" +
38876	"2. WARNING in X.java (at line 5)\n" +
38877	" Object o1 = mObj;\n" +
38878	" ^^^^\n" +
38879	"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
38880	"----------\n" +
38881	"3. ERROR in X.java (at line 5)\n" +
38882	" Object o1 = mObj;\n" +
38883	" ^^^^\n" +
38884	"The blank final field mObj may not have been initialized\n" +
38885	"----------\n" +
38886	"4. WARNING in X.java (at line 6)\n" +
38887	" mObj = \"1\";\n" +
38888	" ^^^^\n" +
38889	"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
38890	"----------\n" +
38891	"5. ERROR in X.java (at line 6)\n" +
38892	" mObj = \"1\";\n" +
38893	" ^^^^\n" +
38894	"The final field X<T>.mObj cannot be assigned\n" +
38895	"----------\n" +
38896	"6. WARNING in X.java (at line 8)\n" +
38897	" Object o2 = mObj = \"2\";\n" +
38898	" ^^\n" +
38899	"The field new Object(){}.o2 is never read locally\n" +
38900	"----------\n" +
38901	"7. WARNING in X.java (at line 8)\n" +
38902	" Object o2 = mObj = \"2\";\n" +
38903	" ^^^^\n" +
38904	"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
38905	"----------\n" +
38906	"8. ERROR in X.java (at line 8)\n" +
38907	" Object o2 = mObj = \"2\";\n" +
38908	" ^^^^\n" +
38909	"The final field X<T>.mObj cannot be assigned\n" +
38910	"----------\n" +
38911	"9. WARNING in X.java (at line 9)\n" +
38912	" void foo() {\n" +
38913	" ^^^^^\n" +
38914	"The method foo() from the type new Object(){} is never used locally\n" +
38915	"----------\n" +
38916	"10. WARNING in X.java (at line 10)\n" +
38917	" Object o3 = mObj;\n" +
38918	" ^^^^\n" +
38919	"Read access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
38920	"----------\n" +
38921	"11. WARNING in X.java (at line 11)\n" +
38922	" mObj = \"3\";\n" +
38923	" ^^^^\n" +
38924	"Write access to enclosing field X<T>.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
38925	"----------\n" +
38926	"12. ERROR in X.java (at line 11)\n" +
38927	" mObj = \"3\";\n" +
38928	" ^^^^\n" +
38929	"The final field X<T>.mObj cannot be assigned\n" +
38930	"----------\n");
38931	}
38784	}	38932	}

Lines 85-91 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/QualifiedNameReference.java (-3 / +3 lines)
85	// check if final blank field	85	// check if final blank field
86	if (lastFieldBinding.isBlankFinal()	86	if (lastFieldBinding.isBlankFinal()
87	&& this.otherBindings != null // the last field binding is only assigned	87	&& this.otherBindings != null // the last field binding is only assigned
88	&& currentScope.allowBlankFinalFieldAssignment(lastFieldBinding)) {	88	&& currentScope.needBlankFinalFieldInitializationCheck(lastFieldBinding)) {
89	if (!flowInfo.isDefinitelyAssigned(lastFieldBinding)) {	89	if (!flowInfo.isDefinitelyAssigned(lastFieldBinding)) {
90	currentScope.problemReporter().uninitializedBlankFinalField(	90	currentScope.problemReporter().uninitializedBlankFinalField(
91	lastFieldBinding,	91	lastFieldBinding,
Lines 134-140 Link Here
134	if (isCompound) {	134	if (isCompound) {
135	if (otherBindingsCount == 0	135	if (otherBindingsCount == 0
136	&& lastFieldBinding.isBlankFinal()	136	&& lastFieldBinding.isBlankFinal()
137	&& currentScope.allowBlankFinalFieldAssignment(lastFieldBinding)	137	&& currentScope.needBlankFinalFieldInitializationCheck(lastFieldBinding)
138	&& (!flowInfo.isDefinitelyAssigned(lastFieldBinding))) {	138	&& (!flowInfo.isDefinitelyAssigned(lastFieldBinding))) {
139	currentScope.problemReporter().uninitializedBlankFinalField(lastFieldBinding, this);	139	currentScope.problemReporter().uninitializedBlankFinalField(lastFieldBinding, this);
140	}	140	}
Lines 237-243 Link Here
237	}	237	}
238	// check if reading a final blank field	238	// check if reading a final blank field
239	if (fieldBinding.isBlankFinal()	239	if (fieldBinding.isBlankFinal()
240	&& currentScope.allowBlankFinalFieldAssignment(fieldBinding)	240	&& currentScope.needBlankFinalFieldInitializationCheck(fieldBinding)
241	&& !flowInfo.isDefinitelyAssigned(fieldBinding)) {	241	&& !flowInfo.isDefinitelyAssigned(fieldBinding)) {
242	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);	242	currentScope.problemReporter().uninitializedBlankFinalField(fieldBinding, this);
243	}	243	}

Lines 111-118 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java (-2 / +27 lines)
111	this.subscopes[this.subscopeCount++] = childScope;	111	this.subscopes[this.subscopeCount++] = childScope;
112	}	112	}
113		113
114	/* Answer true if the receiver is suitable for assigning final blank fields.	114	/**
115	*	115	* Answer true if the receiver is suitable for assigning final blank fields.
116	* in other words, it is inside an initializer, a constructor or a clinit	116	* in other words, it is inside an initializer, a constructor or a clinit
117	*/	117	*/
118	public final boolean allowBlankFinalFieldAssignment(FieldBinding binding) {	118	public final boolean allowBlankFinalFieldAssignment(FieldBinding binding) {
Lines 125-130 Link Here
125	return methodScope.isInsideInitializer() // inside initializer	125	return methodScope.isInsideInitializer() // inside initializer
126	\|\| ((AbstractMethodDeclaration) methodScope.referenceContext).isInitializationMethod(); // inside constructor or clinit	126	\|\| ((AbstractMethodDeclaration) methodScope.referenceContext).isInitializationMethod(); // inside constructor or clinit
127	}	127	}
		128
128	String basicToString(int tab) {	129	String basicToString(int tab) {
129	String newLine = "\n"; //$NON-NLS-1$	130	String newLine = "\n"; //$NON-NLS-1$
130	for (int i = tab; --i >= 0;)	131	for (int i = tab; --i >= 0;)
Lines 822-827 Link Here
822	return max;	823	return max;
823	}	824	}
824		825
		826	/**
		827	* Returns true if the context requires to check initialization of final blank fields.
		828	* in other words, it is inside an initializer, a constructor or a clinit
		829	*/
		830	public final boolean needBlankFinalFieldInitializationCheck(FieldBinding binding) {
		831	boolean isStatic = binding.isStatic();
		832	ReferenceBinding fieldDeclaringClass = binding.declaringClass;
		833	// loop in enclosing context, until reaching the field declaring context
		834	MethodScope methodScope = methodScope();
		835	while (methodScope != null) {
		836	if (methodScope.isStatic != isStatic)
		837	return false;
		838	if (!methodScope.isInsideInitializer() // inside initializer
		839	&& !((AbstractMethodDeclaration) methodScope.referenceContext).isInitializationMethod()) { // inside constructor or clinit
		840	return false; // found some non-initializer context
		841	}
		842	if (fieldDeclaringClass == methodScope.enclosingReceiverType()) {
		843	return true; // found the field context, no need to check any further
		844	}
		845	methodScope = methodScope.enclosingMethodScope();
		846	}
		847	return false;
		848	}
		849
825	/* Answer the problem reporter to use for raising new problems.	850	/* Answer the problem reporter to use for raising new problems.
826	*	851	*
827	* Note that as a side-effect, this updates the current reference context	852	* Note that as a side-effect, this updates the current reference context

Lines 5473-5478 Link Here

(-)Eclipse Java Tests Compiler/org/eclipse/jdt/tests/compiler/regression/InitializationTest.java (+148 lines)
5473	assertTrue(false);	5473	assertTrue(false);
5474	}	5474	}
5475	}	5475	}
		5476	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061
		5477	public void test192() {
		5478	this.runNegativeTest(
		5479	new String[] {
		5480	"X.java",
		5481	"public final class X {\n" +
		5482	" private final Object mObj;\n" +
		5483	" private final Object mDependent = new Object() {\n" +
		5484	" {\n" +
		5485	" Object o1 = mObj;\n" +
		5486	" }\n" +
		5487	" Object o2 = mObj;\n" +
		5488	" void foo() {\n" +
		5489	" Object o3 = mObj;\n" +
		5490	" }\n" +
		5491	" };\n" +
		5492	" public X() {\n" +
		5493	" mObj = \"\";\n" +
		5494	" }\n" +
		5495	"}\n"
		5496	},
		5497	"----------\n" +
		5498	"1. WARNING in X.java (at line 3)\n" +
		5499	" private final Object mDependent = new Object() {\n" +
		5500	" ^^^^^^^^^^\n" +
		5501	"The field X.mDependent is never read locally\n" +
		5502	"----------\n" +
		5503	"2. WARNING in X.java (at line 5)\n" +
		5504	" Object o1 = mObj;\n" +
		5505	" ^^^^\n" +
		5506	"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		5507	"----------\n" +
		5508	"3. ERROR in X.java (at line 5)\n" +
		5509	" Object o1 = mObj;\n" +
		5510	" ^^^^\n" +
		5511	"The blank final field mObj may not have been initialized\n" +
		5512	"----------\n" +
		5513	"4. WARNING in X.java (at line 7)\n" +
		5514	" Object o2 = mObj;\n" +
		5515	" ^^\n" +
		5516	"The field new Object(){}.o2 is never read locally\n" +
		5517	"----------\n" +
		5518	"5. WARNING in X.java (at line 7)\n" +
		5519	" Object o2 = mObj;\n" +
		5520	" ^^^^\n" +
		5521	"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		5522	"----------\n" +
		5523	"6. ERROR in X.java (at line 7)\n" +
		5524	" Object o2 = mObj;\n" +
		5525	" ^^^^\n" +
		5526	"The blank final field mObj may not have been initialized\n" +
		5527	"----------\n" +
		5528	"7. WARNING in X.java (at line 8)\n" +
		5529	" void foo() {\n" +
		5530	" ^^^^^\n" +
		5531	"The method foo() from the type new Object(){} is never used locally\n" +
		5532	"----------\n" +
		5533	"8. WARNING in X.java (at line 9)\n" +
		5534	" Object o3 = mObj;\n" +
		5535	" ^^^^\n" +
		5536	"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
		5537	"----------\n");
		5538	}
		5539	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=203061 - variation
5540	public void test193() {
5541	this.runNegativeTest(
5542	new String[] {
5543	"X.java",
5544	"public final class X {\n" +
5545	" private final Object mObj;\n" +
5546	" private final Object mDependent = new Object() {\n" +
5547	" {\n" +
5548	" Object o1 = mObj;\n" +
5549	" mObj = \"1\";\n" +
5550	" }\n" +
5551	" Object o2 = mObj = \"2\";\n" +
5552	" void foo() {\n" +
5553	" Object o3 = mObj;\n" +
5554	" mObj = \"3\";\n" +
5555	" }\n" +
5556	" };\n" +
5557	" public X() {\n" +
5558	" mObj = \"\";\n" +
5559	" }\n" +
5560	"}\n"
5561	},
5562	"----------\n" +
5563	"1. WARNING in X.java (at line 3)\n" +
5564	" private final Object mDependent = new Object() {\n" +
5565	" ^^^^^^^^^^\n" +
5566	"The field X.mDependent is never read locally\n" +
5567	"----------\n" +
5568	"2. WARNING in X.java (at line 5)\n" +
5569	" Object o1 = mObj;\n" +
5570	" ^^^^\n" +
5571	"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
5572	"----------\n" +
5573	"3. ERROR in X.java (at line 5)\n" +
5574	" Object o1 = mObj;\n" +
5575	" ^^^^\n" +
5576	"The blank final field mObj may not have been initialized\n" +
5577	"----------\n" +
5578	"4. WARNING in X.java (at line 6)\n" +
5579	" mObj = \"1\";\n" +
5580	" ^^^^\n" +
5581	"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
5582	"----------\n" +
5583	"5. ERROR in X.java (at line 6)\n" +
5584	" mObj = \"1\";\n" +
5585	" ^^^^\n" +
5586	"The final field X.mObj cannot be assigned\n" +
5587	"----------\n" +
5588	"6. WARNING in X.java (at line 8)\n" +
5589	" Object o2 = mObj = \"2\";\n" +
5590	" ^^\n" +
5591	"The field new Object(){}.o2 is never read locally\n" +
5592	"----------\n" +
5593	"7. WARNING in X.java (at line 8)\n" +
5594	" Object o2 = mObj = \"2\";\n" +
5595	" ^^^^\n" +
5596	"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
5597	"----------\n" +
5598	"8. ERROR in X.java (at line 8)\n" +
5599	" Object o2 = mObj = \"2\";\n" +
5600	" ^^^^\n" +
5601	"The final field X.mObj cannot be assigned\n" +
5602	"----------\n" +
5603	"9. WARNING in X.java (at line 9)\n" +
5604	" void foo() {\n" +
5605	" ^^^^^\n" +
5606	"The method foo() from the type new Object(){} is never used locally\n" +
5607	"----------\n" +
5608	"10. WARNING in X.java (at line 10)\n" +
5609	" Object o3 = mObj;\n" +
5610	" ^^^^\n" +
5611	"Read access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
5612	"----------\n" +
5613	"11. WARNING in X.java (at line 11)\n" +
5614	" mObj = \"3\";\n" +
5615	" ^^^^\n" +
5616	"Write access to enclosing field X.mObj is emulated by a synthetic accessor method. Increasing its visibility will improve your performance\n" +
5617	"----------\n" +
5618	"12. ERROR in X.java (at line 11)\n" +
5619	" mObj = \"3\";\n" +
5620	" ^^^^\n" +
5621	"The final field X.mObj cannot be assigned\n" +
5622	"----------\n");
5623	}
5476	public static Class testClass() {	5624	public static Class testClass() {
5477	return InitializationTest.class;	5625	return InitializationTest.class;
5478	}	5626	}