Attachment 77403 Details for Bug 197199 – Renaming a profile now performs commit/delete

[patch] Renaming a profile now performs commit/delete

patch.txt (text/plain), 3.13 KB, created by Kevin Doyle

on 2007-08-30 14:53:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2007-08-30 14:53:00 EDT

Size: 3.13 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.core
>Index: src/org/eclipse/rse/internal/core/model/SystemProfileManager.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/internal/core/model/SystemProfileManager.java,v
>retrieving revision 1.4
>diff -u -r1.4 SystemProfileManager.java
>--- src/org/eclipse/rse/internal/core/model/SystemProfileManager.java	29 May 2007 22:15:53 -0000	1.4
>+++ src/org/eclipse/rse/internal/core/model/SystemProfileManager.java	30 Aug 2007 18:21:23 -0000
>@@ -13,6 +13,7 @@
>  * Contributors:
>  * David Dykstal (IBM) - created and used RSEPreferencesManager
>  *                     - moved SystemPreferencesManager to a new plugin
>+ * Kevin Doyle (IBM) - [197199] Renaming a Profile doesn't cause a save
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.core.model;
>@@ -173,9 +174,13 @@
> 		boolean isActive = isSystemProfileActive(profile.getName());
> 		String oldName = profile.getName();
> 		profile.setName(newName);
>-		if (isActive) RSEPreferencesManager.renameActiveProfile(oldName, newName);
>-//		invalidateCache();
>-		// FIXME RSEUIPlugin.getThePersistenceManager().save(this);
>+		if (isActive) {
>+			RSEPreferencesManager.renameActiveProfile(oldName, newName);
>+		}
>+		// Commit the profile to reflect the name change
>+		RSECorePlugin.getThePersistenceManager().commitProfile(profile, 5000);
>+		// Delete the profile by the old name, which is done in a separate job.
>+		RSECorePlugin.getThePersistenceManager().deleteProfile(profile.getPersistenceProvider(), oldName);
> 	}
> 
> 	/* (non-Javadoc)
>Index: src/org/eclipse/rse/internal/persistence/dom/RSEDOMExporter.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/internal/persistence/dom/RSEDOMExporter.java,v
>retrieving revision 1.10
>diff -u -r1.10 RSEDOMExporter.java
>--- src/org/eclipse/rse/internal/persistence/dom/RSEDOMExporter.java	30 Aug 2007 17:13:10 -0000	1.10
>+++ src/org/eclipse/rse/internal/persistence/dom/RSEDOMExporter.java	30 Aug 2007 18:21:23 -0000
>@@ -14,6 +14,7 @@
>  * Martin Oberhuber (Wind River) - [175262] IHost.getSystemType() should return IRSESystemType 
>  * Martin Oberhuber (Wind River) - [184095] Replace systemTypeName by IRSESystemType
>  * Kevin Doyle (IBM) - [163883] Multiple filter strings are disabled
>+ * Kevin Doyle (IBM) - [197199] Renaming a Profile doesn't cause a save
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.persistence.dom;
>@@ -104,6 +105,8 @@
> 		}
> 
> 		if (clean || profile.isDirty() || dom.isDirty()) {
>+			// Doing a rename requires the dom to update it's name
>+			dom.setName(profile.getName());
> 			dom.clearAttributes();
> 			dom.addAttribute(IRSEDOMConstants.ATTRIBUTE_DEFAULT_PRIVATE, getBooleanString(profile.isDefaultPrivate()));
> 			dom.addAttribute(IRSEDOMConstants.ATTRIBUTE_IS_ACTIVE, getBooleanString(profile.isActive()));

Flags:

mober.at+eclipse: iplog+

Actions: View | Diff

Attachments on bug 197199: 77403