Attachment 74036 Details for Bug 196919 – Patch to RSEPersistenceManager fixing the issue

[patch] Patch to RSEPersistenceManager fixing the issue

patch196919_deadlock.diff.txt (text/plain), 1.73 KB, created by Martin Oberhuber

on 2007-07-18 04:52:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Oberhuber

Created: 2007-07-18 04:52:57 EDT

Size: 1.73 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.core
>Index: src/org/eclipse/rse/internal/persistence/RSEPersistenceManager.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/internal/persistence/RSEPersistenceManager.java,v
>retrieving revision 1.12
>diff -u -r1.12 RSEPersistenceManager.java
>--- src/org/eclipse/rse/internal/persistence/RSEPersistenceManager.java	12 Jul 2007 19:58:31 -0000	1.12
>+++ src/org/eclipse/rse/internal/persistence/RSEPersistenceManager.java	18 Jul 2007 08:51:16 -0000
>@@ -15,6 +15,7 @@
>  * Martin Oberhuber (Wind River) - [184095] Replace systemTypeName by IRSESystemType
>  * Martin Oberhuber (Wind River) - [177523] Unify singleton getter methods
>  * Martin Oberhuber (Wind River) - [175680] Deprecate obsolete ISystemRegistry methods
>+ * Martin Oberhuber (Wind River) - [196919] Fix deadlock with workspace operations
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.persistence;
>@@ -94,7 +95,7 @@
> 	/* (non-Javadoc)
> 	 * @see org.eclipse.rse.persistence.IRSEPersistenceManager#isExporting()
> 	 */
>-	public synchronized boolean isBusy() {
>+	public boolean isBusy() {
> 		return mutex.isLocked();
> 	}
> 
>@@ -382,7 +383,7 @@
> 	 * @param profileName the name of the profile to produce
> 	 * @return the profile or null
> 	 */
>-	private synchronized ISystemProfile load(IRSEPersistenceProvider provider, String profileName, long timeout) {
>+	private ISystemProfile load(IRSEPersistenceProvider provider, String profileName, long timeout) {
> 		ISystemProfile profile = null;
> 		if (mutex.waitForLock(null, timeout)) {
> 			try {

Actions: View | Diff

Attachments on bug 196919: 74035 | 74036