Attachment 73033 Details for Bug 195392 – Patch removing the setPort(0) call

[patch] Patch removing the setPort(0) call

patch195392_initializeSubSystem.diff.txt (text/plain), 2.60 KB, created by Martin Oberhuber

on 2007-07-04 11:04:52 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Oberhuber

Created: 2007-07-04 11:04:52 EDT

Size: 2.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java,v
>retrieving revision 1.62
>diff -u -r1.62 SubSystemConfiguration.java
>--- subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java	4 Jun 2007 22:43:23 -0000	1.62
>+++ subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java	4 Jul 2007 15:05:00 -0000
>@@ -1164,15 +1164,15 @@
> 	public abstract ISubSystem createSubSystemInternal(IHost conn);
> 
> 	/**
>-	 * Overridable method to initialize subsystems after creation. The default behaviour here is to
>-	 * set the subsystem's port property to 0, and to add to it a reference to the default filter pool for this
>-	 * subsystem configuration, if there is one. Typically subclasses call <samp>super().initializeSubSystem(...)</samp>
>-	 * to get this default behaviour, then extend it.
>+	 * Initialize subsystems after creation (Overridable).
>+	 * The default behavior is to add a reference to the default filter pool for this subsystem configuration,
>+	 * if there is one. Typically subclasses call <samp>super().initializeSubSystem(...)</samp>
>+	 * to get this default behavior, then extend it.
> 	 * 
>-	 * The reason for the connect wizard pages parm is in case your subsystem configuration contributes a page to that wizard,
>+	 * The reason for the connect wizard pages parameter is in case your subsystem configuration contributes a page to that wizard,
> 	 * whose values are needed to set the subsystem's initial state. For example, you might decide to add a 
> 	 * page to the connection wizard to prompt for a JDBC Driver name. If so, when this method is called at 
>-	 * the time a new connection is created apres the wizard, your page will have the user's value. You can
>+	 * the time a new connection is created after the wizard, your page will have the user's value. You can
> 	 * thus use it here to initialize that subsystem property. Be use to use instanceof to find your particular
> 	 * page. 
> 	 * 
>@@ -1187,11 +1187,6 @@
> 	 */
> 	protected void initializeSubSystem(ISubSystem ss, ISystemNewConnectionWizardPage[] yourNewConnectionWizardPages)
> 	{
>-		IConnectorService connectorService = ss.getConnectorService();
>-		if (connectorService != null)
>-		{
>-			connectorService.setPort(0);
>-		}
> 		if (supportsFilters())
> 		{
> 			// --------------------------------------------

Actions: View | Diff

Attachments on bug 195392: 73033