Attachment 72801 Details for Bug 194463 – Check the result of _editable.download(monitor) to decide if editor should be opened

[patch] Check the result of _editable.download(monitor) to decide if editor should be opened

patch.txt (text/plain), 1.64 KB, created by Kevin Doyle

on 2007-06-29 17:22:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2007-06-29 17:22:27 EDT

Size: 1.64 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.files.ui
>Index: src/org/eclipse/rse/internal/files/ui/view/DownloadJob.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/DownloadJob.java,v
>retrieving revision 1.3
>diff -u -r1.3 DownloadJob.java
>--- src/org/eclipse/rse/internal/files/ui/view/DownloadJob.java	5 Jun 2007 10:54:42 -0000	1.3
>+++ src/org/eclipse/rse/internal/files/ui/view/DownloadJob.java	29 Jun 2007 21:13:33 -0000
>@@ -12,7 +12,7 @@
>  * Emily Bruner, Mazen Faraj, Adrian Storisteanu, Li Ding, and Kent Hawley.
>  * 
>  * Contributors:
>- * {Name} (company) - description of contribution.
>+ * Kevin Doyle (IBM) - [194463] Use the result of _editable.download() to decide if file is to be opened
>  *******************************************************************************/
> 
> package org.eclipse.rse.internal.files.ui.view;
>@@ -80,18 +80,19 @@
> 
> 	public IStatus run(IProgressMonitor monitor) 
> 	{
>+		boolean downloadSuccessful = false;
> 		try
> 		{
> 			IFile localFile = _editable.getLocalResource();
> 			SystemUniversalTempFileListener listener = SystemUniversalTempFileListener.getListener();
> 			listener.addIgnoreFile(localFile);
>-			_editable.download(monitor);
>+			downloadSuccessful = _editable.download(monitor);
> 			listener.removeIgnoreFile(localFile);
> 		}
> 		catch (Exception e)
> 		{				
> 		}
>-		if (!monitor.isCanceled())
>+		if (downloadSuccessful)
> 		{
> 			OpenEditorRunnable oe = new OpenEditorRunnable(_editable, _systemEditor);
> 			Display.getDefault().asyncExec(oe);

Flags:

mober.at+eclipse: iplog+

Actions: View | Diff

Attachments on bug 194463: 72801