Attachment 71305 Details for Bug 192497 – Proposed fix

[patch] Proposed fix

bug192497_001.txt (text/plain), 2.26 KB, created by David Audel

on 2007-06-14 09:17:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2007-06-14 09:17:05 EDT

Size: 2.26 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/model/ResolveTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests.java,v
>retrieving revision 1.74
>diff -u -r1.74 ResolveTests.java
>--- src/org/eclipse/jdt/core/tests/model/ResolveTests.java	6 Apr 2007 11:07:11 -0000	1.74
>+++ src/org/eclipse/jdt/core/tests/model/ResolveTests.java	14 Jun 2007 12:54:28 -0000
>@@ -2115,4 +2115,26 @@
> 		elements
> 	);
> }
>+//https://bugs.eclipse.org/bugs/show_bug.cgi?id=192497
>+public void testSelectOnCursor1() throws JavaModelException {
>+	ICompilationUnit cu = getWorkingCopy(
>+			"/Resolve/src/AType.java",
>+			"public class AType {\n" +
>+			"  public void doLoad(){}\n" +
>+			"  public void foo() {\n" +
>+			"    doLoad();\n" +
>+			"  }\n" +
>+			"}\n");
>+	
>+	String str = cu.getSource();
>+	// perform code select between 'd' and 'o'
>+	int start = str.indexOf("oLoad();");
>+	int length = 0;
>+	IJavaElement[] elements = cu.codeSelect(start, length);
>+	assertElementsEqual(
>+		"Unexpected elements",
>+		"doLoad() [in AType [in [Working copy] AType.java [in <default> [in src [in Resolve]]]]]",
>+		elements
>+	);
>+}
> }
>#P org.eclipse.jdt.core
>Index: codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java,v
>retrieving revision 1.137
>diff -u -r1.137 SelectionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java	27 Apr 2007 15:51:39 -0000	1.137
>+++ codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java	14 Jun 2007 12:54:30 -0000
>@@ -341,8 +341,8 @@
> 		int token;
> 		
> 		if(selectionStart > selectionEnd){
>-			// compute end position of the selection
>-			int end = selectionEnd + 1 == source.length ? selectionEnd : selectionEnd + 1;
>+//			int end = selectionEnd + 1 == source.length ? selectionEnd : selectionEnd + 1;
>+			int end = source.length - 1;
> 			
> 			// compute start position of current line
> 			int currentPosition = selectionStart - 1;

Actions: View | Diff

Attachments on bug 192497: 71305 | 72945 | 72946