Attachment 6145 Details for Bug 43033 – Minor fix to avoid the NPE

[patch] Minor fix to avoid the NPE

patch.txt (text/plain), 1.30 KB, created by Andrew Clement

on 2003-09-18 11:59:39 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Clement

Created: 2003-09-18 11:59:39 EDT

Size: 1.30 KB

patch

obsolete

>Index: src/org/aspectj/weaver/patterns/ReferencePointcut.java
>===================================================================
>RCS file: /home/technology/org.aspectj/modules/weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java,v
>retrieving revision 1.12
>diff -u -r1.12 ReferencePointcut.java
>--- src/org/aspectj/weaver/patterns/ReferencePointcut.java	9 Sep 2003 23:47:55 -0000	1.12
>+++ src/org/aspectj/weaver/patterns/ReferencePointcut.java	18 Sep 2003 15:56:32 -0000
>@@ -28,7 +28,9 @@
> import org.aspectj.weaver.ResolvedPointcutDefinition;
> import org.aspectj.weaver.ResolvedTypeX;
> import org.aspectj.weaver.Shadow;
>+import org.aspectj.weaver.ShadowMunger;
> import org.aspectj.weaver.TypeX;
>+import org.aspectj.weaver.World;
> import org.aspectj.weaver.ast.Test;
> 
> /**
>@@ -240,9 +242,11 @@
> 			
> 			if (pointcutDec.isAbstract()) {
> 				//Thread.currentThread().dumpStack();
>+				ShadowMunger enclosingAdvice = bindings.getEnclosingAdvice();
> 				searchStart.getWorld().showMessage(IMessage.ERROR,
> 					pointcutDec + " is abstract", 
>-					getSourceLocation(), bindings.getEnclosingAdvice().getSourceLocation());
>+					getSourceLocation(), 
>+					(enclosingAdvice==null?null:enclosingAdvice.getSourceLocation()));
> 				return Pointcut.makeMatchesNothing(Pointcut.CONCRETE);
> 			}
>

Flags:

aclement: iplog+

Actions: View | Diff

Attachments on bug 43033: 6145