Attachment 60253 Details for Bug 147461 – Suggested fix

[patch] Suggested fix

patch.txt (text/plain), 3.59 KB, created by Maxime Daniel

on 2007-03-05 06:01:24 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Maxime Daniel

Created: 2007-03-05 06:01:24 EST

Size: 3.59 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java,v
>retrieving revision 1.107
>diff -u -r1.107 BatchCompilerTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java	2 Mar 2007 10:45:24 -0000	1.107
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java	5 Mar 2007 10:55:02 -0000
>@@ -949,7 +949,7 @@
>         "                       Each directory or file can specify access rules for\n" +
>         "                       types between ''['' and '']'' (e.g. [-X] to forbid\n" +
>         "                       access to type X, [~X] to discourage access to type X,\n" +
>-        "                       [+p/X:-p/*] to forbid access to all types in package p\n" +
>+        "                       [+p/X" + File.pathSeparator + "-p/*] to forbid access to all types in package p\n" +
>         "                       but allow access to p/X)\n" +
>         "    -bootclasspath <directories and zip/jar files separated by " + File.pathSeparator + ">\n" +
>         "                       specify location for system classes. Each directory or\n" +
>@@ -3200,10 +3200,13 @@
> 		true);
> }
> // https://bugs.eclipse.org/bugs/show_bug.cgi?id=147461
>-public void _test057_access_restrictions_separator(){
>+// the compilation is successful because we do not check the classpath entries
>+// given in the rules; accordingly OK<sep>-KO is seen as a directory that is
>+// added to positive rules, and the compilation completes normally
>+public void test057_access_restrictions_separator(){
> 	String oppositeSeparator = File.pathSeparatorChar == ':' ?
> 			";" : ":";
>-	this.runNegativeTest(
>+	this.runConformTest(
> 		new String[] {
> 			"X.java",
> 			"/** */\n" +
>@@ -3230,10 +3233,10 @@
> 		},
>         "\"" + OUTPUT_DIR +  File.separator + "X.java\""
>         + " -1.5 -g -preserveAllLocals"
>-        + " -cp \"" + OUTPUT_DIR + "[+OK2" + oppositeSeparator + "-KO]"
>+        + " -cp \"" + OUTPUT_DIR + "[+OK2" + oppositeSeparator + "-KO]\""
>         + " -proceedOnError -referenceInfo -d \"" + OUTPUT_DIR + "\"",
>         "",
>-        "ERR: invalid spec",
>+        "",
>         true);
> }
> 
>#P org.eclipse.jdt.core
>Index: batch/org/eclipse/jdt/internal/compiler/batch/messages.properties
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/messages.properties,v
>retrieving revision 1.606
>diff -u -r1.606 messages.properties
>--- batch/org/eclipse/jdt/internal/compiler/batch/messages.properties	27 Feb 2007 16:09:12 -0000	1.606
>+++ batch/org/eclipse/jdt/internal/compiler/batch/messages.properties	5 Mar 2007 10:55:10 -0000
>@@ -110,7 +110,7 @@
> \                       Each directory or file can specify access rules for\n\
> \                       types between ''['' and '']'' (e.g. [-X] to forbid\n\
> \                       access to type X, [~X] to discourage access to type X,\n\
>-\                       [+p/X:-p/*] to forbid access to all types in package p\n\
>+\                       [+p/X{0}-p/*] to forbid access to all types in package p\n\
> \                       but allow access to p/X)\n\
> \    -bootclasspath <directories and zip/jar files separated by {0}>\n\
> \                       specify location for system classes. Each directory or\n\

Actions: View | Diff

Attachments on bug 147461: 60253