Attachment #60059 for bug #175570




		"1. ERROR in X.java (at line 7)\n" + 
		"	}while(a!=null);\n" + 
		"	       ^\n" + 
		"Redundant null check: The variable a cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 9)\n" + 
		"	if(a!=null)\n" + 
		"	   ^\n" + 
		"Null comparison always yields false: The variable a can only be null at this location\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 13)\n" + 
		"	System.out.println(a+b);\n" + 

		"1. ERROR in X.java (at line 7)\n" + 
		"	} while (o != null);\n" + 
		"	         ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}
//https://bugs.eclipse.org/bugs/show_bug.cgi?id=93588




	    "1. ERROR in X.java (at line 4)\n" + 
	    "	o.toString();\n" + 
	    "	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
	    "----------\n");
}
  

		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}
 

		"1. ERROR in X.java (at line 5)\n" + 
		"	x.m.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	System.out.println(x.m);\n" + 
		"	                   ^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	x.m = new Object();\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}


			"1. ERROR in X.java (at line 4)\n" + 
			"	i += 1;\n" + 
			"	^\n" + 
			"Null pointer access: The variable i can only be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 4)\n" + 
			"	i++;\n" + 
			"	^\n" + 
			"Null pointer access: The variable i can only be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 4)\n" + 
			"	if (i == null) {};\n" + 
			"	    ^\n" + 
			"Null comparison always yields false: The variable i cannot be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 4)\n" + 
			"	System.out.println(i + 4);\n" + 
			"	                   ^\n" + 
			"Null pointer access: The variable i can only be null at this location\n" + 
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 4)\n" + 
			"	if (i == null) {}\n" + 
			"	    ^\n" + 
			"Null comparison always yields false: The variable i cannot be null at this location\n" + 
			"----------\n");
	}
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	args[0].toString();\n" + 
		"	^^^^\n" + 
		"Null pointer access: The variable args can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) {};\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" +  
		"----------\n");
} 


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) {/* empty */}\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) {/* empty */}\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 4)\n" + 
		"	(o = null).toString();\n" + 
		"	^^^^^^^^^^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null)  { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" +  
		"----------\n");
}  


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (c == null) {};\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable c cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 3)\n" + 
		"	if (o1 != null && (o2 = o1) != null) { /* */ }\n" + 
		"	                  ^^^^^^^^^\n" + 
		"Redundant null check: The variable o2 cannot be null at this location\n" +  
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 3)\n" + 
		"	while (o1 != null && (o2 = o1) != null) { /* */ }\n" + 
		"	                     ^^^^^^^^^\n" + 
		"Redundant null check: The variable o2 cannot be null at this location\n" +  
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 3)\n" + 
		"	if (o == null || o == null) {\n" + 
		"	                 ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 3)\n" + 
		"	if (o == null && o == null) {\n" + 
		"	                 ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	|| (i1.byteValue() == i2.byteValue());\n" + 
		"	    ^^\n" + 
		"Potential null pointer access: The variable i1 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	|| (i1.byteValue() == i2.byteValue());\n" + 
		"	    ^^\n" + 
		"Potential null pointer access: The variable i1 may be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 4)\n" + 
		"	|| (i1.byteValue() == i2.byteValue());\n" + 
		"	                      ^^\n" + 
		"Potential null pointer access: The variable i2 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o instanceof X) { /* */ }\n" + 
		"	    ^\n" + 
		"instanceof always yields false: The variable o can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (x == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	|| x == null) {\n" + 
		"	   ^\n" + 
		"Null comparison always yields false: The variable x cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	return s1.toString();\n" + 
		"	       ^^\n" + 
		"Potential null pointer access: The variable s1 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 10)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 11)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}   


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}
 

		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 20)\n" + 
		"	s.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable s may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	s1.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable s1 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	s2.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable s2 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o1.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable o1 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o1.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable o1 may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	while (o.toString() != null) {/* */}\n" + 
		"	       ^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	while (o != null) {/* */}\n" + 
		"	       ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	while (dummy || o != null) { /* */ }\n" + 
		"	                ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();      o = null;\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 10)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	x.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o != null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 9)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
} 


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
} 


		"");
} 

// null analysis -- while nested hits CAN_ONLY_NON_NULL
public void test0459_while_nested() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public class X {\n" + 
			"  void foo(boolean b) {\n" + 
			"    Object o = b ? null : new Object(),\n" + 
			"           u = new Object(),\n" + 
			"           v = new Object();\n" + 
			"    while (o != null) {\n" + 
			"      while (b) {\n" + 
			"        if (v == null) {\n" +
			"          o = new Object();\n" +
			"        };\n" +
			"        while (o == null) {\n" +
			"          if (u == null) {\n" +
			"            v = null;\n" +
			"          };\n" +
			"          u = null;\n" +
			"        }\n" +
			"      }\n" +
			"    }\n" +
			"  }\n" + 
			"}\n"},
		"----------\n" + 
		"1. ERROR in X.java (at line 11)\r\n" + 
		"	while (o == null) {\r\n" + 
		"	       ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}

// null analysis -- try/finally
public void test0500_try_finally() {
	this.runConformTest(

		"1. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n" // because finally assigns to null 
	);
}

		"1. ERROR in X.java (at line 5)\n" + 
		"	x = null;\n" + 
		"	^\n" + 
		"Redundant assignment: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (x != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o2.toString();\n" + 
		"	^^\n" + 
		"Null pointer access: The variable o2 can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	x.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable x may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 28)\n" + 
		"	x.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable x may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 10)\n" + 
		"	if(t.bar()) {\n" + 
		"	   ^\n" + 
		"Null pointer access: The variable t can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 10)\n" + 
		"	if(t == null ? false : (t == null ? false : t.bar())) {\n" + 
		"	                        ^\n" + 
		"Null comparison always yields false: The variable t cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 10)\n" + 
		"	if(t != null ? false : (t == null ? false : t.bar())) {\n" + 
		"	                        ^\n" + 
		"Redundant null check: The variable t can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\r\n" + 
		"	o.toString();\r\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 12)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 12)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (x != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	if (y != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable y can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	o2.toString();\n" + 
		"	^^\n" + 
		"Null pointer access: The variable o2 can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	x.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable x may be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 9)\n" + 
		"	y.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable y can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (x != null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable x cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 10)\n" + 
		"	y.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable y can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 15)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


//		"1. ERROR in X.java (at line 10)\n" + 
//		"	if (o != null) {\n" + 
//		"	    ^\n" + 
//		"Redundant null check: The variable o can only be null at this location\n" + 
//		"----------\n"
	);
}

		"1. ERROR in X.java (at line 9)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 12)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
//		"Null pointer access: The variable o can only be null at this location\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" +
		// conservative flow analysis softens the error
		"----------\n");
}

		"1. ERROR in X.java (at line 12)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
//		"Null pointer access: The variable o can only be null at this location\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" +
		// conservative flow analysis softens the error
		"----------\n");
}

		"1. ERROR in X.java (at line 19)\n" + 
		"	if (c == null) { // should complain: c can only be null\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable c can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 20)\n" + 
		"	if (ex == null) {\n" + 
		"	    ^^\n" + 
		"Null comparison always yields false: The variable ex cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	while (o.toString() != null);\n" + 
		"	       ^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	while (o != null);\n" + 
		"	       ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	while (o == null);\n" + 
		"	       ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	while (dummy || o != null);\n" + 
		"	                ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	for (;o.toString() != null;) {/* */}\n" + 
		"	      ^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	for (;o != null;) {/* */}\n" + 
		"	      ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 3)\n" + 
		"	for (;o == null; o.toString()) {\n" + 
		"	                 ^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 3)\n" + 
		"	for (o.toString(); o == null;) { /* */ }\n" + 
		"	                   ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	for (o.toString(); bar();) {\n" + 
		"	     ^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


			"1. ERROR in X.java (at line 4)\n" + 
			"	for (Object o : t) {/* */}\n" + 
			"	                ^\n" + 
			"Null pointer access: The variable t can only be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 4)\n" + 
			"	for (Object o : i) {/* */}\n" + 
			"	                ^\n" + 
			"Null pointer access: The variable i can only be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 8)\n" + 
			"	flag.toString();\n" + 
			"	^^^^\n" + 
			"Potential null pointer access: The variable flag may be null at this location\n" + 
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 6)\n" + 
			"	flag.toString();\n" + 
			"	^^^^\n" + 
			"Null pointer access: The variable flag can only be null at this location\n" +  
			"----------\n");
	}
}

			"1. ERROR in X.java (at line 7)\n" + 
			"	flag.toString();\n" + 
			"	^^^^\n" + 
			"Potential null pointer access: The variable flag may be null at this location\n" + 
			"----------\n");
	}
}

		"1. ERROR in X.java (at line 5)\n" + 
		"	flag.toString();\n" + 
		"	^^^^\n" + 
		"Null pointer access: The variable flag can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}
	

		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}
	

		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	if (o != null) { /* */ }\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 11)\n" + 
		"	if (b.booleanValue()) {\n" + 
		"	    ^\n" + 
		"Null pointer access: The variable b can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 12)\n" + 
		"	if(o == null) { /* */ }\n" + 
		"	   ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 15)\n" + 
		"	if(o != null) { /* */ }\n" + 
		"	   ^\n" + 
		"Redundant null check: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	o/*N N*/.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 10)\n" + 
		"	o/*NNa*/.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 14)\n" + 
		"	o/*aNN */.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"4. ERROR in X.java (at line 18)\n" + 
		"	o/*NON NULL*/.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"5. ERROR in X.java (at line 22)\n" + 
		"	o/*Non-Null*/.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n" + 
		"6. ERROR in X.java (at line 26)\n" + 
		"	o/*aNON-NULL */.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();/*NN*/\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	/*NN*/o.toString();\n" + 
		"	      ^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n");
	}
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
	}
}

				"    if (o2 == null) { };\n" + 		// complain
				"  }\n" + 
				"}\n"},
			"----------\n" + 
			"1. ERROR in X.java (at line 4)\n" + 
			"	if (o1 == null) { };\n" + 
			"	    ^^\n" + 
			"Null comparison always yields false: The variable o1 cannot be null at this location\n" + 
			"----------\n" + 
			"2. ERROR in X.java (at line 5)\n" + 
			"	if (o2 == null) { };\n" + 
			"	    ^^\n" + 
			"Redundant null check: The variable o2 can only be null at this location\n" + 
			"----------\n");
	}
}


		"1. ERROR in X.java (at line 4)\n" + 
		"	if (o == null) { };\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
	}
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	assert(o != null);\n" + 
		"	       ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 5)\n" + 
		"	if (o == null) { };\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
	}
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	if (x != null) { // 1\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable x cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 5)\n" + 
		"	if (x == null) { // 2\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x cannot be null at this location\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 6)\n" + 
		"	x.foo(null); // 3\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n" + 
		"4. ERROR in X.java (at line 9)\n" + 
		"	} else if (x != null) { // 6\n" + 
		"	           ^\n" + 
		"Redundant null check: The variable x cannot be null at this location\n" + 
		"----------\n" + 
		"5. ERROR in X.java (at line 12)\n" + 
		"	x.foo(null); // 8\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable x may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 22)\n" + 
		"	if (c == null) {// should complain: c can only be null\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable c can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 9)\n" + 
		"	if (other != null) {\n" + 
		"	    ^^^^^\n" + 
		"Redundant null check: The variable other cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n"
	);
}

		"1. ERROR in X.java (at line 4)\n" + 
		"	if (x == null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 5)\n" + 
		"	x.foo(this);\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	x.foo(null);\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable x may be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	x = null;\n" + 
		"	^\n" + 
		"Redundant assignment: The variable x can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 7)\n" + 
		"	if (x != null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 8)\n" + 
		"	x.foo(null);\n" + 
		"	^\n" + 
		"Null pointer access: The variable x can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 6)\r\n" + 
		"	if (o != null) return;\r\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 7)\r\n" + 
		"	o = null;\r\n" + 
		"	^\n" + 
		"Redundant assignment: The variable o can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\n" + 
		"	if (o == null) return;\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 13)\n" + 
		"	if (progressJob == null) {\n" + 
		"	    ^^^^^^^^^^^\n" + 
		"Redundant null check: The variable progressJob can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 10)\n" + 
		"	if (o == null) return;\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (a == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable a can only be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	if (a == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable a can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 13)\n" + 
		"	if (a == null) {\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable a cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 5)\n" + 
		"	while (o1 != null && (o3 = o1) != null) {\n" + 
		"	       ^^\n" + 
		"Redundant null check: The variable o1 cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 5)\n" + 
		"	while (o1 != null && (o3 = o1) != null) {\n" + 
		"	                     ^^^^^^^^^\n" + 
		"Redundant null check: The variable o3 cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	}while(a!=null);\n" + 
		"	       ^\n" + 
		"Redundant null check: The variable a cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	if(a!=null)\n" + 
		"	   ^\n" + 
		"Null comparison always yields false: The variable a can only be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 7)\n" + 
		"	} while (o != null);\n" + 
		"	         ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\n" + 
		"	if (o == null) {\n" + 
		"	    ^\n" + 
		"Redundant null check: The variable o can only be null at this location\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=170704

		"1. ERROR in X.java (at line 4)\r\n" + 
		"	if (o != null) {\r\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 8)\r\n" + 
		"	o.toString();\r\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 9)\r\n" + 
		"	p.toString();\r\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable p may be null at this location\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=170704

		"1. ERROR in X.java (at line 8)\r\n" + 
		"	o.toString();\r\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n",
		null /* no extra class libraries */, 
		true /* flush output directory */, 

		"1. ERROR in X.java (at line 4)\r\n" + 
		"	if (o != null) {\r\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 8)\r\n" + 
		"	o.toString();\r\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n",
		null /* no extra class libraries */, 
		true /* flush output directory */, 

		"1. ERROR in X.java (at line 4)\r\n" + 
		"	if (o != null) {\r\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o can only be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 9)\r\n" + 
		"	p.toString();\r\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable p may be null at this location\n" + 
		"----------\n",
		null /* no extra class libraries */, 
		true /* flush output directory */, 

		"1. ERROR in X.java (at line 9)\r\n" + 
		"	o.toString();\r\n" + 
		"	^\n" + 
		"Null pointer access: The variable o can only be null at this location\n" + 
		"----------\n",
		null /* no extra class libraries */, 
		true /* flush output directory */, 

		"1. ERROR in X.java (at line 5)\n" + 
		"	if (o instanceof String) {};\n" + 
		"	    ^\n" + 
		"instanceof always yields false: The variable o can only be null at this location\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=170704

		"1. ERROR in X.java (at line 18)\n" + 
		"	if (o65 == null) { /* */ }\n" + 
		"	    ^^^\n" + 
		"Null comparison always yields false: The variable o65 cannot be null at this location\n" +  
		"----------\n");
}


		"1. ERROR in X.java (at line 20)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 21)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 24)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 24)\n" + 
		"	if (o == null) { /* */ }\n" + 
		"	    ^\n" + 
		"Null comparison always yields false: The variable o cannot be null at this location\n" + 
		"----------\n");
}


		"1. ERROR in X.java (at line 15)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"2. ERROR in X.java (at line 18)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"2. ERROR in X.java (at line 18)\n" + 
		"	o.toString();\n" + 
		"	^\n" + 
		"Potential null pointer access: The variable o may be null at this location\n" + 
		"----------\n");
}


		"2. ERROR in X.java (at line 26)\n" + 
		"	o1.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable o1 may be null at this location\n" + 
		"----------\n");
}
}




 *                                 TypeHidingTypeParameterFromType
 *                                 TypeHidingTypeParameterFromMethod
 *                                 TypeHidingType
 *     IBM Corporation - added the following constants
 *								   NullLocalVariableReference
 *								   PotentialNullLocalVariableReference
 *								   RedundantNullCheckOnNullLocalVariable
 * 								   NullLocalVariableComparisonYieldsFalse
 * 								   RedundantLocalVariableNullAssignment
 * 								   NullLocalVariableInstanceofYieldsFalse
 * 								   RedundantNullCheckOnNonNullLocalVariable
 * 								   NonNullLocalVariableComparisonYieldsFalse
 *******************************************************************************/
package org.eclipse.jdt.core.compiler;
 

	// local variable related problems
	int DuplicateModifierForVariable = MethodRelated + 395;
	int IllegalModifierForVariable = MethodRelated + 396;
	/** @deprecated - problem is no longer generated, use {@link #RedundantNullCheckOnNonNullLocalVariable} instead */
	int LocalVariableCannotBeNull = Internal + 397; // since 3.3: semantics are LocalVariableRedundantCheckOnNonNull
	/** @deprecated - problem is no longer generated, use {@link #NullLocalVariableReference}, {@link #RedundantNullCheckOnNullLocalVariable} or {@link #RedundantLocalVariableNullAssignment} instead */
	int LocalVariableCanOnlyBeNull = Internal + 398; // since 3.3: split with LocalVariableRedundantCheckOnNull depending on context
	/** @deprecated - problem is no longer generated, use {@link #PotentialNullLocalVariableReference} instead */
	/** @since 3.2 */
	int LocalVariableMayBeNull = Internal + 399;
	/** @since 3.3 */
	int LocalVariableRedundantCheckOnNull = Internal + 392;

	// method verifier problems
	int AbstractMethodMustBeImplemented = MethodRelated + 400;

	int UseEnumAsAnIdentifier = Internal + 441;
	/** @since 3.2 */
	int EnumConstantsCannotBeSurroundedByParenthesis = Syntax + Internal + 442;

	// detected task
	/** @since 2.1 */
	int Task = Internal + 450;
	
	// local variables related problems, cont'd
	/** @since 3.3 */
	int NullLocalVariableReference = Internal + 451;
	/** @since 3.3 */
	int PotentialNullLocalVariableReference = Internal + 452;
	/** @since 3.3 */
	int RedundantNullCheckOnNullLocalVariable = Internal + 453;
	/** @since 3.3 */
	int NullLocalVariableComparisonYieldsFalse = Internal + 454;
	/** @since 3.3 */
	int RedundantLocalVariableNullAssignment = Internal + 455;
	/** @since 3.3 */
	int NullLocalVariableInstanceofYieldsFalse = Internal + 456;
	/** @since 3.3 */
	int RedundantNullCheckOnNonNullLocalVariable = Internal + 457;
	/** @since 3.3 */
	int NonNullLocalVariableComparisonYieldsFalse = Internal + 458;

	// block
	/** @since 3.0 */
	int UndocumentedEmptyBlock = Internal + 460;

Lines 36-56 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/EqualExpression.java (-4 / +9 lines)
36	private void checkVariableComparison(BlockScope scope, FlowContext flowContext, FlowInfo flowInfo, FlowInfo initsWhenTrue, FlowInfo initsWhenFalse, LocalVariableBinding local, int nullStatus, Expression reference) {	36	private void checkVariableComparison(BlockScope scope, FlowContext flowContext, FlowInfo flowInfo, FlowInfo initsWhenTrue, FlowInfo initsWhenFalse, LocalVariableBinding local, int nullStatus, Expression reference) {
37	switch (nullStatus) {	37	switch (nullStatus) {
38	case FlowInfo.NULL :	38	case FlowInfo.NULL :
39	flowContext.recordUsingNullReference(scope, local, reference,
40	FlowContext.CAN_ONLY_NULL_NON_NULL, flowInfo);
41	if (((this.bits & OperatorMASK) >> OperatorSHIFT) == EQUAL_EQUAL) {	39	if (((this.bits & OperatorMASK) >> OperatorSHIFT) == EQUAL_EQUAL) {
		40	flowContext.recordUsingNullReference(scope, local, reference,
		41	FlowContext.CAN_ONLY_NULL_NON_NULL \| FlowContext.IN_COMPARISON_NULL, flowInfo);
42	initsWhenTrue.markAsComparedEqualToNull(local); // from thereon it is set	42	initsWhenTrue.markAsComparedEqualToNull(local); // from thereon it is set
43	initsWhenFalse.markAsComparedEqualToNonNull(local); // from thereon it is set	43	initsWhenFalse.markAsComparedEqualToNonNull(local); // from thereon it is set
44	} else {	44	} else {
		45	flowContext.recordUsingNullReference(scope, local, reference,
		46	FlowContext.CAN_ONLY_NULL_NON_NULL \| FlowContext.IN_COMPARISON_NON_NULL, flowInfo);
45	initsWhenTrue.markAsComparedEqualToNonNull(local); // from thereon it is set	47	initsWhenTrue.markAsComparedEqualToNonNull(local); // from thereon it is set
46	initsWhenFalse.markAsComparedEqualToNull(local); // from thereon it is set	48	initsWhenFalse.markAsComparedEqualToNull(local); // from thereon it is set
47	}	49	}
48	break;	50	break;
49	case FlowInfo.NON_NULL :	51	case FlowInfo.NON_NULL :
50	flowContext.recordUsingNullReference(scope, local, reference,
51	FlowContext.CAN_ONLY_NULL, flowInfo);
52	if (((this.bits & OperatorMASK) >> OperatorSHIFT) == EQUAL_EQUAL) {	52	if (((this.bits & OperatorMASK) >> OperatorSHIFT) == EQUAL_EQUAL) {
		53	flowContext.recordUsingNullReference(scope, local, reference,
		54	FlowContext.CAN_ONLY_NULL \| FlowContext.IN_COMPARISON_NON_NULL, flowInfo);
53	initsWhenTrue.markAsComparedEqualToNonNull(local); // from thereon it is set	55	initsWhenTrue.markAsComparedEqualToNonNull(local); // from thereon it is set
		56	} else {
		57	flowContext.recordUsingNullReference(scope, local, reference,
		58	FlowContext.CAN_ONLY_NULL \| FlowContext.IN_COMPARISON_NULL, flowInfo);
54	}	59	}
55	break;	60	break;
56	}	61	}

Lines 38-44 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/InstanceOfExpression.java (-1 / +1 lines)
38	LocalVariableBinding local = this.expression.localVariableBinding();	38	LocalVariableBinding local = this.expression.localVariableBinding();
39	if (local != null && (local.type.tagBits & TagBits.IsBaseType) == 0) {	39	if (local != null && (local.type.tagBits & TagBits.IsBaseType) == 0) {
40	flowContext.recordUsingNullReference(currentScope, local,	40	flowContext.recordUsingNullReference(currentScope, local,
41	this.expression, FlowContext.CAN_ONLY_NULL, flowInfo);	41	this.expression, FlowContext.CAN_ONLY_NULL \| FlowContext.IN_INSTANCEOF, flowInfo);
42	flowInfo = expression.analyseCode(currentScope, flowContext, flowInfo).	42	flowInfo = expression.analyseCode(currentScope, flowContext, flowInfo).
43	unconditionalInits();	43	unconditionalInits();
44	FlowInfo initsWhenTrue = flowInfo.copy();	44	FlowInfo initsWhenTrue = flowInfo.copy();

Lines 42-48 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/Assignment.java (-1 / +1 lines)
42	if (local != null && (local.type.tagBits & TagBits.IsBaseType) == 0) {	42	if (local != null && (local.type.tagBits & TagBits.IsBaseType) == 0) {
43	if (nullStatus == FlowInfo.NULL) {	43	if (nullStatus == FlowInfo.NULL) {
44	flowContext.recordUsingNullReference(currentScope, local, this.lhs,	44	flowContext.recordUsingNullReference(currentScope, local, this.lhs,
45	FlowContext.CAN_ONLY_NULL, flowInfo);	45	FlowContext.CAN_ONLY_NULL \| FlowContext.IN_ASSIGNMENT, flowInfo);
46	}	46	}
47	}	47	}
48	flowInfo = ((Reference) lhs)	48	flowInfo = ((Reference) lhs)




###[obsolete] 394 = The imported type {0} is defined in an inherited type and an enclosing scope

391 = The static import {0} must be a field or member type
392 = The variable {0} can only be null; it was either set to null or checked for null when last used

395 = Duplicate modifier for the variable {0}
396 = Illegal modifier for the variable {0}; only final is permitted
###[obsolete] 397 = Redundant null check: The variable {0} cannot be null at this location
###[obsolete] 398 = Null pointer access: The variable {0} can only be null at this location
###[obsolete] 399 = Potential null pointer access: The variable {0} may be null at this location
	
400 = The type {3} must implement the inherited abstract method {2}.{0}({1})
401 = Cannot override the final method from {0}


450 = {0} {1}

451 = Null pointer access: The variable {0} can only be null at this location
452 = Potential null pointer access: The variable {0} may be null at this location
453 = Redundant null check: The variable {0} can only be null at this location
454 = Null comparison always yields false: The variable {0} can only be null at this location
455 = Redundant assignment: The variable {0} can only be null at this location
456 = instanceof always yields false: The variable {0} can only be null at this location
457 = Redundant null check: The variable {0} cannot be null at this location
458 = Null comparison always yields false: The variable {0} cannot be null at this location

460 = Empty block should be documented

### DOC 




		case IProblem.ConstructorVarargsArgumentNeedCast :
			return CompilerOptions.VarargsArgumentNeedCast;

		case IProblem.NullLocalVariableReference:
			return CompilerOptions.NullReference;

		case IProblem.PotentialNullLocalVariableReference:
			return CompilerOptions.PotentialNullReference;
			
		case IProblem.RedundantLocalVariableNullAssignment:
		case IProblem.RedundantNullCheckOnNonNullLocalVariable:
		case IProblem.RedundantNullCheckOnNullLocalVariable:
		case IProblem.NonNullLocalVariableComparisonYieldsFalse:
		case IProblem.NullLocalVariableComparisonYieldsFalse:
		case IProblem.NullLocalVariableInstanceofYieldsFalse:
			return CompilerOptions.RedundantNullCheck;
			
		case IProblem.BoxingConversion :

	}
	return argument;
}
public void localVariableCannotBeNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.LocalVariableCannotBeNull);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.LocalVariableCannotBeNull,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableCanOnlyBeNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.LocalVariableCanOnlyBeNull);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.LocalVariableCanOnlyBeNull,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableHiding(LocalDeclaration local, Binding hiddenVariable, boolean  isSpecialArgHidingField) {
	if (hiddenVariable instanceof LocalVariableBinding) {
		int id = (local instanceof Argument) 

			local.sourceEnd);
	}
}
public void localVariableNonNullComparedToNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.NonNullLocalVariableComparisonYieldsFalse);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.NonNullLocalVariableComparisonYieldsFalse,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableNullComparedToNonNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.NullLocalVariableComparisonYieldsFalse);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.NullLocalVariableComparisonYieldsFalse,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableNullInstanceof(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.NullLocalVariableInstanceofYieldsFalse);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.NullLocalVariableInstanceofYieldsFalse,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableNullReference(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.NullLocalVariableReference);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.NullLocalVariableReference,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariablePotentialNullReference(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.PotentialNullLocalVariableReference);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)};
	this.handle(
		IProblem.PotentialNullLocalVariableReference,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableRedundantCheckOnNonNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.RedundantNullCheckOnNonNullLocalVariable);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.RedundantNullCheckOnNonNullLocalVariable,
		arguments,
		arguments,
		severity,

		nodeSourceEnd(local, location));
}
public void localVariableRedundantCheckOnNull(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.RedundantNullCheckOnNullLocalVariable);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.RedundantNullCheckOnNullLocalVariable,
		arguments,
		arguments,
		severity,
		nodeSourceStart(local, location),
		nodeSourceEnd(local, location));
}
public void localVariableRedundantNullAssignment(LocalVariableBinding local, ASTNode location) {
	int severity = computeSeverity(IProblem.RedundantLocalVariableNullAssignment);
	if (severity == ProblemSeverities.Ignore) return;
	String[] arguments = new String[] {new String(local.name)  };
	this.handle(
		IProblem.RedundantLocalVariableNullAssignment,
		arguments,
		arguments,
		severity,

Lines 92-114 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/flow/FinallyFlowContext.java (-21 / +80 lines)
92	// final local variable	92	// final local variable
93	LocalVariableBinding local = this.nullLocals[i];	93	LocalVariableBinding local = this.nullLocals[i];
94	switch (this.nullCheckTypes[i]) {	94	switch (this.nullCheckTypes[i]) {
95	case CAN_ONLY_NULL_NON_NULL :	95	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		96	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
96	if (flowInfo.isDefinitelyNonNull(local)) {	97	if (flowInfo.isDefinitelyNonNull(local)) {
97	scope.problemReporter().localVariableCannotBeNull(local, expression);	98	if (this.nullCheckTypes[i] == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		99	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, expression);
		100	} else {
		101	scope.problemReporter().localVariableNonNullComparedToNull(local, expression);
		102	}
98	continue;	103	continue;
99	}	104	}
100	case CAN_ONLY_NULL:	105	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		106	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		107	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		108	case CAN_ONLY_NULL \| IN_INSTANCEOF:
101	if (flowInfo.isDefinitelyNull(local)) {	109	if (flowInfo.isDefinitelyNull(local)) {
102	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);	110	switch(this.nullCheckTypes[i] & CONTEXT_MASK) {
		111	case FlowContext.IN_COMPARISON_NULL:
		112	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);
		113	continue;
		114	case FlowContext.IN_COMPARISON_NON_NULL:
		115	scope.problemReporter().localVariableNullComparedToNonNull(local, expression);
		116	continue;
		117	case FlowContext.IN_ASSIGNMENT:
		118	scope.problemReporter().localVariableRedundantNullAssignment(local, expression);
		119	continue;
		120	case FlowContext.IN_INSTANCEOF:
		121	scope.problemReporter().localVariableNullInstanceof(local, expression);
		122	continue;
		123	}
103	}	124	}
104	break;	125	break;
105	case MAY_NULL :	126	case MAY_NULL:
106	if (flowInfo.isDefinitelyNull(local)) {	127	if (flowInfo.isDefinitelyNull(local)) {
107	scope.problemReporter().localVariableCanOnlyBeNull(local, expression);	128	scope.problemReporter().localVariableNullReference(local, expression);
108	continue;	129	continue;
109	}	130	}
110	if (flowInfo.isPotentiallyNull(local)) {	131	if (flowInfo.isPotentiallyNull(local)) {
111	scope.problemReporter().localVariableMayBeNull(local, expression);	132	scope.problemReporter().localVariablePotentialNullReference(local, expression);
112	}	133	}
113	break;	134	break;
114	default:	135	default:
Lines 161-177 Link Here
161	if ((flowInfo.tagBits & FlowInfo.UNREACHABLE) == 0) {	182	if ((flowInfo.tagBits & FlowInfo.UNREACHABLE) == 0) {
162	if (deferNullDiagnostic) { // within an enclosing loop, be conservative	183	if (deferNullDiagnostic) { // within an enclosing loop, be conservative
163	switch (checkType) {	184	switch (checkType) {
164	case CAN_ONLY_NULL_NON_NULL :	185	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
165	case CAN_ONLY_NULL:	186	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
		187	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		188	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		189	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		190	case CAN_ONLY_NULL \| IN_INSTANCEOF:
166	if (flowInfo.cannotBeNull(local)) {	191	if (flowInfo.cannotBeNull(local)) {
167	if (checkType == CAN_ONLY_NULL_NON_NULL) {	192	if (checkType == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
168	scope.problemReporter().localVariableCannotBeNull(local, reference);	193	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, reference);
		194	} else {
		195	scope.problemReporter().localVariableNonNullComparedToNull(local, reference);
169	}	196	}
170	return;	197	return;
171	}	198	}
172	if (flowInfo.canOnlyBeNull(local)) {	199	if (flowInfo.canOnlyBeNull(local)) {
173	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);	200	switch(checkType & CONTEXT_MASK) {
174	return;	201	case FlowContext.IN_COMPARISON_NULL:
		202	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);
		203	return;
		204	case FlowContext.IN_COMPARISON_NON_NULL:
		205	scope.problemReporter().localVariableNullComparedToNonNull(local, reference);
		206	return;
		207	case FlowContext.IN_ASSIGNMENT:
		208	scope.problemReporter().localVariableRedundantNullAssignment(local, reference);
		209	return;
		210	case FlowContext.IN_INSTANCEOF:
		211	scope.problemReporter().localVariableNullInstanceof(local, reference);
		212	return;
		213	}
175	}	214	}
176	break;	215	break;
177	case MAY_NULL :	216	case MAY_NULL :
Lines 179-185 Link Here
179	return;	218	return;
180	}	219	}
181	if (flowInfo.canOnlyBeNull(local)) {	220	if (flowInfo.canOnlyBeNull(local)) {
182	scope.problemReporter().localVariableCanOnlyBeNull(local, reference);	221	scope.problemReporter().localVariableNullReference(local, reference);
183	return;	222	return;
184	}	223	}
185	break;	224	break;
Lines 189-212 Link Here
189	}	228	}
190	else { // no enclosing loop, be as precise as possible right now	229	else { // no enclosing loop, be as precise as possible right now
191	switch (checkType) {	230	switch (checkType) {
192	case CAN_ONLY_NULL_NON_NULL :	231	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		232	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
193	if (flowInfo.isDefinitelyNonNull(local)) {	233	if (flowInfo.isDefinitelyNonNull(local)) {
194	scope.problemReporter().localVariableCannotBeNull(local, reference);	234	if (checkType == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		235	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, reference);
		236	} else {
		237	scope.problemReporter().localVariableNonNullComparedToNull(local, reference);
		238	}
195	return;	239	return;
196	}	240	}
197	case CAN_ONLY_NULL:	241	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		242	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		243	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		244	case CAN_ONLY_NULL \| IN_INSTANCEOF:
198	if (flowInfo.isDefinitelyNull(local)) {	245	if (flowInfo.isDefinitelyNull(local)) {
199	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);	246	switch(checkType & CONTEXT_MASK) {
200	return;	247	case FlowContext.IN_COMPARISON_NULL:
		248	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);
		249	return;
		250	case FlowContext.IN_COMPARISON_NON_NULL:
		251	scope.problemReporter().localVariableNullComparedToNonNull(local, reference);
		252	return;
		253	case FlowContext.IN_ASSIGNMENT:
		254	scope.problemReporter().localVariableRedundantNullAssignment(local, reference);
		255	return;
		256	case FlowContext.IN_INSTANCEOF:
		257	scope.problemReporter().localVariableNullInstanceof(local, reference);
		258	return;
		259	}
201	}	260	}
202	break;	261	break;
203	case MAY_NULL :	262	case MAY_NULL :
204	if (flowInfo.isDefinitelyNull(local)) {	263	if (flowInfo.isDefinitelyNull(local)) {
205	scope.problemReporter().localVariableCanOnlyBeNull(local, reference);	264	scope.problemReporter().localVariableNullReference(local, reference);
206	return;	265	return;
207	}	266	}
208	if (flowInfo.isPotentiallyNull(local)) {	267	if (flowInfo.isPotentiallyNull(local)) {
209	scope.problemReporter().localVariableMayBeNull(local, reference);	268	scope.problemReporter().localVariablePotentialNullReference(local, reference);
210	return;	269	return;
211	}	270	}
212	if (flowInfo.isDefinitelyNonNull(local)) {	271	if (flowInfo.isDefinitelyNonNull(local)) {

Lines 121-156 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/flow/LoopingFlowContext.java (-36 / +104 lines)
121	Expression expression = this.nullReferences[i];	121	Expression expression = this.nullReferences[i];
122	// final local variable	122	// final local variable
123	switch (this.nullCheckTypes[i]) {	123	switch (this.nullCheckTypes[i]) {
124	case CAN_ONLY_NON_NULL :	124	case CAN_ONLY_NON_NULL \| IN_COMPARISON_NULL:
		125	case CAN_ONLY_NON_NULL \| IN_COMPARISON_NON_NULL:
125	if (flowInfo.isDefinitelyNonNull(local)) {	126	if (flowInfo.isDefinitelyNonNull(local)) {
126	this.nullReferences[i] = null;	127	this.nullReferences[i] = null;
127	scope.problemReporter().localVariableCannotBeNull(local, expression);	128	if (this.nullCheckTypes[i] == (CAN_ONLY_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		129	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, expression);
		130	} else {
		131	scope.problemReporter().localVariableNonNullComparedToNull(local, expression);
		132	}
128	continue;	133	continue;
129	}	134	}
130	break;	135	break;
131	case CAN_ONLY_NULL_NON_NULL :	136	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		137	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
132	if (flowInfo.isDefinitelyNonNull(local)) {	138	if (flowInfo.isDefinitelyNonNull(local)) {
133	this.nullReferences[i] = null;	139	this.nullReferences[i] = null;
134	scope.problemReporter().localVariableCannotBeNull(local, expression);	140	if (this.nullCheckTypes[i] == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		141	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, expression);
		142	} else {
		143	scope.problemReporter().localVariableNonNullComparedToNull(local, expression);
		144	}
135	continue;	145	continue;
136	}	146	}
137	if (flowInfo.isDefinitelyNull(local)) {	147	if (flowInfo.isDefinitelyNull(local)) {
138	this.nullReferences[i] = null;	148	this.nullReferences[i] = null;
139	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);	149	if (this.nullCheckTypes[i] == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL)) {
		150	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);
		151	} else {
		152	scope.problemReporter().localVariableNullComparedToNonNull(local, expression);
		153	}
140	continue;	154	continue;
141	}	155	}
142	break;	156	break;
143	case CAN_ONLY_NULL :	157	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		158	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		159	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		160	case CAN_ONLY_NULL \| IN_INSTANCEOF:
144	if (flowInfo.isDefinitelyNull(local)) {	161	if (flowInfo.isDefinitelyNull(local)) {
145	this.nullReferences[i] = null;	162	this.nullReferences[i] = null;
146	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);	163	switch(this.nullCheckTypes[i] & CONTEXT_MASK) {
147	continue;	164	case FlowContext.IN_COMPARISON_NULL:
		165	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);
		166	continue;
		167	case FlowContext.IN_COMPARISON_NON_NULL:
		168	scope.problemReporter().localVariableNullComparedToNonNull(local, expression);
		169	continue;
		170	case FlowContext.IN_ASSIGNMENT:
		171	scope.problemReporter().localVariableRedundantNullAssignment(local, expression);
		172	continue;
		173	case FlowContext.IN_INSTANCEOF:
		174	scope.problemReporter().localVariableNullInstanceof(local, expression);
		175	continue;
		176	}
148	}	177	}
149	break;	178	break;
150	case MAY_NULL:	179	case MAY_NULL:
151	if (flowInfo.isDefinitelyNull(local)) {	180	if (flowInfo.isDefinitelyNull(local)) {
152	this.nullReferences[i] = null;	181	this.nullReferences[i] = null;
153	scope.problemReporter().localVariableCanOnlyBeNull(local, expression);	182	scope.problemReporter().localVariableNullReference(local, expression);
154	continue;	183	continue;
155	}	184	}
156	break;	185	break;
Lines 168-195 Link Here
168	// final local variable	197	// final local variable
169	LocalVariableBinding local = this.nullLocals[i];	198	LocalVariableBinding local = this.nullLocals[i];
170	switch (this.nullCheckTypes[i]) {	199	switch (this.nullCheckTypes[i]) {
171	case CAN_ONLY_NULL_NON_NULL :	200	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		201	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
172	if (flowInfo.isDefinitelyNonNull(local)) {	202	if (flowInfo.isDefinitelyNonNull(local)) {
173	this.nullReferences[i] = null;	203	this.nullReferences[i] = null;
174	scope.problemReporter().localVariableCannotBeNull(local, expression);	204	if (this.nullCheckTypes[i] == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		205	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, expression);
		206	} else {
		207	scope.problemReporter().localVariableNonNullComparedToNull(local, expression);
		208	}
175	continue;	209	continue;
176	}	210	}
177	case CAN_ONLY_NULL :	211	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		212	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		213	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		214	case CAN_ONLY_NULL \| IN_INSTANCEOF:
178	if (flowInfo.isDefinitelyNull(local)) {	215	if (flowInfo.isDefinitelyNull(local)) {
179	this.nullReferences[i] = null;	216	this.nullReferences[i] = null;
180	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);	217	switch(this.nullCheckTypes[i] & CONTEXT_MASK) {
181	continue;	218	case FlowContext.IN_COMPARISON_NULL:
		219	scope.problemReporter().localVariableRedundantCheckOnNull(local, expression);
		220	continue;
		221	case FlowContext.IN_COMPARISON_NON_NULL:
		222	scope.problemReporter().localVariableNullComparedToNonNull(local, expression);
		223	continue;
		224	case FlowContext.IN_ASSIGNMENT:
		225	scope.problemReporter().localVariableRedundantNullAssignment(local, expression);
		226	continue;
		227	case FlowContext.IN_INSTANCEOF:
		228	scope.problemReporter().localVariableNullInstanceof(local, expression);
		229	continue;
		230	}
182	}	231	}
183	break;	232	break;
184	case MAY_NULL:	233	case MAY_NULL:
185	if (flowInfo.isDefinitelyNull(local)) {	234	if (flowInfo.isDefinitelyNull(local)) {
186	this.nullReferences[i] = null;	235	this.nullReferences[i] = null;
187	scope.problemReporter().localVariableCanOnlyBeNull(local, expression);	236	scope.problemReporter().localVariableNullReference(local, expression);
188	continue;	237	continue;
189	}	238	}
190	if (flowInfo.isPotentiallyNull(local)) {	239	if (flowInfo.isPotentiallyNull(local)) {
191	this.nullReferences[i] = null;	240	this.nullReferences[i] = null;
192	scope.problemReporter().localVariableMayBeNull(local, expression);	241	scope.problemReporter().localVariablePotentialNullReference(local, expression);
193	continue;	242	continue;
194	}	243	}
195	break;	244	break;
Lines 323-354 Link Here
323	return;	372	return;
324	}	373	}
325	switch (checkType) {	374	switch (checkType) {
326	case CAN_ONLY_NULL_NON_NULL :	375	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		376	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
327	if (flowInfo.isDefinitelyNonNull(local)) {	377	if (flowInfo.isDefinitelyNonNull(local)) {
328	scope.problemReporter().localVariableCannotBeNull(local, reference);	378	if (checkType == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
329	return;	379	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, reference);
330	}	380	} else {
331	if (flowInfo.isDefinitelyNull(local)) {	381	scope.problemReporter().localVariableNonNullComparedToNull(local, reference);
332	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);	382	}
333	return;	383	} else if (flowInfo.isDefinitelyNull(local)) {
334	}	384	if (checkType == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL)) {
335	if (flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {	385	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);
336	return;	386	} else {
337	}	387	scope.problemReporter().localVariableNullComparedToNonNull(local, reference);
338	if (flowInfo.isPotentiallyNonNull(local)) {	388	}
339	recordNullReference(local, reference,CAN_ONLY_NON_NULL);	389	} else if (! flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {
340	} else {	390	if (flowInfo.isPotentiallyNonNull(local)) {
341	recordNullReference(local, reference, checkType);	391	recordNullReference(local, reference, CAN_ONLY_NON_NULL \| checkType & CONTEXT_MASK);
		392	} else {
		393	recordNullReference(local, reference, checkType);
		394	}
342	}	395	}
343	return;	396	return;
344	case CAN_ONLY_NULL:	397	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		398	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		399	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		400	case CAN_ONLY_NULL \| IN_INSTANCEOF:
345	if (flowInfo.isPotentiallyNonNull(local)	401	if (flowInfo.isPotentiallyNonNull(local)
346	\|\| flowInfo.isPotentiallyUnknown(local)) {	402	\|\| flowInfo.isPotentiallyUnknown(local)) {
347	return;	403	return;
348	}	404	}
349	if (flowInfo.isDefinitelyNull(local)) {	405	if (flowInfo.isDefinitelyNull(local)) {
350	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);	406	switch(checkType & CONTEXT_MASK) {
351	return;	407	case FlowContext.IN_COMPARISON_NULL:
		408	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);
		409	return;
		410	case FlowContext.IN_COMPARISON_NON_NULL:
		411	scope.problemReporter().localVariableNullComparedToNonNull(local, reference);
		412	return;
		413	case FlowContext.IN_ASSIGNMENT:
		414	scope.problemReporter().localVariableRedundantNullAssignment(local, reference);
		415	return;
		416	case FlowContext.IN_INSTANCEOF:
		417	scope.problemReporter().localVariableNullInstanceof(local, reference);
		418	return;
		419	}
352	}	420	}
353	recordNullReference(local, reference, checkType);	421	recordNullReference(local, reference, checkType);
354	return;	422	return;
Lines 357-367 Link Here
357	return;	425	return;
358	}	426	}
359	if (flowInfo.isDefinitelyNull(local)) {	427	if (flowInfo.isDefinitelyNull(local)) {
360	scope.problemReporter().localVariableCanOnlyBeNull(local, reference);	428	scope.problemReporter().localVariableNullReference(local, reference);
361	return;	429	return;
362	}	430	}
363	if (flowInfo.isPotentiallyNull(local)) {	431	if (flowInfo.isPotentiallyNull(local)) {
364	scope.problemReporter().localVariableMayBeNull(local, reference);	432	scope.problemReporter().localVariablePotentialNullReference(local, reference);
365	return;	433	return;
366	}	434	}
367	recordNullReference(local, reference, checkType);	435	recordNullReference(local, reference, checkType);

Lines 437-443 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/flow/FlowContext.java (-18 / +50 lines)
437	* @param expression the expression within which local lays	437	* @param expression the expression within which local lays
438	* @param status the status against which the check must be performed; one of	438	* @param status the status against which the check must be performed; one of
439	* {@link #CAN_ONLY_NULL CAN_ONLY_NULL}, {@link #CAN_ONLY_NULL_NON_NULL	439	* {@link #CAN_ONLY_NULL CAN_ONLY_NULL}, {@link #CAN_ONLY_NULL_NON_NULL
440	* CAN_ONLY_NULL_NON_NULL}, {@link #MAY_NULL MAY_NULL}	440	* CAN_ONLY_NULL_NON_NULL}, {@link #MAY_NULL MAY_NULL},
		441	* {@link #CAN_ONLY_NON_NULL CAN_ONLY_NON_NULL}, potentially
		442	* combined with a context indicator (one of {@link #IN_COMPARISON_NULL},
		443	* {@link #IN_COMPARISON_NON_NULL}, {@link #IN_ASSIGNMENT} or {@link #IN_INSTANCEOF})
441	*/	444	*/
442	protected void recordNullReference(LocalVariableBinding local,	445	protected void recordNullReference(LocalVariableBinding local,
443	Expression expression, int status) {	446	Expression expression, int status) {
Lines 462-476 Link Here
462	}	465	}
463		466
464	public static final int	467	public static final int
465	CAN_ONLY_NULL_NON_NULL = 20,	468	CAN_ONLY_NULL_NON_NULL = 0x0000,
466	// check against null and non null, with definite values -- comparisons	469	// check against null and non null, with definite values -- comparisons
467	CAN_ONLY_NULL = 21,	470	CAN_ONLY_NULL = 0x0001,
468	// check against null, with definite values -- assignment to null	471	// check against null, with definite values -- comparisons
469	MAY_NULL = 22,	472	CAN_ONLY_NON_NULL = 0x0002,
		473	// check against non null, with definite values -- comparisons
		474	MAY_NULL = 0x0003,
470	// check against null, with potential values -- NPE guard	475	// check against null, with potential values -- NPE guard
471	CAN_ONLY_NON_NULL = 23;	476	CHECK_MASK = 0x00FF,
472	// subcase of CAN_ONLY_NULL_NON_NULL, in which we know that the local	477	IN_COMPARISON_NULL = 0x0100,
473	// may be non null	478	IN_COMPARISON_NON_NULL = 0x0200,
		479	// check happened in a comparison
		480	IN_ASSIGNMENT = 0x0300,
		481	// check happened in an assignment
		482	IN_INSTANCEOF = 0x0400,
		483	// check happened in an instanceof expression
		484	CONTEXT_MASK = ~CHECK_MASK;
474		485
475	/**	486	/**
476	* Record a null reference for use by deferred checks. Only looping or	487	* Record a null reference for use by deferred checks. Only looping or
Lines 485-491 Link Here
485	* @param reference the expression within which local lies	496	* @param reference the expression within which local lies
486	* @param checkType the status against which the check must be performed; one	497	* @param checkType the status against which the check must be performed; one
487	* of {@link #CAN_ONLY_NULL CAN_ONLY_NULL}, {@link #CAN_ONLY_NULL_NON_NULL	498	* of {@link #CAN_ONLY_NULL CAN_ONLY_NULL}, {@link #CAN_ONLY_NULL_NON_NULL
488	* CAN_ONLY_NULL_NON_NULL}, {@link #MAY_NULL MAY_NULL}	499	* CAN_ONLY_NULL_NON_NULL}, {@link #MAY_NULL MAY_NULL}, potentially
		500	* combined with a context indicator (one of {@link #IN_COMPARISON_NULL},
		501	* {@link #IN_COMPARISON_NON_NULL}, {@link #IN_ASSIGNMENT} or {@link #IN_INSTANCEOF})
489	* @param flowInfo the flow info at the check point; deferring contexts will	502	* @param flowInfo the flow info at the check point; deferring contexts will
490	* perform supplementary checks against flow info instances that cannot	503	* perform supplementary checks against flow info instances that cannot
491	* be known at the time of calling this method (they are influenced by	504	* be known at the time of calling this method (they are influenced by
Lines 498-527 Link Here
498	return;	511	return;
499	}	512	}
500	switch (checkType) {	513	switch (checkType) {
501	case CAN_ONLY_NULL_NON_NULL :	514	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NULL:
		515	case CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL:
502	if (flowInfo.isDefinitelyNonNull(local)) {	516	if (flowInfo.isDefinitelyNonNull(local)) {
503	scope.problemReporter().localVariableCannotBeNull(local, reference);	517	if (checkType == (CAN_ONLY_NULL_NON_NULL \| IN_COMPARISON_NON_NULL)) {
		518	scope.problemReporter().localVariableRedundantCheckOnNonNull(local, reference);
		519	} else {
		520	scope.problemReporter().localVariableNonNullComparedToNull(local, reference);
		521	}
504	return;	522	return;
505	}	523	}
506	else if (flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {	524	else if (flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {
507	return;	525	return;
508	}	526	}
509	case CAN_ONLY_NULL:	527	case CAN_ONLY_NULL \| IN_COMPARISON_NULL:
		528	case CAN_ONLY_NULL \| IN_COMPARISON_NON_NULL:
		529	case CAN_ONLY_NULL \| IN_ASSIGNMENT:
		530	case CAN_ONLY_NULL \| IN_INSTANCEOF:
510	if (flowInfo.isDefinitelyNull(local)) {	531	if (flowInfo.isDefinitelyNull(local)) {
511	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);	532	switch(checkType & CONTEXT_MASK) {
512	return;	533	case FlowContext.IN_COMPARISON_NULL:
513	}	534	scope.problemReporter().localVariableRedundantCheckOnNull(local, reference);
514	else if (flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {	535	return;
		536	case FlowContext.IN_COMPARISON_NON_NULL:
		537	scope.problemReporter().localVariableNullComparedToNonNull(local, reference);
		538	return;
		539	case FlowContext.IN_ASSIGNMENT:
		540	scope.problemReporter().localVariableRedundantNullAssignment(local, reference);
		541	return;
		542	case FlowContext.IN_INSTANCEOF:
		543	scope.problemReporter().localVariableNullInstanceof(local, reference);
		544	return;
		545	}
		546	} else if (flowInfo.cannotBeDefinitelyNullOrNonNull(local)) {
515	return;	547	return;
516	}	548	}
517	break;	549	break;
518	case MAY_NULL :	550	case MAY_NULL :
519	if (flowInfo.isDefinitelyNull(local)) {	551	if (flowInfo.isDefinitelyNull(local)) {
520	scope.problemReporter().localVariableCanOnlyBeNull(local, reference);	552	scope.problemReporter().localVariableNullReference(local, reference);
521	return;	553	return;
522	}	554	}
523	if (flowInfo.isPotentiallyNull(local)) {	555	if (flowInfo.isPotentiallyNull(local)) {
524	scope.problemReporter().localVariableMayBeNull(local, reference);	556	scope.problemReporter().localVariablePotentialNullReference(local, reference);
525	return;	557	return;
526	}	558	}
527	break;	559	break;

Return to bug 175570

Lines 185-196 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/AssignmentTest.java (-4 / +4 lines)
185	"1. ERROR in X.java (at line 7)\n" +	185	"1. ERROR in X.java (at line 7)\n" +
186	" }while(a!=null);\n" +	186	" }while(a!=null);\n" +
187	" ^\n" +	187	" ^\n" +
188	"The variable a cannot be null; it was either set to a non-null value or assumed to be non-null when last used\n" +	188	"Redundant null check: The variable a cannot be null at this location\n" +
189	"----------\n" +	189	"----------\n" +
190	"2. ERROR in X.java (at line 9)\n" +	190	"2. ERROR in X.java (at line 9)\n" +
191	" if(a!=null)\n" +	191	" if(a!=null)\n" +
192	" ^\n" +	192	" ^\n" +
193	"The variable a can only be null; it was either set to null or checked for null when last used\n" +	193	"Null comparison always yields false: The variable a can only be null at this location\n" +
194	"----------\n" +	194	"----------\n" +
195	"3. ERROR in X.java (at line 13)\n" +	195	"3. ERROR in X.java (at line 13)\n" +
196	" System.out.println(a+b);\n" +	196	" System.out.println(a+b);\n" +
Lines 641-652 Link Here
641	"1. ERROR in X.java (at line 7)\n" +	641	"1. ERROR in X.java (at line 7)\n" +
642	" } while (o != null);\n" +	642	" } while (o != null);\n" +
643	" ^\n" +	643	" ^\n" +
644	"The variable o can only be null; it was either set to null or checked for null when last used\n" +	644	"Null comparison always yields false: The variable o can only be null at this location\n" +
645	"----------\n" +	645	"----------\n" +
646	"2. ERROR in X.java (at line 8)\n" +	646	"2. ERROR in X.java (at line 8)\n" +
647	" if (o == null) {\n" +	647	" if (o == null) {\n" +
648	" ^\n" +	648	" ^\n" +
649	"The variable o can only be null; it was either set to null or checked for null when last used\n" +	649	"Redundant null check: The variable o can only be null at this location\n" +
650	"----------\n");	650	"----------\n");
651	}	651	}
652	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=93588	652	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=93588

Lines 99-104 Link Here

(-)compiler/org/eclipse/jdt/core/compiler/IProblem.java (-7 / +31 lines)
99	* TypeHidingTypeParameterFromType	99	* TypeHidingTypeParameterFromType
100	* TypeHidingTypeParameterFromMethod	100	* TypeHidingTypeParameterFromMethod
101	* TypeHidingType	101	* TypeHidingType
		102	* IBM Corporation - added the following constants
		103	* NullLocalVariableReference
		104	* PotentialNullLocalVariableReference
		105	* RedundantNullCheckOnNullLocalVariable
		106	* NullLocalVariableComparisonYieldsFalse
		107	* RedundantLocalVariableNullAssignment
		108	* NullLocalVariableInstanceofYieldsFalse
		109	* RedundantNullCheckOnNonNullLocalVariable
		110	* NonNullLocalVariableComparisonYieldsFalse
102	*******************************************************************************/	111	*******************************************************************************/
103	package org.eclipse.jdt.core.compiler;	112	package org.eclipse.jdt.core.compiler;
104		113
Lines 718-732 Link Here
718	// local variable related problems	727	// local variable related problems
719	int DuplicateModifierForVariable = MethodRelated + 395;	728	int DuplicateModifierForVariable = MethodRelated + 395;
720	int IllegalModifierForVariable = MethodRelated + 396;	729	int IllegalModifierForVariable = MethodRelated + 396;
721	/** @since 3.1 */	730	/** @deprecated - problem is no longer generated, use {@link #RedundantNullCheckOnNonNullLocalVariable} instead */
722	int LocalVariableCannotBeNull = Internal + 397; // since 3.3: semantics are LocalVariableRedundantCheckOnNonNull	731	int LocalVariableCannotBeNull = Internal + 397; // since 3.3: semantics are LocalVariableRedundantCheckOnNonNull
723	/** @since 3.1 */	732	/** @deprecated - problem is no longer generated, use {@link #NullLocalVariableReference}, {@link #RedundantNullCheckOnNullLocalVariable} or {@link #RedundantLocalVariableNullAssignment} instead */
724	int LocalVariableCanOnlyBeNull = Internal + 398; // since 3.3: split with LocalVariableRedundantCheckOnNull depending on context	733	int LocalVariableCanOnlyBeNull = Internal + 398; // since 3.3: split with LocalVariableRedundantCheckOnNull depending on context
725	// this id shares the null dereference errors with LocalVariableMayBeNull	734	/** @deprecated - problem is no longer generated, use {@link #PotentialNullLocalVariableReference} instead */
726	/** @since 3.2 */
727	int LocalVariableMayBeNull = Internal + 399;	735	int LocalVariableMayBeNull = Internal + 399;
728	/** @since 3.3 */
729	int LocalVariableRedundantCheckOnNull = Internal + 392;
730		736
731	// method verifier problems	737	// method verifier problems
732	int AbstractMethodMustBeImplemented = MethodRelated + 400;	738	int AbstractMethodMustBeImplemented = MethodRelated + 400;
Lines 775-785 Link Here
775	int UseEnumAsAnIdentifier = Internal + 441;	781	int UseEnumAsAnIdentifier = Internal + 441;
776	/** @since 3.2 */	782	/** @since 3.2 */
777	int EnumConstantsCannotBeSurroundedByParenthesis = Syntax + Internal + 442;	783	int EnumConstantsCannotBeSurroundedByParenthesis = Syntax + Internal + 442;
778		784
779	// detected task	785	// detected task
780	/** @since 2.1 */	786	/** @since 2.1 */
781	int Task = Internal + 450;	787	int Task = Internal + 450;
782		788
		789	// local variables related problems, cont'd
		790	/** @since 3.3 */
		791	int NullLocalVariableReference = Internal + 451;
		792	/** @since 3.3 */
		793	int PotentialNullLocalVariableReference = Internal + 452;
		794	/** @since 3.3 */
		795	int RedundantNullCheckOnNullLocalVariable = Internal + 453;
		796	/** @since 3.3 */
		797	int NullLocalVariableComparisonYieldsFalse = Internal + 454;
		798	/** @since 3.3 */
		799	int RedundantLocalVariableNullAssignment = Internal + 455;
		800	/** @since 3.3 */
		801	int NullLocalVariableInstanceofYieldsFalse = Internal + 456;
		802	/** @since 3.3 */
		803	int RedundantNullCheckOnNonNullLocalVariable = Internal + 457;
		804	/** @since 3.3 */
		805	int NonNullLocalVariableComparisonYieldsFalse = Internal + 458;
		806
783	// block	807	// block
784	/** @since 3.0 */	808	/** @since 3.0 */
785	int UndocumentedEmptyBlock = Internal + 460;	809	int UndocumentedEmptyBlock = Internal + 460;

Lines 320-332 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/problem/messages.properties (-4 / +12 lines)
320	###[obsolete] 394 = The imported type {0} is defined in an inherited type and an enclosing scope	320	###[obsolete] 394 = The imported type {0} is defined in an inherited type and an enclosing scope
321		321
322	391 = The static import {0} must be a field or member type	322	391 = The static import {0} must be a field or member type
323	392 = The variable {0} can only be null; it was either set to null or checked for null when last used
324		323
325	395 = Duplicate modifier for the variable {0}	324	395 = Duplicate modifier for the variable {0}
326	396 = Illegal modifier for the variable {0}; only final is permitted	325	396 = Illegal modifier for the variable {0}; only final is permitted
327	397 = The variable {0} cannot be null; it was either set to a non-null value or assumed to be non-null when last used	326	###[obsolete] 397 = Redundant null check: The variable {0} cannot be null at this location
328	398 = The variable {0} can only be null; it was either set to null or checked for null when last used	327	###[obsolete] 398 = Null pointer access: The variable {0} can only be null at this location
329	399 = The variable {0} may be null	328	###[obsolete] 399 = Potential null pointer access: The variable {0} may be null at this location
330		329
331	400 = The type {3} must implement the inherited abstract method {2}.{0}({1})	330	400 = The type {3} must implement the inherited abstract method {2}.{0}({1})
332	401 = Cannot override the final method from {0}	331	401 = Cannot override the final method from {0}
Lines 362-367 Link Here
362		361
363	450 = {0} {1}	362	450 = {0} {1}
364		363
		364	451 = Null pointer access: The variable {0} can only be null at this location
		365	452 = Potential null pointer access: The variable {0} may be null at this location
		366	453 = Redundant null check: The variable {0} can only be null at this location
		367	454 = Null comparison always yields false: The variable {0} can only be null at this location
		368	455 = Redundant assignment: The variable {0} can only be null at this location
		369	456 = instanceof always yields false: The variable {0} can only be null at this location
		370	457 = Redundant null check: The variable {0} cannot be null at this location
		371	458 = Null comparison always yields false: The variable {0} cannot be null at this location
		372
365	460 = Empty block should be documented	373	460 = Empty block should be documented
366		374
367	### DOC	375	### DOC

Lines 184-197 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java (-33 / +85 lines)
184	case IProblem.ConstructorVarargsArgumentNeedCast :	184	case IProblem.ConstructorVarargsArgumentNeedCast :
185	return CompilerOptions.VarargsArgumentNeedCast;	185	return CompilerOptions.VarargsArgumentNeedCast;
186		186
187	case IProblem.LocalVariableCanOnlyBeNull:	187	case IProblem.NullLocalVariableReference:
188	return CompilerOptions.NullReference;	188	return CompilerOptions.NullReference;
189		189
190	case IProblem.LocalVariableMayBeNull:	190	case IProblem.PotentialNullLocalVariableReference:
191	return CompilerOptions.PotentialNullReference;	191	return CompilerOptions.PotentialNullReference;
192		192
193	case IProblem.LocalVariableCannotBeNull:	193	case IProblem.RedundantLocalVariableNullAssignment:
194	case IProblem.LocalVariableRedundantCheckOnNull:	194	case IProblem.RedundantNullCheckOnNonNullLocalVariable:
		195	case IProblem.RedundantNullCheckOnNullLocalVariable:
		196	case IProblem.NonNullLocalVariableComparisonYieldsFalse:
		197	case IProblem.NullLocalVariableComparisonYieldsFalse:
		198	case IProblem.NullLocalVariableInstanceofYieldsFalse:
195	return CompilerOptions.RedundantNullCheck;	199	return CompilerOptions.RedundantNullCheck;
196		200
197	case IProblem.BoxingConversion :	201	case IProblem.BoxingConversion :
Lines 4385-4414 Link Here
4385	}	4389	}
4386	return argument;	4390	return argument;
4387	}	4391	}
4388	public void localVariableCannotBeNull(LocalVariableBinding local, ASTNode location) {
4389	int severity = computeSeverity(IProblem.LocalVariableCannotBeNull);
4390	if (severity == ProblemSeverities.Ignore) return;
4391	String[] arguments = new String[] {new String(local.name) };
4392	this.handle(
4393	IProblem.LocalVariableCannotBeNull,
4394	arguments,
4395	arguments,
4396	severity,
4397	nodeSourceStart(local, location),
4398	nodeSourceEnd(local, location));
4399	}
4400	public void localVariableCanOnlyBeNull(LocalVariableBinding local, ASTNode location) {
4401	int severity = computeSeverity(IProblem.LocalVariableCanOnlyBeNull);
4402	if (severity == ProblemSeverities.Ignore) return;
4403	String[] arguments = new String[] {new String(local.name) };
4404	this.handle(
4405	IProblem.LocalVariableCanOnlyBeNull,
4406	arguments,
4407	arguments,
4408	severity,
4409	nodeSourceStart(local, location),
4410	nodeSourceEnd(local, location));
4411	}
4412	public void localVariableHiding(LocalDeclaration local, Binding hiddenVariable, boolean isSpecialArgHidingField) {	4392	public void localVariableHiding(LocalDeclaration local, Binding hiddenVariable, boolean isSpecialArgHidingField) {
4413	if (hiddenVariable instanceof LocalVariableBinding) {	4393	if (hiddenVariable instanceof LocalVariableBinding) {
4414	int id = (local instanceof Argument)	4394	int id = (local instanceof Argument)
Lines 4443-4454 Link Here
4443	local.sourceEnd);	4423	local.sourceEnd);
4444	}	4424	}
4445	}	4425	}
4446	public void localVariableMayBeNull(LocalVariableBinding local, ASTNode location) {	4426	public void localVariableNonNullComparedToNull(LocalVariableBinding local, ASTNode location) {
4447	int severity = computeSeverity(IProblem.LocalVariableMayBeNull);	4427	int severity = computeSeverity(IProblem.NonNullLocalVariableComparisonYieldsFalse);
		4428	if (severity == ProblemSeverities.Ignore) return;
		4429	String[] arguments = new String[] {new String(local.name) };
		4430	this.handle(
		4431	IProblem.NonNullLocalVariableComparisonYieldsFalse,
		4432	arguments,
		4433	arguments,
		4434	severity,
		4435	nodeSourceStart(local, location),
		4436	nodeSourceEnd(local, location));
		4437	}
		4438	public void localVariableNullComparedToNonNull(LocalVariableBinding local, ASTNode location) {
		4439	int severity = computeSeverity(IProblem.NullLocalVariableComparisonYieldsFalse);
		4440	if (severity == ProblemSeverities.Ignore) return;
		4441	String[] arguments = new String[] {new String(local.name) };
		4442	this.handle(
		4443	IProblem.NullLocalVariableComparisonYieldsFalse,
		4444	arguments,
		4445	arguments,
		4446	severity,
		4447	nodeSourceStart(local, location),
		4448	nodeSourceEnd(local, location));
		4449	}
		4450	public void localVariableNullInstanceof(LocalVariableBinding local, ASTNode location) {
		4451	int severity = computeSeverity(IProblem.NullLocalVariableInstanceofYieldsFalse);
		4452	if (severity == ProblemSeverities.Ignore) return;
		4453	String[] arguments = new String[] {new String(local.name) };
		4454	this.handle(
		4455	IProblem.NullLocalVariableInstanceofYieldsFalse,
		4456	arguments,
		4457	arguments,
		4458	severity,
		4459	nodeSourceStart(local, location),
		4460	nodeSourceEnd(local, location));
		4461	}
		4462	public void localVariableNullReference(LocalVariableBinding local, ASTNode location) {
		4463	int severity = computeSeverity(IProblem.NullLocalVariableReference);
		4464	if (severity == ProblemSeverities.Ignore) return;
		4465	String[] arguments = new String[] {new String(local.name) };
		4466	this.handle(
		4467	IProblem.NullLocalVariableReference,
		4468	arguments,
		4469	arguments,
		4470	severity,
		4471	nodeSourceStart(local, location),
		4472	nodeSourceEnd(local, location));
		4473	}
		4474	public void localVariablePotentialNullReference(LocalVariableBinding local, ASTNode location) {
		4475	int severity = computeSeverity(IProblem.PotentialNullLocalVariableReference);
4448	if (severity == ProblemSeverities.Ignore) return;	4476	if (severity == ProblemSeverities.Ignore) return;
4449	String[] arguments = new String[] {new String(local.name)};	4477	String[] arguments = new String[] {new String(local.name)};
4450	this.handle(	4478	this.handle(
4451	IProblem.LocalVariableMayBeNull,	4479	IProblem.PotentialNullLocalVariableReference,
		4480	arguments,
		4481	arguments,
		4482	severity,
		4483	nodeSourceStart(local, location),
		4484	nodeSourceEnd(local, location));
		4485	}
		4486	public void localVariableRedundantCheckOnNonNull(LocalVariableBinding local, ASTNode location) {
		4487	int severity = computeSeverity(IProblem.RedundantNullCheckOnNonNullLocalVariable);
		4488	if (severity == ProblemSeverities.Ignore) return;
		4489	String[] arguments = new String[] {new String(local.name) };
		4490	this.handle(
		4491	IProblem.RedundantNullCheckOnNonNullLocalVariable,
4452	arguments,	4492	arguments,
4453	arguments,	4493	arguments,
4454	severity,	4494	severity,
Lines 4456-4466 Link Here
4456	nodeSourceEnd(local, location));	4496	nodeSourceEnd(local, location));
4457	}	4497	}
4458	public void localVariableRedundantCheckOnNull(LocalVariableBinding local, ASTNode location) {	4498	public void localVariableRedundantCheckOnNull(LocalVariableBinding local, ASTNode location) {
4459	int severity = computeSeverity(IProblem.LocalVariableRedundantCheckOnNull);	4499	int severity = computeSeverity(IProblem.RedundantNullCheckOnNullLocalVariable);
		4500	if (severity == ProblemSeverities.Ignore) return;
		4501	String[] arguments = new String[] {new String(local.name) };
		4502	this.handle(
		4503	IProblem.RedundantNullCheckOnNullLocalVariable,
		4504	arguments,
		4505	arguments,
		4506	severity,
		4507	nodeSourceStart(local, location),
		4508	nodeSourceEnd(local, location));
		4509	}
		4510	public void localVariableRedundantNullAssignment(LocalVariableBinding local, ASTNode location) {
		4511	int severity = computeSeverity(IProblem.RedundantLocalVariableNullAssignment);
4460	if (severity == ProblemSeverities.Ignore) return;	4512	if (severity == ProblemSeverities.Ignore) return;
4461	String[] arguments = new String[] {new String(local.name) };	4513	String[] arguments = new String[] {new String(local.name) };
4462	this.handle(	4514	this.handle(
4463	IProblem.LocalVariableRedundantCheckOnNull,	4515	IProblem.RedundantLocalVariableNullAssignment,
4464	arguments,	4516	arguments,
4465	arguments,	4517	arguments,
4466	severity,	4518	severity,