Attachment 59092 Details for Bug 150244 – Proposed fix for the JDT/UI side

[patch] Proposed fix for the JDT/UI side

patch_150244_ui.txt (text/plain), 1.88 KB, created by Olivier Thomann

on 2007-02-15 14:52:33 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2007-02-15 14:52:33 EST

Size: 1.88 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java,v
>retrieving revision 1.93
>diff -u -r1.93 ClassFileEditor.java
>--- ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java	8 Feb 2007 09:57:20 -0000	1.93
>+++ ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java	15 Feb 2007 19:49:51 -0000
>@@ -76,7 +76,7 @@
> import org.eclipse.jdt.core.JavaModelException;
> import org.eclipse.jdt.core.ToolFactory;
> import org.eclipse.jdt.core.util.ClassFileBytesDisassembler;
>-import org.eclipse.jdt.core.util.IClassFileDisassembler;
>+import org.eclipse.jdt.core.util.ClassFormatException;
> import org.eclipse.jdt.core.util.IClassFileReader;
> 
> import org.eclipse.jdt.internal.corext.util.JavaModelUtil;
>@@ -375,8 +375,14 @@
> 			int flags= IClassFileReader.FIELD_INFOS | IClassFileReader.METHOD_INFOS | IClassFileReader.SUPER_INTERFACES | IClassFileReader.METHOD_BODIES;
> 			IClassFileReader classFileReader= ToolFactory.createDefaultClassFileReader(classFile, flags);
> 			if (classFileReader != null) {
>-				IClassFileDisassembler disassembler= ToolFactory.createDefaultClassFileDisassembler();
>-				content= disassembler.disassemble(classFileReader, "\n", ClassFileBytesDisassembler.DETAILED); //$NON-NLS-1$
>+				ClassFileBytesDisassembler disassembler= ToolFactory.createDefaultClassFileBytesDisassembler();
>+				try {
>+					content= disassembler.disassemble(classFile.getBytes(), "\n", ClassFileBytesDisassembler.DETAILED); //$NON-NLS-1$
>+				} catch (JavaModelException e) {
>+					// ignore
>+				} catch (ClassFormatException e) {
>+					// ignore
>+				}
> 			}
> 			styledText.setText(content == null ? "" : content); //$NON-NLS-1$
> 		}

Actions: View | Diff

Attachments on bug 150244: 59091 | 59092 | 59117