Attachment 58245 Details for Bug 172345 – Fixed, non definitive test cases

[patch] Fixed, non definitive test cases

patch.txt (text/plain), 4.44 KB, created by Maxime Daniel

on 2007-02-05 05:18:33 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Maxime Daniel

Created: 2007-02-05 05:18:33 EST

Size: 4.44 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.builder
>Index: src/org/eclipse/jdt/core/tests/builder/BuildpathTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/BuildpathTests.java,v
>retrieving revision 1.32
>diff -u -r1.32 BuildpathTests.java
>--- src/org/eclipse/jdt/core/tests/builder/BuildpathTests.java	2 Feb 2007 17:28:57 -0000	1.32
>+++ src/org/eclipse/jdt/core/tests/builder/BuildpathTests.java	5 Feb 2007 10:15:34 -0000
>@@ -441,7 +441,7 @@
> 		Problem[] prob1 = env.getProblemsFor(classTest1);
> 		Problem[] prob2 = env.getProblemsFor(classTest2);
> 		Problem[] prob3 = env.getProblemsFor(classTest3);
>-		assertEquals("too many problems", prob1.length + prob2.length + prob3.length,1); //$NON-NLS-1$
>+		assertEquals("too many problems", prob1.length + prob2.length + prob3.length, 1); //$NON-NLS-1$
> 		if(prob1.length == 1) {
> 			expectingSpecificProblemFor(classTest1, new Problem("p1", "The type java.lang.Object cannot be resolved. It is indirectly referenced from required .class files", classTest1, -1, -1, -1, IMarker.SEVERITY_ERROR)); //$NON-NLS-1$ //$NON-NLS-2$
> 		} else if (prob2.length == 1) {
>@@ -465,37 +465,41 @@
> 	}
> 
> // https://bugs.eclipse.org/bugs/show_bug.cgi?id=172345
>-public void _testMissingLibrary3() throws JavaModelException {
>+public void testMissingLibrary3() throws JavaModelException {
> 	IPath projectPath = env.addProject("Project");
> 	IJavaProject project = env.getJavaProject(projectPath);
> 	fullBuild();
> 	expectingNoProblems();
> 	project.setOption(JavaCore.CORE_INCOMPLETE_CLASSPATH, CompilerOptions.WARNING);
> 	env.addLibrary(projectPath, projectPath.append("/lib/dummy.jar"), null, null);
>-	// triggers a build
>+	fullBuild();
> 	expectingSpecificProblemFor(
> 		projectPath,
> 		new Problem("Build path", "Project Project is missing required library: 'lib/dummy.jar'", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH,
> 				IMarker.SEVERITY_WARNING));
> 	project.setOption(JavaCore.CORE_INCOMPLETE_CLASSPATH, CompilerOptions.ERROR);
>-	cleanBuild();
>+	// force classpath change delta - should not have to do this
>+	IClasspathEntry[] classpath = project.getRawClasspath();
>+	IPath outputLocation;
>+	project.setRawClasspath(null, outputLocation = project.getOutputLocation(), false, null);
>+	project.setRawClasspath(classpath, outputLocation, false, null);
>+	fullBuild();
> 	expectingSpecificProblemFor(
> 		projectPath,
> 		new Problem("", "The project cannot be built until build path errors are resolved", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH, IMarker.SEVERITY_ERROR));
> 	expectingSpecificProblemFor(
> 		projectPath,
> 		new Problem("Build path", "Project Project is missing required library: 'lib/dummy.jar'", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH, IMarker.SEVERITY_ERROR));
>-	project.setOption(JavaCore.CORE_INCOMPLETE_CLASSPATH, CompilerOptions.WARNING);
> }
> 	
> // https://bugs.eclipse.org/bugs/show_bug.cgi?id=172345
>-public void _testMissingLibrary4() throws JavaModelException {
>+public void testMissingLibrary4() throws JavaModelException {
> 	IPath projectPath = env.addProject("Project");
> 	IJavaProject project = env.getJavaProject(projectPath);
> 	fullBuild();
> 	expectingNoProblems();
> 	env.addLibrary(projectPath, projectPath.append("/lib/dummy.jar"), null, null);
>-	// triggers a build
>+	fullBuild();
> 	expectingSpecificProblemFor(
> 		projectPath,
> 		new Problem("", "The project cannot be built until build path errors are resolved", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH, IMarker.SEVERITY_ERROR));
>@@ -503,7 +507,12 @@
> 		projectPath,
> 		new Problem("Build path", "Project Project is missing required library: 'lib/dummy.jar'", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH, IMarker.SEVERITY_ERROR));
> 	project.setOption(JavaCore.CORE_INCOMPLETE_CLASSPATH, CompilerOptions.WARNING);
>-	cleanBuild();
>+	// force classpath change delta - should not have to do this
>+	IClasspathEntry[] classpath = project.getRawClasspath();
>+	IPath outputLocation;
>+	project.setRawClasspath(null, outputLocation = project.getOutputLocation(), false, null);
>+	project.setRawClasspath(classpath, outputLocation, false, null);
>+	fullBuild();
> 	expectingSpecificProblemFor(
> 		projectPath,
> 		new Problem("Build path", "Project Project is missing required library: 'lib/dummy.jar'", projectPath, -1, -1, CategorizedProblem.CAT_BUILDPATH,

Actions: View | Diff

Attachments on bug 172345: 58245 | 58674 | 59863