Attachment 57132 Details for Bug 171016 – Proposed patch

[patch] Proposed patch

v00.txt (text/plain), 3.82 KB, created by Frederic Fusier

on 2007-01-19 09:09:14 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2007-01-19 09:09:14 EST

Size: 3.82 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionJavadocParser.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionJavadocParser.java,v
>retrieving revision 1.26
>diff -u -r1.26 CompletionJavadocParser.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionJavadocParser.java	24 Nov 2006 01:32:05 -0000	1.26
>+++ codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionJavadocParser.java	19 Jan 2007 14:04:47 -0000
>@@ -252,7 +252,7 @@
> 			int length = possibleTags[k].length, size = 0;
> 			int indexes[] = new int[length];
> 			for (int i=0; i<length; i++) {
>-				if (CharOperation.prefixEquals(prefix, possibleTags[k][i])) {
>+				if (CharOperation.prefixEquals(prefix, possibleTags[k][i], false)) {
> 					indexes[size++] = i;
> 				}
> 			}
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/model/JavadocBugsCompletionModelTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/JavadocBugsCompletionModelTest.java,v
>retrieving revision 1.18
>diff -u -r1.18 JavadocBugsCompletionModelTest.java
>--- src/org/eclipse/jdt/core/tests/model/JavadocBugsCompletionModelTest.java	21 Nov 2006 12:43:55 -0000	1.18
>+++ src/org/eclipse/jdt/core/tests/model/JavadocBugsCompletionModelTest.java	19 Jan 2007 14:04:49 -0000
>@@ -999,4 +999,63 @@
> 		"EXAMPLE[FIELD_REF]{EXAMPLE, Lbugs.b144866.BasicTestBugs;, I, EXAMPLE, null, "+this.positions+R_DICNR+"}"
> 	);
> }
>+
>+/**
>+ * @bug 171016: [javadoc][assist] No completion for tag when uppercase is used
>+ * @test Ensure that tag is proposed when prefix match a tag case insensitive 
>+ * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171016"
>+ */
>+public void testBug171016() throws JavaModelException {
>+	String source =
>+		"package bugs.b171016;\n" + 
>+		"public class BasicTestBugs {\n" + 
>+		"	public void foo() {}" +
>+		"}\n" +
>+		"class X extends BasicTestBugs {\n" +
>+		"	/**\n" + 
>+		"	 * {@In\n" + 
>+		"	 */\n" + 
>+		"	public void foo() {}" +
>+		"}\n";
>+	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "{@In", 1);
>+	assertSortedResults(
>+		"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
>+	);
>+}
>+public void testBug171016b() throws JavaModelException {
>+	String source =
>+		"package bugs.b171016;\n" + 
>+		"public class BasicTestBugs {\n" + 
>+		"	public void foo() {}" +
>+		"}\n" +
>+		"class X extends BasicTestBugs {\n" +
>+		"	/**\n" + 
>+		"	 * @In\n" + 
>+		"	 */\n" + 
>+		"	public void foo() {}" +
>+		"}\n";
>+	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "@In", 1);
>+	assertSortedResults(
>+		"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
>+	);
>+}
>+
>+/**
>+ * @bug 171031: [javadoc][assist] 'inheritDoc' tag is proposed while completing even if the method does not override any
>+ * @test Ensure that no 'inheritDoc' tag is proposed when method does not override any 
>+ * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171031"
>+ */
>+// TODO (eric) enable when bug will be fixed
>+public void _testBug171031() throws JavaModelException {
>+	String source =
>+		"package bugs.b171031;\n" + 
>+		"public class BasicTestBugs {\n" + 
>+		"	/**\n" + 
>+		"	 * @In+\n" + 
>+		"	 */\n" + 
>+		"	public void foo() {}" +
>+		"}\n";
>+	completeInJavadoc("/Completion/src/bugs/b171031/BasicTestBugs.java", source, true, "@In", 1);
>+	assertSortedResults(""); // should not have any proposal as 
>+}
> }

Actions: View | Diff

Attachments on bug 171016: 57132