Attachment #57132 for bug #171016

View | Details | Raw Unified | Return to bug 171016
Collapse All | Expand All

Lines 252-258 Link Here

(-)codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionJavadocParser.java (-1 / +1 lines)
252	int length = possibleTags[k].length, size = 0;	252	int length = possibleTags[k].length, size = 0;
253	int indexes[] = new int[length];	253	int indexes[] = new int[length];
254	for (int i=0; i<length; i++) {	254	for (int i=0; i<length; i++) {
255	if (CharOperation.prefixEquals(prefix, possibleTags[k][i])) {	255	if (CharOperation.prefixEquals(prefix, possibleTags[k][i], false)) {
256	indexes[size++] = i;	256	indexes[size++] = i;
257	}	257	}
258	}	258	}




		"EXAMPLE[FIELD_REF]{EXAMPLE, Lbugs.b144866.BasicTestBugs;, I, EXAMPLE, null, "+this.positions+R_DICNR+"}"
	);
}

/**
 * @bug 171016: [javadoc][assist] No completion for tag when uppercase is used
 * @test Ensure that tag is proposed when prefix match a tag case insensitive 
 * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171016"
 */
public void testBug171016() throws JavaModelException {
	String source =
		"package bugs.b171016;\n" + 
		"public class BasicTestBugs {\n" + 
		"	public void foo() {}" +
		"}\n" +
		"class X extends BasicTestBugs {\n" +
		"	/**\n" + 
		"	 * {@In\n" + 
		"	 */\n" + 
		"	public void foo() {}" +
		"}\n";
	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "{@In", 1);
	assertSortedResults(
		"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
	);
}
public void testBug171016b() throws JavaModelException {
	String source =
		"package bugs.b171016;\n" + 
		"public class BasicTestBugs {\n" + 
		"	public void foo() {}" +
		"}\n" +
		"class X extends BasicTestBugs {\n" +
		"	/**\n" + 
		"	 * @In\n" + 
		"	 */\n" + 
		"	public void foo() {}" +
		"}\n";
	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "@In", 1);
	assertSortedResults(
		"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
	);
}

/**
 * @bug 171031: [javadoc][assist] 'inheritDoc' tag is proposed while completing even if the method does not override any
 * @test Ensure that no 'inheritDoc' tag is proposed when method does not override any 
 * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171031"
 */
// TODO (eric) enable when bug will be fixed
public void _testBug171031() throws JavaModelException {
	String source =
		"package bugs.b171031;\n" + 
		"public class BasicTestBugs {\n" + 
		"	/**\n" + 
		"	 * @In+\n" + 
		"	 */\n" + 
		"	public void foo() {}" +
		"}\n";
	completeInJavadoc("/Completion/src/bugs/b171031/BasicTestBugs.java", source, true, "@In", 1);
	assertSortedResults(""); // should not have any proposal as 
}
}

Return to bug 171016

Lines 999-1002 Link Here

(-)src/org/eclipse/jdt/core/tests/model/JavadocBugsCompletionModelTest.java (+59 lines)
999	"EXAMPLE[FIELD_REF]{EXAMPLE, Lbugs.b144866.BasicTestBugs;, I, EXAMPLE, null, "+this.positions+R_DICNR+"}"	999	"EXAMPLE[FIELD_REF]{EXAMPLE, Lbugs.b144866.BasicTestBugs;, I, EXAMPLE, null, "+this.positions+R_DICNR+"}"
1000	);	1000	);
1001	}	1001	}
		1002
		1003	/**
		1004	* @bug 171016: [javadoc][assist] No completion for tag when uppercase is used
		1005	* @test Ensure that tag is proposed when prefix match a tag case insensitive
		1006	* @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171016"
		1007	*/
		1008	public void testBug171016() throws JavaModelException {
		1009	String source =
		1010	"package bugs.b171016;\n" +
		1011	"public class BasicTestBugs {\n" +
		1012	" public void foo() {}" +
		1013	"}\n" +
		1014	"class X extends BasicTestBugs {\n" +
		1015	" /**\n" +
		1016	" * {@In\n" +
		1017	" */\n" +
		1018	" public void foo() {}" +
		1019	"}\n";
		1020	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "{@In", 1);
		1021	assertSortedResults(
		1022	"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
		1023	);
		1024	}
		1025	public void testBug171016b() throws JavaModelException {
		1026	String source =
		1027	"package bugs.b171016;\n" +
		1028	"public class BasicTestBugs {\n" +
		1029	" public void foo() {}" +
		1030	"}\n" +
		1031	"class X extends BasicTestBugs {\n" +
		1032	" /**\n" +
		1033	" * @In\n" +
		1034	" */\n" +
		1035	" public void foo() {}" +
		1036	"}\n";
		1037	completeInJavadoc("/Completion/src/bugs/b171016/BasicTestBugs.java", source, true, "@In", 1);
		1038	assertSortedResults(
		1039	"inheritDoc[JAVADOC_INLINE_TAG]{{@inheritDoc}, null, null, inheritDoc, null, "+this.positions+JAVADOC_RELEVANCE+"}"
		1040	);
		1041	}
		1042
		1043	/**
		1044	* @bug 171031: [javadoc][assist] 'inheritDoc' tag is proposed while completing even if the method does not override any
		1045	* @test Ensure that no 'inheritDoc' tag is proposed when method does not override any
		1046	* @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=171031"
		1047	*/
		1048	// TODO (eric) enable when bug will be fixed
		1049	public void _testBug171031() throws JavaModelException {
		1050	String source =
		1051	"package bugs.b171031;\n" +
		1052	"public class BasicTestBugs {\n" +
		1053	" /**\n" +
		1054	" * @In+\n" +
		1055	" */\n" +
		1056	" public void foo() {}" +
		1057	"}\n";
		1058	completeInJavadoc("/Completion/src/bugs/b171031/BasicTestBugs.java", source, true, "@In", 1);
		1059	assertSortedResults(""); // should not have any proposal as
		1060	}
1002	}	1061	}