Attachment 56752 Details for Bug 170181 – Proposed patch

[patch] Proposed patch

170181.txt (text/plain), 2.09 KB, created by Philipe Mulet

on 2007-01-11 04:08:22 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Philipe Mulet

Created: 2007-01-11 04:08:22 EST

Size: 2.09 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/ASTNode.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ASTNode.java,v
>retrieving revision 1.78
>diff -u -r1.78 ASTNode.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/ASTNode.java	9 Jan 2007 16:16:52 -0000	1.78
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/ASTNode.java	11 Jan 2007 09:00:20 -0000
>@@ -398,7 +398,7 @@
> 
> 		ReferenceBinding refType = (ReferenceBinding) type;
> 
>-		if ((refType.isPrivate() /*|| refType.isLocalType()*/) && !scope.isDefinedInType(refType)) {
>+		if ((refType.isPrivate() || refType.isLocalType()) && !scope.isDefinedInType(refType)) {
> 			// ignore cases where type is used from within inside itself 
> 			((ReferenceBinding)refType.erasure()).modifiers |= ExtraCompilerModifiers.AccLocallyUsed;
> 		}
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java,v
>retrieving revision 1.131
>diff -u -r1.131 TypeDeclaration.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java	24 Nov 2006 01:32:07 -0000	1.131
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java	11 Jan 2007 09:00:20 -0000
>@@ -589,7 +589,7 @@
>  *	Common flow analysis for all types
>  */
> private void internalAnalyseCode(FlowContext flowContext, FlowInfo flowInfo) {
>-	if ((this.binding.isPrivate()/* || (this.binding.tagBits & (TagBits.IsAnonymousType|TagBits.IsLocalType)) == TagBits.IsLocalType*/) && !this.binding.isUsed()) {
>+	if ((this.binding.isPrivate() || (this.binding.tagBits & (TagBits.IsAnonymousType|TagBits.IsLocalType)) == TagBits.IsLocalType) && !this.binding.isUsed()) {
> 		if (!this.scope.referenceCompilationUnit().compilationResult.hasSyntaxError) {
> 			this.scope.problemReporter().unusedPrivateType(this);
> 		}

Actions: View | Diff

Attachments on bug 170181: 56752 | 56842