Attachment 55200 Details for Bug 166570 – Fix with the null check

[patch] Fix with the null check

bug166570_001.txt (text/plain), 1.29 KB, created by David Audel

on 2006-12-07 04:51:00 EST

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2006-12-07 04:51:00 EST

Size: 1.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: codeassist/org/eclipse/jdt/internal/codeassist/UnresolvedReferenceNameFinder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/UnresolvedReferenceNameFinder.java,v
>retrieving revision 1.3
>diff -u -r1.3 UnresolvedReferenceNameFinder.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/UnresolvedReferenceNameFinder.java	3 Nov 2006 12:52:17 -0000	1.3
>+++ codeassist/org/eclipse/jdt/internal/codeassist/UnresolvedReferenceNameFinder.java	7 Dec 2006 09:43:35 -0000
>@@ -58,6 +58,9 @@
> 	} 
> 	
> 	private void acceptName(char[] name) {
>+		// the null check is added to fix bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=166570
>+		if (name != null) return;
>+		
> 		if (acceptedNames.includes(name)) return;
> 		
> 		this.acceptedNames.add(name);
>@@ -411,6 +414,7 @@
> 		int i = indexOfFisrtNameAfter(start);
> 		done : while (i != -1) {
> 			int nameStart = this.potentialVariableNameStarts[i];
>+			// the null check is added to fix bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=166570
> 			if (start < nameStart && nameStart < end) {
> 				this.acceptName(this.potentialVariableNames[i]);
> 				this.removeNameAt(i);

Actions: View | Diff

Attachments on bug 166570: 55200 | 57440