Attachment 52364 Details for Bug 160337 – Proposed fix

[patch] Proposed fix

patch_160337.txt (text/plain), 1.54 KB, created by Olivier Thomann

on 2006-10-19 22:06:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2006-10-19 22:06:33 EDT

Size: 1.54 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java,v
>retrieving revision 1.354
>diff -u -r1.354 Parser.java
>--- compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java	19 Oct 2006 14:24:19 -0000	1.354
>+++ compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java	20 Oct 2006 02:07:47 -0000
>@@ -2439,7 +2439,7 @@
> 		cd.constructorCall.sourceStart = cd.sourceStart;
> 	}
> 
>-	if (!this.diet 
>+	if (!(this.diet && this.dietInt == 0)
> 			&& statements == null 
> 			&& (constructorCall == null || constructorCall.isImplicitSuper())) {
> 		if (!containsComment(cd.bodyStart, this.endPosition)) {
>@@ -4072,12 +4072,8 @@
> 	// is a body when we reduce the method header
> 	if (!isNotAbstract) { //remember the fact that the method has a semicolon body
> 		md.modifiers |= ExtraCompilerModifiers.AccSemicolonBody;
>-	} else {
>-		if (!this.diet && statements == null) {
>-			if (!containsComment(md.bodyStart, this.endPosition)) {
>-				md.bits |= ASTNode.UndocumentedEmptyBlock;
>-			}
>-		}
>+	} else if (!(this.diet && this.dietInt == 0) && statements == null && !containsComment(md.bodyStart, this.endPosition)) {
>+		md.bits |= ASTNode.UndocumentedEmptyBlock;
> 	}
> 	// store the this.endPosition (position just before the '}') in case there is
> 	// a trailing comment behind the end of the method

Actions: View | Diff

Attachments on bug 160337: 52364 | 52365