Attachment 5231 Details for Bug 24632 – Patch for org.eclipse.ui.views

[patch] Patch for org.eclipse.ui.views

24632patch.txt (text/plain), 3.09 KB, created by Debbie Wilson

on 2003-06-18 11:30:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Debbie Wilson

Created: 2003-06-18 11:30:10 EDT

Size: 3.09 KB

patch

obsolete

>Index: src/org/eclipse/ui/views/properties/IPropertySource.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/IPropertySource.java,v
>retrieving revision 1.5
>diff -u -r1.5 IPropertySource.java
>--- src/org/eclipse/ui/views/properties/IPropertySource.java	27 Mar 2003 17:28:40 -0000	1.5
>+++ src/org/eclipse/ui/views/properties/IPropertySource.java	18 Jun 2003 15:26:59 -0000
>@@ -12,8 +12,8 @@
> 
> 
> /**
>- * Interface to an object capable of supplying properties for display by the
>- * standard property sheet page implementation (<code>PropertySheetPage</code>).
>+ * Interface to an object which is capable of supplying properties for display by
>+ * the standard property sheet page implementation (<code>PropertySheetPage</code>).
> * 
> * This interface should be implemented by clients.
> * <code>PropertySheetPage</code> discovers the properties to display from 
>@@ -88,9 +88,8 @@
> public IPropertyDescriptor[] getPropertyDescriptors();
> /**
> * Returns the value of the property with the given id if it has one.
>- * Returns <code>null</code> if this source if the property's value is
>- * <code>null</code> value or if this source does not have the specified
>- * property.
>+ * Returns <code>null</code> if the property's value is <code>null</code> 
>+ * value or if this source does not have the specified property.
> *
> * @see #setPropertyValue
> *
>@@ -124,14 +123,14 @@
> * specified property.
> * 
> * In general, a property source should not directly reference the value
>- * parameter unless it is an atomic object that can be shared such as a 
>+ * parameter unless it is an atomic object that can be shared, such as a 
> * string.
> * 
> * 
> * An important reason for this is that several property sources with 
> * compatible descriptors could be appearing in the property sheet at 
> * the same time. An editor produces a single edited value which is passed
>- * at the value parameter of this message to all the property sources.
>+ * as the value parameter of this message to all the property sources.
> * Thus to avoid a situation where all of the property sources reference
> * the same value they should use the value parameter to create a
> * new instance of the real value for the given property.
>@@ -147,10 +146,9 @@
> * Another variation on returning a value other than the real property value in 
> * <code>getPropertyValue</code> is to return a value which is an
> * <code>IPropertySource</code> (or for which the property sheet can obtain an
>- * <code>IPropertySource</code>). This allows the property sheet to properties
>- * for the value itself. In this case the value to edit is obtained from the
>+ * <code>IPropertySource</code>). In this case the value to edit is obtained from the
> * child property source using <code>getEditableValue</code>. It is this editable value
>- * that will be passed back via this method when the it has been edited
>+ * that will be passed back via this method when the it has been editted
> * 
> *
> * @see #getPropertyValue

Actions: View | Diff

Attachments on bug 24632: 5231