Attachment 40932 Details for Bug 140643 – Additional patch

[patch] Additional patch

v00.txt (text/plain), 1.68 KB, created by Frederic Fusier

on 2006-05-10 09:32:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2006-05-10 09:32:26 EDT

Size: 1.68 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java,v
>retrieving revision 1.123
>diff -u -r1.123 TypeDeclaration.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java	9 May 2006 11:59:57 -0000	1.123
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java	10 May 2006 13:30:54 -0000
>@@ -407,12 +407,13 @@
> 	constructor.bindArguments();
> 	constructor.constructorCall.resolve(constructor.scope);
> 
>-	MethodBinding[] oldMethods = sourceType.methods(); // trigger sorting
>-	MethodBinding[] newMethods;
>-	System.arraycopy(oldMethods, 0, newMethods = new MethodBinding[oldMethods.length + 1], 1, oldMethods.length);
>-	newMethods[0] = constructor.binding; 
>-	sourceType.tagBits &= ~(TagBits.AreMethodsComplete|TagBits.AreMethodsSorted); // still need to resort, since could be valid methods ahead (140643)
>-	sourceType.setMethods(newMethods);
>+	MethodBinding[] methodBindings = sourceType.methods(); // trigger sorting
>+	int length;
>+	System.arraycopy(methodBindings, 0, methodBindings = new MethodBinding[(length = methodBindings.length) + 1], 1, length);
>+	methodBindings[0] = constructor.binding; 
>+	if (++length > 1)
>+		ReferenceBinding.sortMethods(methodBindings, 0, length);	// need to resort, since could be valid methods ahead (140643) - DOM needs eager sorting
>+	sourceType.setMethods(methodBindings);
> 	//===================================================
> 
> 	return constructor.binding;

Actions: View | Diff

Attachments on bug 140643: 40693 | 40932 | 40964