Attachment 39047 Details for Bug 137744 – Better patch

[patch] Better patch

patch_137744.txt (text/plain), 1.87 KB, created by Olivier Thomann

on 2006-04-20 11:38:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2006-04-20 11:38:08 EDT

Size: 1.87 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java,v
>retrieving revision 1.132
>diff -u -r1.132 SourceTypeBinding.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java	10 Apr 2006 18:55:29 -0000	1.132
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java	20 Apr 2006 15:26:47 -0000
>@@ -76,6 +76,8 @@
> 	System.arraycopy(this.methods, 0, temp, 0, this.methods.length);
> 	temp[this.methods.length] = defaultAbstract;
> 	this.methods = temp;
>+	ReferenceBinding.sortMethods(this.methods, 0, this.methods.length - 1);
>+	this.tagBits |= TagBits.AreMethodsSorted;
> }
> public void addDefaultAbstractMethods() {
> 	if ((this.tagBits & TagBits.KnowsDefaultAbstractMethods) != 0) return;
>@@ -88,7 +90,6 @@
> 		ReferenceBinding[][] interfacesToVisit = new ReferenceBinding[5][];
> 		int lastPosition = 0;
> 		interfacesToVisit[lastPosition] = superInterfaces();
>-		boolean hasAddedMethods = false;
> 		for (int i = 0; i <= lastPosition; i++) {
> 			ReferenceBinding[] interfaces = interfacesToVisit[i];
> 			for (int j = 0, length = interfaces.length; j < length; j++) {
>@@ -99,7 +100,6 @@
> 						MethodBinding method = superMethods[m];
> 						if (!implementsMethod(method)) {
> 							addDefaultAbstractMethod(method);
>-							hasAddedMethods = true;
> 						}
> 					}
> 
>@@ -112,13 +112,6 @@
> 				}
> 			}
> 		}
>-		if (hasAddedMethods) {
>-			// re-sort methods
>-			int length = this.methods.length;
>-			if (length > 1) {
>-				ReferenceBinding.sortMethods(this.methods, 0, length - 1);
>-			}
>-		}
> 	}
> }
> /* Add a new synthetic field for <actualOuterLocalVariable>.

Actions: View | Diff

Attachments on bug 137744: 39037 | 39041 | 39047 | 39058 | 39059 | 39155