Attachment 38997 Details for Bug 137634 – Proposed patch to ReferenceCollection.addDependencies()

[patch] Proposed patch to ReferenceCollection.addDependencies()

patch.txt (text/plain), 2.55 KB, created by Tim Hanson

on 2006-04-19 20:29:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Hanson

Created: 2006-04-19 20:29:57 EDT

Size: 2.55 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/builder/ReferenceCollection.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ReferenceCollection.java,v
>retrieving revision 1.20
>diff -u -r1.20 ReferenceCollection.java
>--- model/org/eclipse/jdt/internal/core/builder/ReferenceCollection.java	29 Mar 2006 03:08:49 -0000	1.20
>+++ model/org/eclipse/jdt/internal/core/builder/ReferenceCollection.java	20 Apr 2006 00:18:15 -0000
>@@ -35,24 +35,20 @@
> 	next : for (int i = qNames.length; --i >= 0;) {
> 		char[][] qualifiedTypeName = qNames[i];
> 		while (!includes(qualifiedTypeName)) {
>-			if (qualifiedTypeName.length == 1) {
>-				if (!includes(qualifiedTypeName[0])) {
>-					int length = this.simpleNameReferences.length;
>-					System.arraycopy(this.simpleNameReferences, 0, this.simpleNameReferences = new char[length + 1][], 0, length);
>-					this.simpleNameReferences[length] = qualifiedTypeName[0];
>-				}
>-				continue next;
>-			} else {
>-				int length = this.qualifiedNameReferences.length;
>-				System.arraycopy(this.qualifiedNameReferences, 0, this.qualifiedNameReferences = new char[length + 1][][], 0, length);
>-				this.qualifiedNameReferences[length] = qualifiedTypeName;
>-
>-				qualifiedTypeName = CharOperation.subarray(qualifiedTypeName, 0, qualifiedTypeName.length - 1);
>-				char[][][] temp = internQualifiedNames(new char[][][] {qualifiedTypeName});
>-				if (temp == EmptyQualifiedNames)
>-					continue next; // qualifiedTypeName is a well known name
>-				qualifiedTypeName = temp[0];
>+			if (!includes(qualifiedTypeName[qualifiedTypeName.length - 1])) {
>+				int length = this.simpleNameReferences.length;
>+				System.arraycopy(this.simpleNameReferences, 0, this.simpleNameReferences = new char[length + 1][], 0, length);
>+				this.simpleNameReferences[length] = qualifiedTypeName[qualifiedTypeName.length - 1];				
> 			}
>+			int length = this.qualifiedNameReferences.length;
>+			System.arraycopy(this.qualifiedNameReferences, 0, this.qualifiedNameReferences = new char[length + 1][][], 0, length);
>+			this.qualifiedNameReferences[length] = qualifiedTypeName;
>+
>+			qualifiedTypeName = CharOperation.subarray(qualifiedTypeName, 0, qualifiedTypeName.length - 1);
>+			char[][][] temp = internQualifiedNames(new char[][][] {qualifiedTypeName});
>+			if (temp == EmptyQualifiedNames)
>+				continue next; // qualifiedTypeName is a well known name
>+			qualifiedTypeName = temp[0];
> 		}
> 	}
> }

Actions: View | Diff

Attachments on bug 137634: 38997