Attachment 38936 Details for Bug 112030 – Proposed fix

[patch] Proposed fix

patch002.txt (text/plain), 1.78 KB, created by David Audel

on 2006-04-19 11:43:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2006-04-19 11:43:00 EDT

Size: 1.78 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/model/SignatureTests.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/SignatureTests.java,v
>retrieving revision 1.38
>diff -u -r1.38 SignatureTests.java
>--- src/org/eclipse/jdt/core/tests/model/SignatureTests.java	29 Mar 2006 04:03:07 -0000	1.38
>+++ src/org/eclipse/jdt/core/tests/model/SignatureTests.java	19 Apr 2006 15:30:36 -0000
>@@ -453,7 +453,15 @@
> 	assertEquals("Signature#getReturnType is not correct3", "Qlist<Qxxx;>;",
> 			Signature.getReturnType(methodSig));
> }
>-
>+/**
>+ * https://bugs.eclipse.org/bugs/show_bug.cgi?id=112030
>+ * @see Signature
>+ */
>+public void testGetReturnType2() {
>+	String methodSig = "(LObject;)+[I";
>+	assertEquals("Signature#getReturnType is not correct", "+[I",
>+			Signature.getReturnType(methodSig));
>+}
> /**
>  * @see Signature
>  */
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/util/Util.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/Util.java,v
>retrieving revision 1.92
>diff -u -r1.92 Util.java
>--- model/org/eclipse/jdt/internal/core/util/Util.java	6 Apr 2006 01:47:51 -0000	1.92
>+++ model/org/eclipse/jdt/internal/core/util/Util.java	19 Apr 2006 15:30:40 -0000
>@@ -2664,8 +2664,8 @@
> 				return start;
> 			case Signature.C_SUPER :
> 			case Signature.C_EXTENDS :
>-				// need a minimum 4 chars "+Lx;"
>-				if (start >= string.length - 3) {
>+				// need a minimum 3 chars "+[I"
>+				if (start >= string.length - 2) {
> 					throw new IllegalArgumentException();
> 				}
> 				break;

Actions: View | Diff

Attachments on bug 112030: 38936