Attachment 3795 Details for Bug 32523 – This also solves the "global and context enablement out of sync" problem

[patch] This also solves the "global and context enablement out of sync" problem

32523.patch (text/plain), 1.97 KB, created by Boris Shingarov

on 2003-02-28 15:50:11 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Boris Shingarov

Created: 2003-02-28 15:50:11 EST

Size: 1.97 KB

patch

obsolete

>Index: src/org/eclipse/team/internal/ccvs/ui/repo/RemoveRootAction.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/repo/RemoveRootAction.java,v
>retrieving revision 1.5
>diff -u -r1.5 RemoveRootAction.java
>--- src/org/eclipse/team/internal/ccvs/ui/repo/RemoveRootAction.java	20 Feb 2003 00:05:02 -0000	1.5
>+++ src/org/eclipse/team/internal/ccvs/ui/repo/RemoveRootAction.java	28 Feb 2003 20:48:19 -0000
>@@ -46,7 +46,7 @@
> 	 */
> 	protected ICVSRepositoryLocation[] getSelectedRemoteRoots() {
> 		ArrayList resources = null;
>-		if (!selection.isEmpty()) {
>+		if (!(selection==null) && !selection.isEmpty()) {
> 			resources = new ArrayList();
> 			Iterator elements = ((IStructuredSelection) selection).iterator();
> 			while (elements.hasNext()) {
>Index: src/org/eclipse/team/internal/ccvs/ui/repo/RepositoriesView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/repo/RepositoriesView.java,v
>retrieving revision 1.7
>diff -u -r1.7 RepositoriesView.java
>--- src/org/eclipse/team/internal/ccvs/ui/repo/RepositoriesView.java	19 Feb 2003 22:32:24 -0000	1.7
>+++ src/org/eclipse/team/internal/ccvs/ui/repo/RepositoriesView.java	28 Feb 2003 20:48:19 -0000
>@@ -143,6 +143,9 @@
> 			}
> 		});
> 		removeRootAction = new RemoveRootAction(viewer.getControl().getShell());
>+		removeRootAction.selectionChanged((IStructuredSelection)null);
>+		IActionBars bars = getViewSite().getActionBars();
>+		bars.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, removeRootAction);
> 		super.contributeActions();
> 	}
> 	
>@@ -171,8 +174,6 @@
> 		if (newAnonAction != null)
> 			sub.add(newAnonAction);
> 		manager.add(removeRootAction);
>-		IActionBars bars = getViewSite().getActionBars();
>-		bars.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, removeRootAction);
> 	}
> 	
> 	/*

Actions: View | Diff

Attachments on bug 32523: 3795