Attachment 30196 Details for Bug 116958 – Proposed Patch to the NPE

[patch] Proposed Patch to the NPE

PR116958patch.txt (text/plain), 1.24 KB, created by Theodora Yeung

on 2005-11-17 18:55:28 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Theodora Yeung

Created: 2005-11-17 18:55:28 EST

Size: 1.24 KB

patch

obsolete

>Index: SourceTypeBinding.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java,v
>retrieving revision 1.89.2.6
>diff -u -r1.89.2.6 SourceTypeBinding.java
>--- SourceTypeBinding.java	19 Oct 2005 08:03:04 -0000	1.89.2.6
>+++ SourceTypeBinding.java	17 Nov 2005 23:55:21 -0000
>@@ -1203,8 +1203,13 @@
> 	if (this.scope.compilerOptions().sourceLevel >= ClassFileConstants.JDK1_5) {
> 		if ((method.getAnnotationTagBits() & AnnotationDeprecated) != 0)
> 			method.modifiers |= AccDeprecated;
>-		else if ((method.modifiers & AccDeprecated) != 0)
>-			this.scope.problemReporter().missingDeprecatedAnnotationForMethod(method.sourceMethod());
>+		else if ((method.modifiers & AccDeprecated) != 0){
>+			AbstractMethodDeclaration methodDecl = method.sourceMethod();
>+			// if null, method could not be resolved in previous iteration.
>+			// Something is already wrong, we will not log this additional error. 
>+			if( methodDecl != null )
>+				this.scope.problemReporter().missingDeprecatedAnnotationForMethod(methodDecl);
>+		}
> 	}
> 	if (isViewedAsDeprecated() && !method.isDeprecated())
> 		method.modifiers |= AccDeprecatedImplicitly;

Actions: View | Diff

Attachments on bug 116958: 30195 | 30196