Attachment 28224 Details for Bug 103051 – patch that makes performance acceptable on my test app

[patch] patch that makes performance acceptable on my test app

stringBufferReadCLWA.patch.txt (text/plain), 1.13 KB, created by Ron Bodkin

on 2005-10-13 06:48:14 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ron Bodkin

Created: 2005-10-13 06:48:14 EDT

Size: 1.13 KB

patch

obsolete

>Index: ClassLoaderWeavingAdaptor.java
>===================================================================
>RCS file: /home/technology/org.aspectj/modules/loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java,v
>retrieving revision 1.16
>diff -u -r1.16 ClassLoaderWeavingAdaptor.java
>--- ClassLoaderWeavingAdaptor.java	11 Oct 2005 14:39:33 -0000	1.16
>+++ ClassLoaderWeavingAdaptor.java	13 Oct 2005 10:47:46 -0000
>@@ -416,16 +416,17 @@
>      * @return the bytecode representation of the aspect
>      */
>     private String readAspect(String name, ClassLoader loader){
>+        System.err.println("reading aspect: "+name+" at "+loader.getClass()+" id= "+System.identityHashCode(loader));
>     	try {
>-    		String result = "";
>+    		StringBuffer result = new StringBuffer();
>         	InputStream is = loader.getResourceAsStream(name.replace('.','/')+".class");
> 			int b = is.read();
> 			while(b!=-1){
>-				result = result + b;
>+				result.append(b);
> 				b=is.read();
> 			}
> 			is.close();
>-	    	return result;
>+	    	return result.toString();
> 		} catch (IOException e) {
> 			e.printStackTrace();
> 			return "";

Flags:

aclement: iplog+

Actions: View | Diff

Attachments on bug 103051: 28224