Attachment 27853 Details for Bug 110596 – more general patch

[patch] more general patch

patchjdtcore001.txt (text/plain), 1.82 KB, created by David Audel

on 2005-10-05 06:17:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2005-10-05 06:17:42 EDT

Size: 1.82 KB

patch

obsolete

>Index: codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.251
>diff -u -r1.251 CompletionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	29 Aug 2005 16:08:23 -0000	1.251
>+++ codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	5 Oct 2005 09:12:59 -0000
>@@ -494,8 +494,37 @@
> 								}
> 							}
> 						}
>-					} else {
>-						foundType.mustBeQualified = true;
>+					} else if(!foundType.mustBeQualified){
>+						done : for (int j = 0; j < this.onDemandImportCacheCount; j++) {
>+							ImportBinding importBinding = this.onDemandImportsCache[j];
>+
>+							char[][] importName = importBinding.compoundName;
>+							char[] importFlatName = CharOperation.concatWith(importName, '.');
>+						
>+							if(fullyQualifiedEnclosingTypeOrPackageName == null) {
>+								if(enclosingTypeNames != null && enclosingTypeNames.length != 0) {
>+									fullyQualifiedEnclosingTypeOrPackageName =
>+										CharOperation.concat(
>+												packageName,
>+												flatEnclosingTypeNames,
>+												'.');
>+								} else {
>+									fullyQualifiedEnclosingTypeOrPackageName =
>+										packageName;
>+								}
>+							}
>+							if(CharOperation.equals(fullyQualifiedEnclosingTypeOrPackageName, importFlatName)) {
>+								if(importBinding.isStatic()) {
>+									if((modifiers & IConstants.AccStatic) != 0) {
>+										foundType.mustBeQualified = true;
>+										break done;
>+									}
>+								} else {
>+									foundType.mustBeQualified = true;
>+									break done;
>+								}
>+							}
>+						}
> 					}
> 					proposeType(
> 							packageName,

Actions: View | Diff

Attachments on bug 110596: 27513 | 27853